Skip to content

ARROW-11375: [Rust] Fix deprecation warning in clippy - #9314

Closed
jorgecarleitao wants to merge 1 commit into
apache:masterfrom
jorgecarleitao:fix_masteer
Closed

ARROW-11375: [Rust] Fix deprecation warning in clippy#9314
jorgecarleitao wants to merge 1 commit into
apache:masterfrom
jorgecarleitao:fix_masteer

Conversation

@jorgecarleitao

@jorgecarleitaojorgecarleitao commented Jan 25, 2021

Copy link
Copy Markdown
Member

Master and all PRs are failing with a deprecation warning in clippy. This fixes it.

@github-actions

github-actionsBot commented Jan 25, 2021

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@codecov-io

codecov-io commented Jan 25, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9314 (a4572d2) into master (cf7638f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #9314 +/- ##
=======================================
Coverage 81.89% 81.89% =======================================
Files 215 215 Lines 52988 52988 =======================================
Hits 43392 43392 Misses 9596 9596

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7638f...a4572d2. Read the comment docs.

@alambalamb mentioned this pull request Jan 25, 2021
Closed
@alamb

alamb commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

It seems like perhaps this is related to the release of criterion: https://crates.io/crates/criterion/0.3.4 (On Jan 24 2021)

@alamb

alamb commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

The Clippy test still is failing; I found I had to run cargo update in my local arrow checkout to reproduce the failure.

alamb
alamb reviewed Jan 25, 2021
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this @jorgecarleitao - ❤️

I think there is still some clippy errors (I can see them locally too when I run cargo update) but this PR fixes some of them so merging it in seems like a good idea to me.

I can take a crack at updating the error too later today if you don't get around to it.

@jorgecarleitao

jorgecarleitao commented Jan 25, 2021

Copy link
Copy Markdown
MemberAuthor

It should be fixed now. :)

@alamb

alamb commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

Screen Shot 2021-01-25 at 9 28 56 AM

Looking clean and green 💚

nevi-me
nevi-me approved these changes Jan 25, 2021
View reviewed changes

@nevi-menevi-me left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need not wait for Travis

@alamb

alamb commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

I will file a JIRA ticket and merge this in

@alambalamb changed the title [Rust] Fix deprecation warning in clippyARROW-11375: [Rust] Fix deprecation warning in clippyJan 25, 2021
@github-actions

github-actionsBot commented Jan 25, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-11375

@alambalamb closed this Jan 25, 2021
kszucs pushed a commit that referenced this pull request Jan 25, 2021
@jorgecarleitao@kszucs
ARROW-11375: [Rust] Fix deprecation warning in clippy
0708422
Master and all PRs are failing with a deprecation warning in clippy. This fixes it.
Closes#9314 from jorgecarleitao/fix_masteer
Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
@alambalamb mentioned this pull request Jan 26, 2021
Closed
ilya-biryukov pushed a commit to cube-js/arrow that referenced this pull request Jan 26, 2021
@jorgecarleitao@ilya-biryukov
ARROW-11375: [Rust] Fix deprecation warning in clippy
5fe7f42
Master and all PRs are failing with a deprecation warning in clippy. This fixes it.
Closesapache#9314 from jorgecarleitao/fix_masteer
Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
@asfimportasfimport mentioned this pull request Jan 26, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alambalambalamb approved these changes
@nevi-menevi-menevi-me approved these changes

Assignees

No one assigned

Labels

Component: Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jorgecarleitao@codecov-io@alamb@nevi-me