ARROW-12262: [Doc] Enable S3 and Flight in docs build - #9933

Closed
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs
Closed

ARROW-12262: [Doc] Enable S3 and Flight in docs build#9933
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs

Conversation

@pitrou

Copy link
Copy Markdown
Member

Also use Ubuntu 20.04 by default, instead of 18.04.

@pitrou

Copy link
Copy Markdown
MemberAuthor

The Python Flight API docs still fail generating because of:

# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license"for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in<module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in<module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>> # c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)

@pitrou
pitrou requested review from kou and kszucsApril 7, 2021 16:44
@pitrou

Copy link
Copy Markdown
MemberAuthor

For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/

@pitrou

Copy link
Copy Markdown
MemberAuthor

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

@kszucs

Copy link
Copy Markdown
Member

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, it doesn't seem to work:

  • we need a more recent libprotobuf than 20.04 provides
  • our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/

@github-actions

Copy link
Copy Markdown

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.

Comment threaddocs/source/status.rst Outdated
@pitrou

Copy link
Copy Markdown
MemberAuthor

Our packages for Ubuntu 20.10 use system gRPC.

That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...

# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.

Do you want me to create a patch for it?

@pitrou

Copy link
Copy Markdown
MemberAuthor

That would be nice, yes :-)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

OK. I'll work on it.

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 5e79f8f to afd1324CompareApril 8, 2021 08:26
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: afd1324b8c77f71b8fa8ac9bfe4deb0a4bb058ce

Submitted crossbow builds: ursacomputing/crossbow @ actions-285

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from afd1324 to 971b698CompareApril 8, 2021 09:12
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 971b6987e59235f20060e36c05e22e73216b85f9

Submitted crossbow builds: ursacomputing/crossbow @ actions-286

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 971b698 to 73993bdCompareApril 8, 2021 13:36
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 73993bd22e6c9b278513aa52b7b1fc94b1f0b6de

Submitted crossbow builds: ursacomputing/crossbow @ actions-297

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 73993bd to 9ccb811CompareApril 8, 2021 18:01
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ccb811082271fa532bb3b2556af3f021089d44b

Submitted crossbow builds: ursacomputing/crossbow @ actions-299

TaskStatus
test-ubuntu-20.10-docsAzure

@kou

kou commented Apr 10, 2021

Copy link
Copy Markdown
Member

c-ares improvement: #9977

@kszucs
kszucsforce-pushed the ARROW-12262-ubuntu-docs branch from 9ccb811 to 571df57CompareApril 13, 2021 10:59
@kszucs

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-316

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Crossbow failed unrelatedly in the Java build :-/

@kou

kou commented Apr 14, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-319

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@kszucs@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

ARROW-12262: [Doc] Enable S3 and Flight in docs build - #9933

Closed
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs
Closed

ARROW-12262: [Doc] Enable S3 and Flight in docs build#9933
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs

Conversation

@pitrou

Copy link
Copy Markdown
Member

Also use Ubuntu 20.04 by default, instead of 18.04.

@pitrou

Copy link
Copy Markdown
MemberAuthor

The Python Flight API docs still fail generating because of:

# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license"for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in<module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in<module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>> # c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)

@pitrou
pitrou requested review from kou and kszucsApril 7, 2021 16:44
@pitrou

Copy link
Copy Markdown
MemberAuthor

For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/

@pitrou

Copy link
Copy Markdown
MemberAuthor

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

@kszucs

Copy link
Copy Markdown
Member

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, it doesn't seem to work:

  • we need a more recent libprotobuf than 20.04 provides
  • our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/

@github-actions

Copy link
Copy Markdown

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.

Comment threaddocs/source/status.rst Outdated
@pitrou

Copy link
Copy Markdown
MemberAuthor

Our packages for Ubuntu 20.10 use system gRPC.

That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...

# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.

Do you want me to create a patch for it?

@pitrou

Copy link
Copy Markdown
MemberAuthor

That would be nice, yes :-)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

OK. I'll work on it.

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 5e79f8f to afd1324CompareApril 8, 2021 08:26
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: afd1324b8c77f71b8fa8ac9bfe4deb0a4bb058ce

Submitted crossbow builds: ursacomputing/crossbow @ actions-285

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from afd1324 to 971b698CompareApril 8, 2021 09:12
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 971b6987e59235f20060e36c05e22e73216b85f9

Submitted crossbow builds: ursacomputing/crossbow @ actions-286

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 971b698 to 73993bdCompareApril 8, 2021 13:36
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 73993bd22e6c9b278513aa52b7b1fc94b1f0b6de

Submitted crossbow builds: ursacomputing/crossbow @ actions-297

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 73993bd to 9ccb811CompareApril 8, 2021 18:01
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ccb811082271fa532bb3b2556af3f021089d44b

Submitted crossbow builds: ursacomputing/crossbow @ actions-299

TaskStatus
test-ubuntu-20.10-docsAzure

@kou

kou commented Apr 10, 2021

Copy link
Copy Markdown
Member

c-ares improvement: #9977

@kszucs
kszucsforce-pushed the ARROW-12262-ubuntu-docs branch from 9ccb811 to 571df57CompareApril 13, 2021 10:59
@kszucs

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-316

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Crossbow failed unrelatedly in the Java build :-/

@kou

kou commented Apr 14, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-319

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@kszucs@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ARROW-12262: [Doc] Enable S3 and Flight in docs build - #9933

Closed
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs
Closed

ARROW-12262: [Doc] Enable S3 and Flight in docs build#9933
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs

Conversation

@pitrou

Copy link
Copy Markdown
Member

Also use Ubuntu 20.04 by default, instead of 18.04.

@pitrou

Copy link
Copy Markdown
MemberAuthor

The Python Flight API docs still fail generating because of:

# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license"for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in<module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in<module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>> # c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)

@pitrou
pitrou requested review from kou and kszucsApril 7, 2021 16:44
@pitrou

Copy link
Copy Markdown
MemberAuthor

For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/

@pitrou

Copy link
Copy Markdown
MemberAuthor

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

@kszucs

Copy link
Copy Markdown
Member

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, it doesn't seem to work:

  • we need a more recent libprotobuf than 20.04 provides
  • our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/

@github-actions

Copy link
Copy Markdown

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.

Comment threaddocs/source/status.rst Outdated
@pitrou

Copy link
Copy Markdown
MemberAuthor

Our packages for Ubuntu 20.10 use system gRPC.

That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...

# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.

Do you want me to create a patch for it?

@pitrou

Copy link
Copy Markdown
MemberAuthor

That would be nice, yes :-)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

OK. I'll work on it.

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 5e79f8f to afd1324CompareApril 8, 2021 08:26
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: afd1324b8c77f71b8fa8ac9bfe4deb0a4bb058ce

Submitted crossbow builds: ursacomputing/crossbow @ actions-285

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from afd1324 to 971b698CompareApril 8, 2021 09:12
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 971b6987e59235f20060e36c05e22e73216b85f9

Submitted crossbow builds: ursacomputing/crossbow @ actions-286

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 971b698 to 73993bdCompareApril 8, 2021 13:36
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 73993bd22e6c9b278513aa52b7b1fc94b1f0b6de

Submitted crossbow builds: ursacomputing/crossbow @ actions-297

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 73993bd to 9ccb811CompareApril 8, 2021 18:01
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ccb811082271fa532bb3b2556af3f021089d44b

Submitted crossbow builds: ursacomputing/crossbow @ actions-299

TaskStatus
test-ubuntu-20.10-docsAzure

@kou

kou commented Apr 10, 2021

Copy link
Copy Markdown
Member

c-ares improvement: #9977

@kszucs
kszucsforce-pushed the ARROW-12262-ubuntu-docs branch from 9ccb811 to 571df57CompareApril 13, 2021 10:59
@kszucs

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-316

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Crossbow failed unrelatedly in the Java build :-/

@kou

kou commented Apr 14, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-319

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@kszucs@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ARROW-12262: [Doc] Enable S3 and Flight in docs build - #9933

Closed
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs
Closed

ARROW-12262: [Doc] Enable S3 and Flight in docs build#9933
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs

Conversation

@pitrou

Copy link
Copy Markdown
Member

Also use Ubuntu 20.04 by default, instead of 18.04.

@pitrou

Copy link
Copy Markdown
MemberAuthor

The Python Flight API docs still fail generating because of:

# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license"for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in<module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in<module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>> # c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)

@pitrou
pitrou requested review from kou and kszucsApril 7, 2021 16:44
@pitrou

Copy link
Copy Markdown
MemberAuthor

For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/

@pitrou

Copy link
Copy Markdown
MemberAuthor

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

@kszucs

Copy link
Copy Markdown
Member

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, it doesn't seem to work:

  • we need a more recent libprotobuf than 20.04 provides
  • our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/

@github-actions

Copy link
Copy Markdown

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.

Comment threaddocs/source/status.rst Outdated
@pitrou

Copy link
Copy Markdown
MemberAuthor

Our packages for Ubuntu 20.10 use system gRPC.

That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...

# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.

Do you want me to create a patch for it?

@pitrou

Copy link
Copy Markdown
MemberAuthor

That would be nice, yes :-)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

OK. I'll work on it.

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 5e79f8f to afd1324CompareApril 8, 2021 08:26
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: afd1324b8c77f71b8fa8ac9bfe4deb0a4bb058ce

Submitted crossbow builds: ursacomputing/crossbow @ actions-285

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from afd1324 to 971b698CompareApril 8, 2021 09:12
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 971b6987e59235f20060e36c05e22e73216b85f9

Submitted crossbow builds: ursacomputing/crossbow @ actions-286

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 971b698 to 73993bdCompareApril 8, 2021 13:36
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 73993bd22e6c9b278513aa52b7b1fc94b1f0b6de

Submitted crossbow builds: ursacomputing/crossbow @ actions-297

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 73993bd to 9ccb811CompareApril 8, 2021 18:01
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ccb811082271fa532bb3b2556af3f021089d44b

Submitted crossbow builds: ursacomputing/crossbow @ actions-299

TaskStatus
test-ubuntu-20.10-docsAzure

@kou

kou commented Apr 10, 2021

Copy link
Copy Markdown
Member

c-ares improvement: #9977

@kszucs
kszucsforce-pushed the ARROW-12262-ubuntu-docs branch from 9ccb811 to 571df57CompareApril 13, 2021 10:59
@kszucs

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-316

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Crossbow failed unrelatedly in the Java build :-/

@kou

kou commented Apr 14, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-319

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@kszucs@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

ARROW-12262: [Doc] Enable S3 and Flight in docs build - #9933

Closed
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs
Closed

ARROW-12262: [Doc] Enable S3 and Flight in docs build#9933
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs

Conversation

@pitrou

Copy link
Copy Markdown
Member

Also use Ubuntu 20.04 by default, instead of 18.04.

@pitrou

Copy link
Copy Markdown
MemberAuthor

The Python Flight API docs still fail generating because of:

# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license"for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in<module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in<module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>> # c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)

@pitrou
pitrou requested review from kou and kszucsApril 7, 2021 16:44
@pitrou

Copy link
Copy Markdown
MemberAuthor

For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/

@pitrou

Copy link
Copy Markdown
MemberAuthor

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

@kszucs

Copy link
Copy Markdown
Member

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, it doesn't seem to work:

  • we need a more recent libprotobuf than 20.04 provides
  • our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/

@github-actions

Copy link
Copy Markdown

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.

Comment threaddocs/source/status.rst Outdated
@pitrou

Copy link
Copy Markdown
MemberAuthor

Our packages for Ubuntu 20.10 use system gRPC.

That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...

# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.

Do you want me to create a patch for it?

@pitrou

Copy link
Copy Markdown
MemberAuthor

That would be nice, yes :-)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

OK. I'll work on it.

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 5e79f8f to afd1324CompareApril 8, 2021 08:26
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: afd1324b8c77f71b8fa8ac9bfe4deb0a4bb058ce

Submitted crossbow builds: ursacomputing/crossbow @ actions-285

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from afd1324 to 971b698CompareApril 8, 2021 09:12
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 971b6987e59235f20060e36c05e22e73216b85f9

Submitted crossbow builds: ursacomputing/crossbow @ actions-286

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 971b698 to 73993bdCompareApril 8, 2021 13:36
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 73993bd22e6c9b278513aa52b7b1fc94b1f0b6de

Submitted crossbow builds: ursacomputing/crossbow @ actions-297

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 73993bd to 9ccb811CompareApril 8, 2021 18:01
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ccb811082271fa532bb3b2556af3f021089d44b

Submitted crossbow builds: ursacomputing/crossbow @ actions-299

TaskStatus
test-ubuntu-20.10-docsAzure

@kou

kou commented Apr 10, 2021

Copy link
Copy Markdown
Member

c-ares improvement: #9977

@kszucs
kszucsforce-pushed the ARROW-12262-ubuntu-docs branch from 9ccb811 to 571df57CompareApril 13, 2021 10:59
@kszucs

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-316

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Crossbow failed unrelatedly in the Java build :-/

@kou

kou commented Apr 14, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-319

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@kszucs@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ARROW-12262: [Doc] Enable S3 and Flight in docs build - #9933

Closed
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs
Closed

ARROW-12262: [Doc] Enable S3 and Flight in docs build#9933
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs

Conversation

@pitrou

Copy link
Copy Markdown
Member

Also use Ubuntu 20.04 by default, instead of 18.04.

@pitrou

Copy link
Copy Markdown
MemberAuthor

The Python Flight API docs still fail generating because of:

# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license"for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in<module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in<module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>> # c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)

@pitrou
pitrou requested review from kou and kszucsApril 7, 2021 16:44
@pitrou

Copy link
Copy Markdown
MemberAuthor

For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/

@pitrou

Copy link
Copy Markdown
MemberAuthor

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

@kszucs

Copy link
Copy Markdown
Member

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, it doesn't seem to work:

  • we need a more recent libprotobuf than 20.04 provides
  • our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/

@github-actions

Copy link
Copy Markdown

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.

Comment threaddocs/source/status.rst Outdated
@pitrou

Copy link
Copy Markdown
MemberAuthor

Our packages for Ubuntu 20.10 use system gRPC.

That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...

# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.

Do you want me to create a patch for it?

@pitrou

Copy link
Copy Markdown
MemberAuthor

That would be nice, yes :-)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

OK. I'll work on it.

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 5e79f8f to afd1324CompareApril 8, 2021 08:26
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: afd1324b8c77f71b8fa8ac9bfe4deb0a4bb058ce

Submitted crossbow builds: ursacomputing/crossbow @ actions-285

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from afd1324 to 971b698CompareApril 8, 2021 09:12
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 971b6987e59235f20060e36c05e22e73216b85f9

Submitted crossbow builds: ursacomputing/crossbow @ actions-286

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 971b698 to 73993bdCompareApril 8, 2021 13:36
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 73993bd22e6c9b278513aa52b7b1fc94b1f0b6de

Submitted crossbow builds: ursacomputing/crossbow @ actions-297

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 73993bd to 9ccb811CompareApril 8, 2021 18:01
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ccb811082271fa532bb3b2556af3f021089d44b

Submitted crossbow builds: ursacomputing/crossbow @ actions-299

TaskStatus
test-ubuntu-20.10-docsAzure

@kou

kou commented Apr 10, 2021

Copy link
Copy Markdown
Member

c-ares improvement: #9977

@kszucs
kszucsforce-pushed the ARROW-12262-ubuntu-docs branch from 9ccb811 to 571df57CompareApril 13, 2021 10:59
@kszucs

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-316

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Crossbow failed unrelatedly in the Java build :-/

@kou

kou commented Apr 14, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-319

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@kszucs@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ARROW-12262: [Doc] Enable S3 and Flight in docs build - #9933

Closed
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs
Closed

ARROW-12262: [Doc] Enable S3 and Flight in docs build#9933
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs

Conversation

@pitrou

Copy link
Copy Markdown
Member

Also use Ubuntu 20.04 by default, instead of 18.04.

@pitrou

Copy link
Copy Markdown
MemberAuthor

The Python Flight API docs still fail generating because of:

# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license"for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in<module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in<module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>> # c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)

@pitrou
pitrou requested review from kou and kszucsApril 7, 2021 16:44
@pitrou

Copy link
Copy Markdown
MemberAuthor

For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/

@pitrou

Copy link
Copy Markdown
MemberAuthor

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

@kszucs

Copy link
Copy Markdown
Member

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, it doesn't seem to work:

  • we need a more recent libprotobuf than 20.04 provides
  • our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/

@github-actions

Copy link
Copy Markdown

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.

Comment threaddocs/source/status.rst Outdated
@pitrou

Copy link
Copy Markdown
MemberAuthor

Our packages for Ubuntu 20.10 use system gRPC.

That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...

# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.

Do you want me to create a patch for it?

@pitrou

Copy link
Copy Markdown
MemberAuthor

That would be nice, yes :-)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

OK. I'll work on it.

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 5e79f8f to afd1324CompareApril 8, 2021 08:26
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: afd1324b8c77f71b8fa8ac9bfe4deb0a4bb058ce

Submitted crossbow builds: ursacomputing/crossbow @ actions-285

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from afd1324 to 971b698CompareApril 8, 2021 09:12
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 971b6987e59235f20060e36c05e22e73216b85f9

Submitted crossbow builds: ursacomputing/crossbow @ actions-286

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 971b698 to 73993bdCompareApril 8, 2021 13:36
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 73993bd22e6c9b278513aa52b7b1fc94b1f0b6de

Submitted crossbow builds: ursacomputing/crossbow @ actions-297

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 73993bd to 9ccb811CompareApril 8, 2021 18:01
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ccb811082271fa532bb3b2556af3f021089d44b

Submitted crossbow builds: ursacomputing/crossbow @ actions-299

TaskStatus
test-ubuntu-20.10-docsAzure

@kou

kou commented Apr 10, 2021

Copy link
Copy Markdown
Member

c-ares improvement: #9977

@kszucs
kszucsforce-pushed the ARROW-12262-ubuntu-docs branch from 9ccb811 to 571df57CompareApril 13, 2021 10:59
@kszucs

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-316

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Crossbow failed unrelatedly in the Java build :-/

@kou

kou commented Apr 14, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-319

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@kszucs@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

ARROW-12262: [Doc] Enable S3 and Flight in docs build - #9933

Closed
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs
Closed

ARROW-12262: [Doc] Enable S3 and Flight in docs build#9933
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-12262-ubuntu-docs

Conversation

@pitrou

Copy link
Copy Markdown
Member

Also use Ubuntu 20.04 by default, instead of 18.04.

@pitrou

Copy link
Copy Markdown
MemberAuthor

The Python Flight API docs still fail generating because of:

# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license"for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in<module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in<module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>> # c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)

@pitrou
pitrou requested review from kou and kszucsApril 7, 2021 16:44
@pitrou

Copy link
Copy Markdown
MemberAuthor

For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/

@pitrou

Copy link
Copy Markdown
MemberAuthor

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

@kszucs

Copy link
Copy Markdown
Member

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, it doesn't seem to work:

  • we need a more recent libprotobuf than 20.04 provides
  • our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/

@github-actions

Copy link
Copy Markdown

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.

Comment threaddocs/source/status.rst Outdated
@pitrou

Copy link
Copy Markdown
MemberAuthor

Our packages for Ubuntu 20.10 use system gRPC.

That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...

# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.

Do you want me to create a patch for it?

@pitrou

Copy link
Copy Markdown
MemberAuthor

That would be nice, yes :-)

@kou

kou commented Apr 8, 2021

Copy link
Copy Markdown
Member

OK. I'll work on it.

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 5e79f8f to afd1324CompareApril 8, 2021 08:26
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: afd1324b8c77f71b8fa8ac9bfe4deb0a4bb058ce

Submitted crossbow builds: ursacomputing/crossbow @ actions-285

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from afd1324 to 971b698CompareApril 8, 2021 09:12
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 971b6987e59235f20060e36c05e22e73216b85f9

Submitted crossbow builds: ursacomputing/crossbow @ actions-286

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 971b698 to 73993bdCompareApril 8, 2021 13:36
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 73993bd22e6c9b278513aa52b7b1fc94b1f0b6de

Submitted crossbow builds: ursacomputing/crossbow @ actions-297

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou
pitrouforce-pushed the ARROW-12262-ubuntu-docs branch from 73993bd to 9ccb811CompareApril 8, 2021 18:01
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ccb811082271fa532bb3b2556af3f021089d44b

Submitted crossbow builds: ursacomputing/crossbow @ actions-299

TaskStatus
test-ubuntu-20.10-docsAzure

@kou

kou commented Apr 10, 2021

Copy link
Copy Markdown
Member

c-ares improvement: #9977

@kszucs
kszucsforce-pushed the ARROW-12262-ubuntu-docs branch from 9ccb811 to 571df57CompareApril 13, 2021 10:59
@kszucs

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-316

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Crossbow failed unrelatedly in the Java build :-/

@kou

kou commented Apr 14, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions

Copy link
Copy Markdown

Revision: 1720a0768989a8c1f70283e4f66ef6ef762e4e20

Submitted crossbow builds: ursacomputing/crossbow @ actions-319

TaskStatus
test-ubuntu-20.10-docsAzure

@pitrou

Copy link
Copy Markdown
MemberAuthor

Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@kszucs@kou