Uh oh!
There was an error while loading. Please reload this page.
DRAFT: Protobuf schema review - #10215
Closed
reuvenlax wants to merge 2 commits into
Closed
Conversation
reuvenlaxforce-pushed
the
protobuf_schema_review
branch
2 times, most recently
from
December 5, 2019 21:35
a44f082 to
e838506Comparereuvenlaxforce-pushed
the
protobuf_schema_review
branch
from
December 11, 2019 18:52
3da325b to
a6f369dCompare
reuvenlaxforce-pushed
the
protobuf_schema_review
branch
from
December 21, 2019 18:36
6267882 to
decc78bComparealexvanboxel
commented
Feb 19, 2020
Contributor
I think this PR can be closed as most of the changes are in. Only thing left to review is this: Any objections closing this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.