Uh oh!
There was an error while loading. Please reload this page.
[BEAM-7274] Add DynamicMessage Schema support - #10502
Conversation
e4a6ec6 to
3a6ca71Comparealexvanboxel
commented
Jan 5, 2020
Run Java PreCommit |
alexvanboxel
commented
Jan 5, 2020
R: @reuvenlax this is an implementation for DynamicMessages. It takes into account the new Logical Types and also use RowWithStorage instead of going with the getters. |
04a8580 to
058a636Compare058a636 to
97414c6Comparealexvanboxel
commented
Jan 8, 2020
@reuvenlax this is ready for review. It has feature parity with the static compiled proto, including all logical types. |
97414c6 to
e352ff4Comparealexvanboxel
commented
Jan 10, 2020
Run Java PreCommit |
51f9c9d to
a83d803Comparealexvanboxel
commented
Feb 9, 2020
This branch has been updated to take the new Logical Types into account. |
602869a to
7e57a39Compare7e57a39 to
9a13256Comparealexvanboxel
commented
Feb 18, 2020
Run Java PreCommit |
@reuvenlax@iemejia@TheNeuralBit I've tested this PR extensively on Dataflow. This is way more stable than the original DynamicMessage schema implementation. Can I get a LGTM, that I can focus on the options. Thanks. (master is failing, it was green till rebase) |
9a13256 to
0edacbbComparealexvanboxel
commented
Feb 19, 2020
Run Java PreCommit |
alexvanboxel
commented
Feb 20, 2020
Run Java PreCommit |
0edacbb to
012c45aComparereuvenlax
commented
Feb 24, 2020
A few comments. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
reuvenlax
left a comment
There was a problem hiding this comment.
One small comment, but otherwise LGTM for merge.
There was a problem hiding this comment.
I don't see this function being used anywhere. Remove?
There was a problem hiding this comment.
I used it in a production pipeline, but as it's not available in the other providers I removed it, (squashed and rebased).
Add DynamicMessage schema support. This is different from generated classes as it uses the proto descriptors. It uses the ProtoDomain as an index for searching embedded messages.
036b831 to
7a0fe93Compare
Add DynamicMessage schema support. This is different from
generated classes as it uses the proto descriptors. It uses
the ProtoDomain as an index for searching embedded messages.
R: @reuvenlax
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.