Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8932][Cleanup] Cleanup pubsubio by removing optionality and adding defaults to builders. - #10477
Merged
Merged
Conversation
This should have no user-facing effects.
ContributorAuthor
+R: @chamikaramj |
dpcollins-googleforce-pushed
the
cleanup-pubsubio
branch
from
December 29, 2019 16:22
5a2fddc to
b648c97Compareasf-ci
commented
Dec 29, 2019
SUCCESS --none-- |
asf-ci
commented
Dec 29, 2019
FAILURE --none-- |
dpcollins-googleforce-pushed
the
cleanup-pubsubio
branch
from
January 6, 2020 20:59
b648c97 to
5d7a076Compare3 tasks
dpcollins-googleforce-pushed
the
cleanup-pubsubio
branch
4 times, most recently
from
January 9, 2020 22:31
6161d8c to
5d8b5f5Compareaaltay
commented
Jan 17, 2020
Member
cc: @chamikaramj |
dpcollins-googleforce-pushed
the
cleanup-pubsubio
branch
5 times, most recently
from
February 10, 2020 21:00
77b40c7 to
bd5eeefCompareaaltay
commented
Feb 10, 2020
Member
retest this please |
dpcollins-googleforce-pushed
the
cleanup-pubsubio
branch
2 times, most recently
from
February 11, 2020 19:57
9a39288 to
2bea252Comparechamikaramj
commented
Mar 2, 2020
Contributor
LGTM. Thanks. |
chamikaramj
commented
Mar 2, 2020
Contributor
Retest this please |
chamikaramj
commented
Mar 2, 2020
Contributor
Run Dataflow ValidatesRunner |
chamikaramj
commented
Mar 2, 2020
Contributor
Run Beam PostCommit |
chamikaramj
commented
Mar 3, 2020
Contributor
Run Dataflow ValidatesRunner |
chamikaramj
commented
Mar 3, 2020
Contributor
Run Spotless PreCommit |
chamikaramj
commented
Mar 3, 2020
Contributor
Run RAT PreCommit |
chamikaramj
commented
Mar 3, 2020
Contributor
Run Java_Examples_Dataflow PreCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.