Skip to content

[BEAM-8932][Cleanup] Extract PubsubBoundedWriter from PubsubIO - #10478

Closed
dpcollins-google wants to merge 1 commit into
apache:masterfrom
dpcollins-google:extract-pubsubboundedwriter
Closed

[BEAM-8932][Cleanup] Extract PubsubBoundedWriter from PubsubIO#10478
dpcollins-google wants to merge 1 commit into
apache:masterfrom
dpcollins-google:extract-pubsubboundedwriter

Conversation

@dpcollins-google

@dpcollins-googledpcollins-google commented Dec 29, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status		Build StatusBuild StatusBuild Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status		---Build Status
Build Status		Build Status
Build Status		------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild Status
Build Status		Build StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

git
Move PubsubBoundedWriter outside of PubsubIO.
1ea1a3d
This should have no user-visible effects.
@dpcollins-google

dpcollins-google commented Dec 29, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

+R: @chamikaramj

@dpcollins-google
dpcollins-googleforce-pushed the extract-pubsubboundedwriter branch from a8e3967 to 9799b3fCompareDecember 29, 2019 16:22
@asf-ci

asf-ci commented Dec 29, 2019

Copy link
Copy Markdown

FAILURE

--none--

@asf-ci

asf-ci commented Dec 29, 2019

Copy link
Copy Markdown

SUCCESS

--none--

@dpcollins-google
dpcollins-googleforce-pushed the extract-pubsubboundedwriter branch from 9799b3f to 452a9caCompareJanuary 6, 2020 20:59
@dpcollins-googledpcollins-google mentioned this pull request Jan 7, 2020
Closed
3 tasks
@dpcollins-google
dpcollins-googleforce-pushed the extract-pubsubboundedwriter branch 4 times, most recently from d311d9c to 40a99deCompareJanuary 9, 2020 22:31
@aaltay

aaltay commented Jan 17, 2020

Copy link
Copy Markdown
Member

cc: @chamikaramj

@dpcollins-google
dpcollins-googleforce-pushed the extract-pubsubboundedwriter branch 7 times, most recently from 2dc295c to bae5fe7CompareFebruary 11, 2020 19:57
@dpcollins-googledpcollins-google changed the title Extract PubsubBoundedWriter from PubsubIO[BEAM-8932][Cleanup] Extract PubsubBoundedWriter from PubsubIOFeb 20, 2020
@dpcollins-google
dpcollins-googleforce-pushed the extract-pubsubboundedwriter branch from bae5fe7 to 5d177b3CompareMarch 5, 2020 21:01
@chamikaramj

chamikaramj commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Retest this please

@chamikaramj

chamikaramj commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Run Dataflow ValidatesRunner

@chamikaramj

chamikaramj commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Run Java PostCommit

@dpcollins-google
dpcollins-googleforce-pushed the extract-pubsubboundedwriter branch from 5d177b3 to 1ea1a3dCompareMarch 11, 2020 20:43
@aaltay
aaltay requested a review from chamikaramjMarch 11, 2020 21:27
@aaltay

aaltay commented Mar 27, 2020

Copy link
Copy Markdown
Member

Run Java PostCommit

@stale

staleBot commented May 30, 2020

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stalestaleBot added the stale label May 30, 2020
@aaltay

aaltay commented Jun 1, 2020

Copy link
Copy Markdown
Member

Run Java PreCommit

@stalestaleBot removed the stale label Jun 1, 2020
@aaltay

aaltay commented Jun 11, 2020

Copy link
Copy Markdown
Member

Test error seems to be a flake.

@aaltay

aaltay commented Jun 11, 2020

Copy link
Copy Markdown
Member

Run Java PreCommit

@stale

staleBot commented Aug 16, 2020

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stalestaleBot added the stale label Aug 16, 2020
@stale

staleBot commented Aug 23, 2020

Copy link
Copy Markdown

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stalestaleBot closed this Aug 23, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chamikaramjchamikaramjAwaiting requested review from chamikaramj

Assignees

No one assigned

Labels

gcpiojavastale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dpcollins-google@asf-ci@aaltay@chamikaramj