Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8932][Cleanup] Change default PubsubIO client from json to grpc. - #10479
[BEAM-8932][Cleanup] Change default PubsubIO client from json to grpc.#10479dpcollins-google wants to merge 2 commits into
Conversation
This should have no user-visible effects.
+R: @udim |
61777ba to
ce789b7Compareaaltay
commented
Jan 3, 2020
R: @chamikaramj could you find a person to review this PR? |
lukecwik
commented
Jan 3, 2020
Note there is another contributor working on updating grpc from 1.17 to 1.26 in #10438 which may impact this change. You might want to use the linkage checker to validate the upgrade. |
chamikaramj
commented
Jan 3, 2020
R: @udim Udi, can you take a look since you are more familiar regarding PubSub. |
ce789b7 to
4782148Compare4782148 to
04fba64Compareudim
commented
Jan 8, 2020
retest this please |
Looks like this is PR is no. 4 in a chain of PRs (none yet merged). I'll wait for those to be merged before reviewing, so that the diff is smaller. |
udim
commented
Jan 8, 2020
retest this please |
f1cdb8c to
83d7391Compare6819bde to
b5350ceCompareb5350ce to
29c62ecCompare29c62ec to
9519729CompareThis pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
aaltay
commented
May 11, 2020
I believe this PR is still active. |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Diffbased on #10478
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.