Skip to content

[BEAM-8696] sdks/java: upgrade protobuf to 3.11.1 - #10498

Merged
lukecwik merged 1 commit into
apache:masterfrom
suztomo:protobuf-3.11.1f
Jan 6, 2020
Merged

[BEAM-8696] sdks/java: upgrade protobuf to 3.11.1#10498
lukecwik merged 1 commit into
apache:masterfrom
suztomo:protobuf-3.11.1f

Conversation

@suztomo

@suztomosuztomo commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

sdks/java: upgrade protobuf to 3.11.1.

Linakge Check

beam-sdks-java-io-google-cloud-platform

beam-sdks-java-core

beam-sdks-java-extensions-protobuf

beam-sdks-java-extensions-sql-zetasql

Linkage Checker did not work for beam-sdks-java-extensions-sql-zetasql. Filed GoogleCloudPlatform/cloud-opensource-java#1087

beam-vendor-calcite-1_20_0

It did not find artifact "beam-vendor-calcite-1_20_0" https://gist.github.com/suztomo/1f01efd8665d82d9c740b36e65a44ce2


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status
Build Status
------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild Status
Build Status
Build StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@suztomo

Copy link
Copy Markdown
ContributorAuthor

Run Java PostCommit

@suztomo
suztomo marked this pull request as ready for review January 3, 2020 19:41
@suztomo

Copy link
Copy Markdown
ContributorAuthor

Run Java PostCommit

@lukecwik

Copy link
Copy Markdown
Member

You'll want to check the linkage of all beam modules that depend on Guava (and/or transitively depend on Guava). It won't be just the GCP IO module.

@suztomo

suztomo commented Jan 3, 2020

Copy link
Copy Markdown
ContributorAuthor

(I assume you meant protobuf, not guava) Yes, I'll check them tomorrow.

suztomo@suxtomo24:~/beam6$ find . -name 'build.gradle' |xargs grep -ir library.java.protobuf
./sdks/java/core/build.gradle: include(dependency(library.java.protobuf_java))
./sdks/java/core/build.gradle: compile library.java.protobuf_java
./sdks/java/io/google-cloud-platform/build.gradle: compile library.java.protobuf_java
./sdks/java/extensions/protobuf/build.gradle: compile library.java.protobuf_java
./sdks/java/extensions/sql/zetasql/build.gradle: compile library.java.protobuf_java
./sdks/java/extensions/sql/zetasql/build.gradle: compile library.java.protobuf_java_util
./vendor/calcite-1_20_0/build.gradle: library.java.protobuf_java,
suztomo@suxtomo24:~/beam6$ 

@lukecwik

Copy link
Copy Markdown
Member

(I assume you meant protobuf, not guava) Yes, I'll check them tomorrow.

suztomo@suxtomo24:~/beam6$ find . -name 'build.gradle' |xargs grep -ir library.java.protobuf
./sdks/java/core/build.gradle: include(dependency(library.java.protobuf_java))
./sdks/java/core/build.gradle: compile library.java.protobuf_java
./sdks/java/io/google-cloud-platform/build.gradle: compile library.java.protobuf_java
./sdks/java/extensions/protobuf/build.gradle: compile library.java.protobuf_java
./sdks/java/extensions/sql/zetasql/build.gradle: compile library.java.protobuf_java
./sdks/java/extensions/sql/zetasql/build.gradle: compile library.java.protobuf_java_util
./vendor/calcite-1_20_0/build.gradle: library.java.protobuf_java,
suztomo@suxtomo24:~/beam6$ 

Yes, protobuf, sorry for the confusion.

@suztomo

Copy link
Copy Markdown
ContributorAuthor

Run SQL PostCommit

@suztomo

Copy link
Copy Markdown
ContributorAuthor

R: @lukecwik

Added Linkage Check result in the description of this PR (No change)

@suztomo

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow ValidatesRunner

@suztomo

Copy link
Copy Markdown
ContributorAuthor

Jenkins does not trigger the checks.

@lukecwiklukecwik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only have to check vendored dependencies if they expose the dependency as a needed runtime dependency or an optional provided dependency.

@lukecwik
lukecwik merged commit c9c239f into apache:masterJan 6, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@suztomo@lukecwik