Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8696] sdks/java: upgrade protobuf to 3.11.1 - #10498
Conversation
suztomo
commented
Jan 3, 2020
Run Java PostCommit |
suztomo
commented
Jan 3, 2020
Run Java PostCommit |
lukecwik
commented
Jan 3, 2020
You'll want to check the linkage of all beam modules that depend on Guava (and/or transitively depend on Guava). It won't be just the GCP IO module. |
(I assume you meant protobuf, not guava) Yes, I'll check them tomorrow. |
lukecwik
commented
Jan 3, 2020
Yes, protobuf, sorry for the confusion. |
suztomo
commented
Jan 4, 2020
Run SQL PostCommit |
suztomo
commented
Jan 5, 2020
R: @lukecwik Added Linkage Check result in the description of this PR (No change) |
suztomo
commented
Jan 5, 2020
Run Dataflow ValidatesRunner |
suztomo
commented
Jan 5, 2020
Jenkins does not trigger the checks. |
lukecwik
left a comment
There was a problem hiding this comment.
You only have to check vendored dependencies if they expose the dependency as a needed runtime dependency or an optional provided dependency.
sdks/java: upgrade protobuf to 3.11.1.
Linakge Check
beam-sdks-java-io-google-cloud-platform
beam-sdks-java-core
beam-sdks-java-extensions-protobuf
beam-sdks-java-extensions-sql-zetasql
Linkage Checker did not work for beam-sdks-java-extensions-sql-zetasql. Filed GoogleCloudPlatform/cloud-opensource-java#1087
beam-vendor-calcite-1_20_0
It did not find artifact "beam-vendor-calcite-1_20_0" https://gist.github.com/suztomo/1f01efd8665d82d9c740b36e65a44ce2
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.