Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8676] sdks/java: gax and grpc upgrades - #10438
Conversation
| compile project(":sdks:java:extensions:protobuf") | ||
| compile library.java.avro | ||
| compile library.java.bigdataoss_util | ||
| compile library.java.gax |
There was a problem hiding this comment.
As BigQueryServicesImpl uses gax's com.google.api.gax.core.FixedCredentialsProvider (undeclared-but-used dependency), declaring it explicitly.
| def google_cloud_core_version = "1.61.0" | ||
| def google_cloud_spanner_version = "1.6.0" | ||
| def grpc_version = "1.17.1" | ||
| def grpc_version = "1.25.0" |
There was a problem hiding this comment.
The latest version of gRPC is 1.26.0, but setting 1.25.0 as gax-grpc:1.52.0 depends on 1.25.0.
suztomo
commented
Dec 21, 2019
R: @kennknowles |
suztomo
commented
Dec 23, 2019
suztomo
commented
Dec 27, 2019
Run SQL Postcommit |
suztomo
commented
Dec 27, 2019
retest this please |
suztomo
commented
Dec 27, 2019
Run Java PostCommit |
suztomo
commented
Dec 27, 2019
Run Java HadoopFormatIO Performance Test |
suztomo
commented
Dec 27, 2019
Run BigQueryIO Streaming Performance Test Java |
suztomo
commented
Dec 27, 2019
Run Dataflow ValidatesRunner |
suztomo
commented
Dec 27, 2019
Run Spark ValidatesRunner |
suztomo
commented
Dec 27, 2019
Run SQL Postcommit |
suztomo
commented
Jan 2, 2020
retest this please |
suztomo
commented
Jan 2, 2020
retest this please |
suztomo
commented
Jan 2, 2020
Run Java PostCommit |
suztomo
commented
Jan 3, 2020
Run Java PostCommit |
lukecwik
commented
Jan 3, 2020
Please post the before and after results of the linkage checker for the GCP IO module. Swapping to gRPC 1.25 suggests to update protobuf to 3.11.0 and guava to 28.1. Upgrading those may need to happen before this change could be adopted depending on the linkage checker results. This seems like an innocuous change but past experience has shown that grpc/proto/guava like to make breaking changes. |
suztomo
commented
Jan 3, 2020
Good point. The current protobuf 3.6.0 is not compatible with gax-grpc 1.52.0. Let me update that first. I'll attach linkage check result on that PR. |
suztomo
commented
Jan 3, 2020
Raised #10498 for protobuf upgrade. Jenkins is not running tests (yet?). |
https://gist.github.com/suztomo/9af333b78b157d6a829d59ac5353e01d This PR needs #10508 first. |
https://issues.apache.org/jira/browse/BEAM-8676
Gax and gRPC work together. Upgrading their dependencies to higher versions.
Which modules use gax and grpc?
find . -name 'build.gradle' |xargs grep -ir library.java.gaxgaveLinkage Check
beam-sdks-java-io-google-cloud-platform
beam-sdks-java-extensions-sql-zetasql
Linkage Checker does not work for beam-sdks-java-extensions-sql-zetasql. (Bug: GoogleCloudPlatform/cloud-opensource-java#1087)
beam-sdks-java-extensions-sql-datacatalog
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.