Skip to content

[BEAM-8685] sdks/java: google_auth_version 0.19.0 - #10508

Merged
lukecwik merged 1 commit into
apache:masterfrom
suztomo:google-auth-library-oauth2-http
Jan 10, 2020
Merged

[BEAM-8685] sdks/java: google_auth_version 0.19.0#10508
lukecwik merged 1 commit into
apache:masterfrom
suztomo:google-auth-library-oauth2-http

Conversation

@suztomo

@suztomosuztomo commented Jan 6, 2020

Copy link
Copy Markdown
Contributor

Upgrading the following two libraries to 0.19.0.

 google_auth_library_credentials : "com.google.auth:google-auth-library-credentials:$google_auth_version",
google_auth_library_oauth2_http : "com.google.auth:google-auth-library-oauth2-http:$google_auth_version",

This is preparation for BEAM-8676 (gax-grpc upgrade); com.google.api gax:1.52.0 requires com.google.auth:google-auth-library-oauth2-http:0.19.0 or higher.

Linkage Check

beam-sdks-java-extensions-google-cloud-platform-core

Diff:

suztomo@suxtomo24:~/beam6$ diff /tmp/linkagecheck-beam-sdks-java-extensions-google-cloud-platform-core-785609f2 /tmp/linkagecheck-beam-sdks-java-extensions-google-cloud-platform-core-ea012f73
184c184
< (guava-20.0.jar) com.google.common.collect.ImmutableList's method toImmutableList() is not found;
---
> (guava-28.1-android.jar) com.google.common.collect.ImmutableList's method toImmutableList() is not found;

The transitive dependency of Guava in beam-sdks-java-extensions-google-cloud-platform-core got higher version (from 20.0 to 28.1-android) but this missing method has been there even for the old version 20.0.

beam-runners-google-cloud-dataflow-java

beam-examples-kotlin

beam-examples-java

beam-sdks-java-extensions-sql-datacatalog

Linkage Checker fails to resolve dependencies (Bug: GoogleCloudPlatform/cloud-opensource-java#1087 ).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status
Build Status
------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild Status
Build Status
Build StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@suztomosuztomo changed the title [BEAM-8685] google_auth_version 0.19.0[BEAM-8685] sdks/java: google_auth_version 0.19.0Jan 6, 2020
@suztomo
suztomo marked this pull request as ready for review January 6, 2020 21:20
@suztomo

Copy link
Copy Markdown
ContributorAuthor

R: @lukecwik, @kennknowles

@suztomo

Copy link
Copy Markdown
ContributorAuthor

retest this please

@suztomo

Copy link
Copy Markdown
ContributorAuthor

Run Java PostCommit

@iemejia

Copy link
Copy Markdown
Member

retest this please

@iemejia

Copy link
Copy Markdown
Member

Run Java PostCommit

@iemejia

Copy link
Copy Markdown
Member

Run Java HadoopFormatIO Performance Test

@iemejia

Copy link
Copy Markdown
Member

Run BigQueryIO Streaming Performance Test Java

@iemejia

Copy link
Copy Markdown
Member

Run Dataflow ValidatesRunner

@iemejia

Copy link
Copy Markdown
Member

Run Spark ValidatesRunner

@iemejia

Copy link
Copy Markdown
Member

Run SQL Postcommit

@iemejia

Copy link
Copy Markdown
Member

Run CommunityMetrics PreCommit

@suztomo

Copy link
Copy Markdown
ContributorAuthor

Strange. Python build failed. https://builds.apache.org/job/beam_PreCommit_Python_Commit/10669/testReport/junit/(root)/(empty)/apache_beam_examples_streaming_wordcount_it_test/ says:

E File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/test-suites/tox/py2/build/srcs/sdks/python/target/.tox-py27-cython-pytest/py27-cython-pytest/local/lib/python2.7/site-packages/hamcrest/library/object/hasproperty.py", line 174
E ),
E ^
E SyntaxError: invalid syntax

@iemejia Thank you.

@suztomo

Copy link
Copy Markdown
ContributorAuthor

Run Python PreCommit

@suztomo

Copy link
Copy Markdown
ContributorAuthor

All green for Java; only Python precommit (which I believe was caused by their flakiness) checks failed.

@lukecwik Would you review and merge this?

@suztomo

Copy link
Copy Markdown
ContributorAuthor

R: @lukecwik

@lukecwik

Copy link
Copy Markdown
Member

Run Python PreCommit

@lukecwik

Copy link
Copy Markdown
Member

Run Python2_PVR_Flink PreCommit

@lukecwik

Copy link
Copy Markdown
Member

Waiting on tests before merging.

@lukecwik

Copy link
Copy Markdown
Member

Run Python PreCommit

@suztomo

Copy link
Copy Markdown
ContributorAuthor

21 successful checks

@lukecwik
lukecwik merged commit ac999d9 into apache:masterJan 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@suztomo@iemejia@lukecwik