Uh oh!
There was an error while loading. Please reload this page.
[BEAM-10138] Add Cross-language KinesisWrite external transform - #12234
Closed
pjotrekk wants to merge 7 commits into
Closed
[BEAM-10138] Add Cross-language KinesisWrite external transform#12234pjotrekk wants to merge 7 commits into
pjotrekk wants to merge 7 commits into
Conversation
4 tasks
pjotrekkforce-pushed
the
BEAM-10138-xlang-kinesis-write
branch
5 times, most recently
from
July 17, 2020 12:01
c241aa0 to
88f5244Compare
This was referenced Jul 17, 2020
TheNeuralBit
self-requested a review
July 21, 2020 00:21
pjotrekkforce-pushed
the
BEAM-10138-xlang-kinesis-write
branch
from
July 21, 2020 18:08
88f5244 to
c816230Compare
added 6 commits
July 23, 2020 09:47
pjotrekkforce-pushed
the
BEAM-10138-xlang-kinesis-write
branch
from
July 23, 2020 07:55
0647ed0 to
dd8fa24CompareTheNeuralBit
commented
Jul 30, 2020
Member
Closing in favor of #12297 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add KinesisIO.Write for Cross-language usage.
Chronology:
PR for python wrapper: #12235
PR for java external transform for read: #12297
PR for python wrapper integration tests: #12298
R: @TheNeuralBit - if you are no fed up with my changes yet then I'd be grateful for your review :)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.