Uh oh!
There was an error while loading. Please reload this page.
[BEAM-10138] Python wrapper for Cross-language Java's KinesisIO - #12235
[BEAM-10138] Python wrapper for Cross-language Java's KinesisIO#12235pjotrekk wants to merge 1 commit into
Conversation
991ce10 to
86ab3ccCompare5ee3d8b to
c7fe25fCompareTheNeuralBit
commented
Jul 22, 2020
Sorry for the delay @piotr-szuberski! I'll try to take a look at these today and/or tomorrow. One high-level question - do we have a jira about not running KinesisIO tests continuously? If not, please file one and make sure it mentions both direct Java tests as well as xlang tests. |
c7fe25f to
9842ff1Compare
No problem at all!
Yes, there is BEAM-601 - I've added a comment there and I'll mention it in the integration tests comment |
@TheNeuralBit I've just figured out that I could use kinesis SDK which is already included in AWS_REQUIREMENTS (boto3) - It will probably make it possible to separate the read and write test. |
af235cb to
4afc7dfCompare4afc7df to
66fb7ceCompareTheNeuralBit
commented
Jul 30, 2020
Closing in favor of #12297 |
Add a python wrapper for KinesisIO.Write.
Chronology:
PR for java external transform for write: #12234
PR for java external transform for read: #12297
PR for python integration tests: #12298
This test cannot be run on Jenkins because Beam does not have an AWS account. It has been tested locally on DirectRunner, FlinkRunner and SparkRunner.
R: @TheNeuralBit The same as with Java KinesisIO.Write external registrar - if you wanted to do this review I'd appreciate it :)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.