[BEAM-11372-11371-11369][Website revamp] Implemented community and contact us pages, navbar on mobiles by Jakub-Sadowski · Pull Request #13511 · apache/beam

Jakub-Sadowski · 2020-12-09T09:14:17Z

Implemented:

Welcome to community page
Contact us page
Navigation bar on mobiles

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang	Dataflow	Samza	Twister2
Go	---	---	---
Java
Python		---	---
XLang		---	---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---		---	---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

…vbar

Jakub-Sadowski · 2020-12-09T09:22:50Z

Review: @TheNeuralBit

pabloem · 2020-12-17T17:33:52Z

thank you @Jakub-Sadowski ! Can you share a few screenshots of these changes?

Jakub-Sadowski · 2020-12-18T10:15:29Z

thank you @Jakub-Sadowski ! Can you share a few screenshots of these changes?

TheNeuralBit · 2020-12-23T22:42:18Z

Retest this please

Jakub-Sadowski · 2020-12-28T10:19:04Z

Review: @kgabryje

TheNeuralBit

A few comments here.

Note this PR has the same issue as #13565, there are changes to the content files that will start to conflict with any changes made on master. If we start to diverge it will be very difficult to make sure we don't lose content changes made on master. It's even worse than the hugo upgrade - in that case we were able to at least diff the generated html since it should be identical. We won't have that option in this case since the style/layout is changing too.

Co-authored-by: Brian Hulette <hulettbh@gmail.com>

TheNeuralBit · 2021-01-13T02:05:42Z

-| [JIRA bug tracker](https://issues.apache.org/jira/browse/BEAM) | Report bugs / discover known issues |
-| [StackOverflow](https://stackoverflow.com/questions/tagged/apache-beam) | Ask and answer user support questions |
-| [Slack](https://s.apache.org/beam-slack-channel) | Chat with users and developers in the ASF Slack. Note: Please [join the #beam channel](https://s.apache.org/beam-slack-channel) after you [created an account](https://s.apache.org/slack-invite). Please do not ask Beam questions in #general. |
+Here should be a short description on what mailing lists are and how to use them. Also information on how does subscribe, unsubscribe and archives do work (blank email etc).


This looks like placeholder copy. Do you actually want to merge this now? When will it be updated?

We got some new copies and I just pushed this site with new one.

Thank you! @griscz could you review the copy changes in this PR to make sure they match your expectations? The changes should all be in the .md and .yaml files

…ub.com/PolideaInternal/beam into website/community-contact-pages-navbar

Co-authored-by: Brian Hulette <hulettbh@gmail.com>

…ub.com/PolideaInternal/beam into website/community-contact-pages-navbar

TheNeuralBit

Ok the HTML and CSS changes LGTM aside from a few more comments. Thanks for making all the fixes!

I don't feel great about the new content though, much of it seems a little unprofessional, or has grammatical errors.

@griscz has the copy already been reviewed?

TheNeuralBit · 2021-01-29T01:02:29Z

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- title: <a href="community/join-beam">Join Beam Community</a>


It would be preferable if there were a separate attribute for the link, and the template handled making it into an <a> tag

Okay, I changed it

TheNeuralBit · 2021-01-29T01:35:39Z

One more thing - the header is still rendering strangely for me when I view the staged website:

This is on my Linux desktop with the browser fullscreen. Is there anything I can do to help you debug this problem if you can't reproduce it?

Co-authored-by: Brian Hulette <hulettbh@gmail.com>

Jakub-Sadowski · 2021-01-30T21:12:16Z

One more thing - the header is still rendering strangely for me when I view the staged website:
This is on my Linux desktop with the browser fullscreen. Is there anything I can do to help you debug this problem if you can't reproduce it?

It's the problem I was talking about lastly, is hard to precisely cut parts of code which are needed, so during fixes to mobile navbar, navbar on desktop was changed also but some styles needed were absent, now I added them too and it looks fine

…vbar

TheNeuralBit · 2021-02-01T17:50:29Z

It's the problem I was talking about lastly, is hard to precisely cut parts of code which are needed, so during fixes to mobile navbar, navbar on desktop was changed also but some styles needed were absent, now I added them too and it looks fine

It looks like the issue with the Apache dropdown was resolved, but I still see the issue with the Documentation dropdown:

The same thing happens with private browsing so I don't think this is a cache issue.

TheNeuralBit · 2021-02-01T18:31:46Z

Run Java PreCommit

TheNeuralBit · 2021-02-01T18:31:54Z

Run Java_Examples_Dataflow PreCommit

TheNeuralBit · 2021-02-01T18:32:02Z

Run Java_Examples_Dataflow_Java11 PreCommit

TheNeuralBit · 2021-02-01T18:32:09Z

Run Spotless PreCommit

TheNeuralBit

I created #13867 where I duplicated this PR, but merged in website-revamp to clean up the noise. Based on a review over there this still looks good, except I still think we need to update the copy for the community and contact us pages.

…vbar

TheNeuralBit

Thanks @Jakub-Sadowski. If you want to go ahead and get this merged before we get the updated copy from @griscz, please add TODOs to indicate which copy still needs to be updated. That way we won't accidentally merge some temp/placeholder copy to master.

Jakub-Sadowski · 2021-02-01T21:00:05Z

Thanks @Jakub-Sadowski. If you want to go ahead and get this merged before we get the updated copy from @griscz, please add TODOs to indicate which copy still needs to be updated. That way we won't accidentally merge some temp/placeholder copy to master.

I will get the list with missing things in the morning and all TODOs

TheNeuralBit

Thanks for adding the updated copy! It looks like there are a couple of files with copy that didn't get updated though, are you still waiting on copy for these?

Co-authored-by: Brian Hulette <hulettbh@gmail.com>

TheNeuralBit

LGTM, thank you @Jakub-Sadowski

init
f660fa8

probot-autolabelerBot added the website label Dec 9, 2020

Merge branch 'website-revamp' into website/community-contact-pages-na…
80a8c6d
…vbar

TheNeuralBit self-requested a review December 9, 2020 19:12

kgabryje reviewed Dec 28, 2020
View reviewed changes

Comment threadwebsite/www/site/assets/scss/_navbar-desktop.scss Outdated

Jakub-Sadowski added 2 commits December 28, 2020 16:04

minor fixes
14e0a70

fix mobile navbar
8c8c46e

TheNeuralBit reviewed Dec 30, 2020
View reviewed changes

Comment threadwebsite/www/site/layouts/shortcodes/list_with_icons.html Outdated
Comment threadwebsite/www/site/data/en/community_list.yaml Outdated
Comment threadwebsite/www/site/layouts/community/baseof.html
Comment threadwebsite/www/site/content/en/community/contact-us.md Outdated

Jakub-Sadowskiand others added 4 commits January 4, 2021 15:51

delete br's
af9547f

delete br
117815f

change header size
a1f5427

Update website/www/site/data/en/community_list.yaml
e9fc21b
Co-authored-by: Brian Hulette <hulettbh@gmail.com>

TheNeuralBit reviewed Jan 13, 2021
View reviewed changes

Jakub-Sadowski added 2 commits January 17, 2021 16:45

add content, change shortcode
272cc9d

Merge branch 'website/community-contact-pages-navbar' ofhttps://gith…
37beb79
…ub.com/PolideaInternal/beam into website/community-contact-pages-navbar

TheNeuralBit reviewed Jan 21, 2021
View reviewed changes

Comment threadwebsite/www/site/content/en/community/contact-us.md Outdated

Jakub-Sadowskiand others added 5 commits January 22, 2021 10:13

Update website/www/site/content/en/community/contact-us.md
b3cdce1
Co-authored-by: Brian Hulette <hulettbh@gmail.com>

fixes/changes without content update
178d1a5

Merge branch 'website/community-contact-pages-navbar' ofhttps://gith…
b66f7b0
…ub.com/PolideaInternal/beam into website/community-contact-pages-navbar

merge
241cef1

whitespaces
a5b75d9

TheNeuralBit reviewed Jan 29, 2021
View reviewed changes

Update website/www/site/static/js/section-nav.js
d8182d2
Co-authored-by: Brian Hulette <hulettbh@gmail.com>

fixes
849464d

Jakub-Sadowski added 5 commits January 30, 2021 22:23

add attribute for link
0e45184

whitespace
3eae5fe

content update
cde7e34

examples update
ca4c6a3

Merge branch 'website-revamp' into website/community-contact-pages-na…
12a73e2
…vbar

TheNeuralBit mentioned this pull request Feb 1, 2021
[DO NOT MERGE][WIP] Duplicate of https://github.com/apache/beam/pull/13511 #13867
Closed

TheNeuralBit reviewed Feb 1, 2021
View reviewed changes

Jakub-Sadowski added 2 commits February 1, 2021 21:10

fix:
c9ad6c6

Merge branch 'website-revamp' into website/community-contact-pages-na…
5207c7e
…vbar

TheNeuralBit requested changes Feb 1, 2021
View reviewed changes

add contact us copy
d971e7f

TheNeuralBit reviewed Feb 2, 2021
View reviewed changes

Comment threadwebsite/www/site/data/en/community_list.yaml
Comment threadwebsite/www/site/content/en/community/contact-us.md Outdated
Comment threadwebsite/www/site/content/en/community/_index.md

Jakub-Sadowskiand others added 2 commits February 2, 2021 16:51

Update website/www/site/content/en/community/contact-us.md
c814710
Co-authored-by: Brian Hulette <hulettbh@gmail.com>

update copy
c982ba3

TheNeuralBit approved these changes Feb 3, 2021
View reviewed changes

TheNeuralBit merged commit 549f78f into apache:website-revampFeb 3, 2021

Uh oh!

Conversation

Jakub-Sadowski commented Dec 9, 2020

Post-Commit Tests Status (on master branch)

Pre-Commit Tests Status (on master branch)

GitHub Actions Tests Status (on master branch)

Uh oh!

Jakub-Sadowski commented Dec 9, 2020

Uh oh!

pabloem commented Dec 17, 2020

Uh oh!

Jakub-Sadowski commented Dec 18, 2020

Uh oh!

TheNeuralBit commented Dec 23, 2020

Uh oh!

Jakub-Sadowski commented Dec 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheNeuralBitJan 13, 2021

Choose a reason for hiding this comment

Uh oh!

Jakub-SadowskiJan 17, 2021

Choose a reason for hiding this comment

Uh oh!

TheNeuralBitJan 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheNeuralBitJan 29, 2021

Choose a reason for hiding this comment

Uh oh!

Jakub-SadowskiJan 30, 2021

Choose a reason for hiding this comment

Uh oh!

TheNeuralBit commented Jan 29, 2021

Uh oh!

Jakub-Sadowski commented Jan 30, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheNeuralBit commented Feb 1, 2021

Uh oh!

TheNeuralBit commented Feb 1, 2021

Uh oh!

TheNeuralBit commented Feb 1, 2021

Uh oh!

TheNeuralBit commented Feb 1, 2021

Uh oh!

TheNeuralBit commented Feb 1, 2021

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Jakub-Sadowski commented Feb 1, 2021

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Jakub-Sadowski commented Jan 30, 2021•
edited
Loading