Skip to content

[BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations - #13718

Merged
TheNeuralBit merged 22 commits into
apache:website-revampfrom
PolideaInternal:website/searchbar-navs
Feb 3, 2021
Merged

[BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations#13718
TheNeuralBit merged 22 commits into
apache:website-revampfrom
PolideaInternal:website/searchbar-navs

Conversation

@Jakub-Sadowski

@Jakub-SadowskiJakub-Sadowski commented Jan 11, 2021

Copy link
Copy Markdown
Contributor

Implemented:

  • searchbar on top navigation
  • left navigation
  • right navigation
  • join beam community page
  • added hotjar
  • fix hero component sizing on mobiles

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status		Build Status
Build Status
Build Status
Build Status		Build StatusBuild Status
Build Status
Build Status		Build Status
PythonBuild Status
Build Status
Build Status		Build Status
Build Status
Build Status		Build Status
Build Status		---Build Status---
XLangBuild StatusBuild StatusBuild Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild StatusBuild Status
Build Status
Build Status
Build Status		Build StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@Jakub-Sadowski

Jakub-Sadowski commented Jan 11, 2021

Copy link
Copy Markdown
ContributorAuthor

Review: @TheNeuralBit

@TheNeuralBit

TheNeuralBit commented Jan 11, 2021

Copy link
Copy Markdown
Member

It looks like you've removed the .gitignore and checked in all the files in the code_samples directory. Can you remove those?

@Jakub-Sadowski

Jakub-Sadowski commented Jan 11, 2021

Copy link
Copy Markdown
ContributorAuthor

It looks like you've removed the .gitignore and checked in all the files in the code_samples directory. Can you remove those?

ohh yea I will fix this, sorry

@TheNeuralBit
TheNeuralBit self-requested a review February 2, 2021 01:55
TheNeuralBit
TheNeuralBit requested changes Feb 2, 2021
View reviewed changes

@TheNeuralBitTheNeuralBit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, aside from the content. I don't think "Stalk Us" is the final copy. Please update with final copy from @griscz or add a TODO.

Comment threadwebsite/.gitignore Outdated
@TheNeuralBitTheNeuralBit mentioned this pull request Feb 2, 2021
Merged
4 tasks
TheNeuralBit
TheNeuralBit requested changes Feb 2, 2021
View reviewed changes

@TheNeuralBitTheNeuralBit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Jakub-Sadowski. I have a few comments on the new copy, mostly it looks like there's supposed to be links in several places.

Comment threadwebsite/www/site/content/en/community/join-beam.md Outdated
Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
- list:
- Check out the ways you can become a commiter
- Here is a document that you should read
- { title: Learn about the Project Management Committee (PMC), description: The Project Management Committee (PMC) is the highest recognition in Apache projects. If you’re interested in becoming part of it, learn more about it here. }

@TheNeuralBitTheNeuralBitFeb 2, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"read how to become a committer" and "learn more about it here" in the PMC section should have links to those documents.

Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
Comment threadwebsite/www/site/content/en/community/join-beam.md Outdated
Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
TheNeuralBit
TheNeuralBit reviewed Feb 3, 2021
View reviewed changes

@TheNeuralBitTheNeuralBit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM right now, but there are some merge conflicts now that #11351 is merged. Can you resolve those? Then I'll take another quick look

Comment threadwebsite/www/site/content/en/community/join-beam.md Outdated
@Jakub-Sadowski@TheNeuralBit
Update website/www/site/content/en/community/join-beam.md
142cd88
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
TheNeuralBit
TheNeuralBit approved these changes Feb 3, 2021
View reviewed changes

@TheNeuralBitTheNeuralBit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few tweaks to the links, I'll push them myself.

Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
Jakub-Sadowskiand others added 4 commits February 3, 2021 17:59
@Jakub-Sadowski@TheNeuralBit
Update website/www/site/data/en/join_beam.yaml
6673705
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
@Jakub-Sadowski@TheNeuralBit
Update website/www/site/data/en/join_beam.yaml
c285b61
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
@Jakub-Sadowski@TheNeuralBit
Update website/www/site/data/en/join_beam.yaml
400eb99
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
@Jakub-Sadowski@TheNeuralBit
Update website/www/site/data/en/join_beam.yaml
57e2f64
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
@TheNeuralBit

TheNeuralBit commented Feb 3, 2021

Copy link
Copy Markdown
Member

Run Website_Stage_GCS PreCommit

TheNeuralBit
TheNeuralBit approved these changes Feb 3, 2021
View reviewed changes

@TheNeuralBitTheNeuralBit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I had a typo, in my changes. One more patch

Comment threadwebsite/www/site/data/en/join_beam.yaml Outdated
@Jakub-Sadowski@TheNeuralBit
Update website/www/site/data/en/join_beam.yaml
6ff16a7
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
@TheNeuralBit
TheNeuralBit merged commit ec621f9 into apache:website-revampFeb 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheNeuralBitTheNeuralBitTheNeuralBit approved these changes

Assignees

No one assigned

Labels

buildextensionsgojavasqlwebsite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jakub-Sadowski@TheNeuralBit