Skip to content

[BEAM-13799] Create an Interactive Beam Dataproc package for users to manage clusters with - #16691

Merged
nika-qubit merged 1 commit into
apache:masterfrom
victorplusc:support_dataproc_clusters
Feb 5, 2022
Merged

[BEAM-13799] Create an Interactive Beam Dataproc package for users to manage clusters with#16691
nika-qubit merged 1 commit into
apache:masterfrom
victorplusc:support_dataproc_clusters

Conversation

@victorplusc

@victorpluscvictorplusc commented Feb 1, 2022

Copy link
Copy Markdown
Contributor
  • Adds a package to support the creation of Dataproc clusters that have been configured with a Flink session
  • By default, a created Dataproc cluster will be called 'interactive-beam-cluster'
  • Users additionally will have the ability to:
    • specify a name of their choosing for the created cluster, a warning is raised to notify the user that they will have to delete the cluster on their own
    • delete the cluster with the default name, 'interactive-beam-cluster'
  • ASF Jira thread: [BEAM-13799]

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

LangULRDataflowFlinkSamzaSparkTwister2
Go---Build StatusBuild StatusBuild StatusBuild Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python---Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status---
XLangBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status---

Examples testing status on various runners

LangULRDataflowFlinkSamzaSparkTwister2
Go---------------------
Java---Build Status
Build Status
Build Status
---------------
Python---------------------
XLang---------------------

Post-Commit SDK/Transform Integration Tests Status (on master branch)

GoJavaPython
Build StatusBuild StatusBuild Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build StatusBuild Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@victorplusc

Copy link
Copy Markdown
ContributorAuthor

R: @kevingg
R: @rohdesamuel

@victorplusc
victorplusc marked this pull request as ready for review February 3, 2022 19:24
@codecov

codecovBot commented Feb 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #16691 (cc6cdfc) into master (f54f527) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head cc6cdfc differs from pull request most recent head 1c95bd9. Consider uploading reports for the commit 1c95bd9 to get more accurate results

Impacted file tree graph

@@ Coverage Diff @@## master #16691 +/- ##
========================================
Coverage 83.65% 83.65% ========================================
Files 452 452 Lines 62424 62161 -263 ========================================
- Hits 52222 52002 -220 + Misses 10202 10159 -43 
Impacted FilesCoverage Δ
...apache_beam/runners/dataflow/internal/apiclient.py77.39% <0.00%> (-4.91%)⬇️
...n/apache_beam/ml/gcp/recommendations_ai_test_it.py73.46% <0.00%> (-2.05%)⬇️
sdks/python/apache_beam/io/source_test_utils.py88.01% <0.00%> (-0.47%)⬇️
sdks/python/apache_beam/examples/wordcount.py93.10% <0.00%> (ø)
...s/python/apache_beam/examples/wordcount_minimal.py92.85% <0.00%> (ø)
...python/apache_beam/examples/wordcount_debugging.py95.91% <0.00%> (ø)
...hon/apache_beam/examples/wordcount_with_metrics.py25.80% <0.00%> (ø)
...he_beam/examples/cookbook/multiple_output_pardo.py95.83% <0.00%> (ø)
...eam/runners/portability/fn_api_runner/fn_runner.py90.90% <0.00%> (ø)
sdks/python/apache_beam/dataframe/frames.py94.97% <0.00%> (+0.03%)⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54f527...1c95bd9. Read the comment docs.

@nika-qubitnika-qubit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few nits.

@victorplusc
victorpluscforce-pushed the support_dataproc_clusters branch from d6ddf36 to 30adeddCompareFebruary 4, 2022 21:59

@nika-qubitnika-qubit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorplusc
victorpluscforce-pushed the support_dataproc_clusters branch from 41e505a to fc6bb5fCompareFebruary 5, 2022 00:51
@victorplusc
victorpluscforce-pushed the support_dataproc_clusters branch from fc6bb5f to 1c95bd9CompareFebruary 5, 2022 01:19
@nika-qubit
nika-qubit merged commit a32a1ea into apache:masterFeb 5, 2022
@victorplusc
victorplusc deleted the support_dataproc_clusters branch February 8, 2022 01:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@victorplusc@nika-qubit@rohdesamuel