Skip to content

[BEAM-13812] Integrate DataprocClusterManager into Interactive Environment - #16741

Merged
nika-qubit merged 2 commits into
apache:masterfrom
victorplusc:integrate_dataproc_package
Feb 18, 2022
Merged

[BEAM-13812] Integrate DataprocClusterManager into Interactive Environment#16741
nika-qubit merged 2 commits into
apache:masterfrom
victorplusc:integrate_dataproc_package

Conversation

@victorplusc

@victorpluscvictorplusc commented Feb 4, 2022

Copy link
Copy Markdown
Contributor
  • Integrates the DataprocClusterManager previously introduced in:
  • Adds code to automatically create a Dataproc cluster configured with Docker and Flink if a user instantiates an InteractiveRunner using underlying_runner='FlinkRunner'
  • By default, the created Dataproc cluster will be called 'interactive-beam-cluster' and will be cleaned up when the Interactive Environment is interrupted
  • Introduces the Clusters class in interactive_beam.py, which acts as a user interface that provides the user with the following capabilities:
    • Changing the default name of the clusters created by Interactive Beam
    • Cleaning up a cluster by providing a corresponding pipeline, an option to force the deletion is provided, in the case where more than one pipeline use the same cluster
    • Getting all pipelines that use the provided master_url
    • Receiving a description back for either the cluster corresponding to a specific pipeline, or the descriptions of all pipelines
  • ASF Jira thread: [Beam-13812]

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

LangULRDataflowFlinkSamzaSparkTwister2
Go---Build StatusBuild StatusBuild StatusBuild Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python---Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status---
XLangBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status---

Examples testing status on various runners

LangULRDataflowFlinkSamzaSparkTwister2
Go---------------------
Java---Build Status
Build Status
Build Status
---------------
Python---------------------
XLang---------------------

Post-Commit SDK/Transform Integration Tests Status (on master branch)

GoJavaPython
Build StatusBuild StatusBuild Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build StatusBuild Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@victorplusc

Copy link
Copy Markdown
ContributorAuthor

R: @kevingg
R: @rohdesamuel

@codecov

codecovBot commented Feb 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #16741 (9d9554d) into master (f87f146) will increase coverage by 8.98%.
The diff coverage is 93.12%.

Impacted file tree graph

@@ Coverage Diff @@## master #16741 +/- ##
==========================================
+ Coverage 74.65% 83.63% +8.98% 
==========================================
Files 656 453 -203 Lines 82424 62470 -19954 ==========================================
- Hits 61532 52249 -9283 + Misses 19892 10221 -9671 + Partials 1000 0 -1000 
Impacted FilesCoverage Δ
...s/interactive/dataproc/dataproc_cluster_manager.py81.42% <78.04%> (ø)
...che_beam/runners/interactive/interactive_runner.py92.48% <92.00%> (-0.12%)⬇️
...pache_beam/runners/interactive/interactive_beam.py81.25% <100.00%> (+3.89%)⬆️
...eam/runners/interactive/interactive_environment.py90.74% <100.00%> (+0.34%)⬆️
...ks/python/apache_beam/runners/interactive/utils.py95.23% <100.00%> (+0.37%)⬆️
setup.py0.00% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/coderx/int.go
sdks/go/pkg/beam/pcollection.go
sdks/go/pkg/beam/coder.go
sdks/go/pkg/beam/core/runtime/xlangx/namespace.go
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87f146...9d9554d. Read the comment docs.

@victorplusc
victorplusc marked this pull request as ready for review February 9, 2022 00:44
Comment threadsdks/python/apache_beam/runners/interactive/interactive_beam.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_environment.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_runner.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_runner.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_runner.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_environment.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_environment.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_beam.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_beam.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_runner.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_runner.py Outdated
@victorplusc
victorpluscforce-pushed the integrate_dataproc_package branch from 1eb3a88 to 1fca0d9CompareFebruary 17, 2022 00:27
Comment threadsdks/python/apache_beam/runners/interactive/interactive_runner.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_runner.py Outdated
Comment threadsdks/python/apache_beam/runners/interactive/interactive_runner.py Outdated
@victorplusc
victorpluscforce-pushed the integrate_dataproc_package branch 3 times, most recently from 863ab52 to feaac86CompareFebruary 17, 2022 18:56

@nika-qubitnika-qubit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadsdks/python/apache_beam/runners/interactive/interactive_runner.py Outdated
@victorplusc
victorpluscforce-pushed the integrate_dataproc_package branch 2 times, most recently from 7e2077a to 3ac8a4cCompareFebruary 17, 2022 19:11
@nika-qubit

Copy link
Copy Markdown
Contributor

retest this please

@victorplusc
victorpluscforce-pushed the integrate_dataproc_package branch 3 times, most recently from c385703 to 5dbb9daCompareFebruary 17, 2022 22:56
@victorplusc
victorpluscforce-pushed the integrate_dataproc_package branch from e99ebcb to 8da4e2cCompareFebruary 17, 2022 23:14
@victorplusc

Copy link
Copy Markdown
ContributorAuthor

retest this please

@victorplusc
victorpluscforce-pushed the integrate_dataproc_package branch from 7888ae8 to f0ca9dbCompareFebruary 18, 2022 08:32
@victorplusc
victorpluscforce-pushed the integrate_dataproc_package branch from 1ae2f5c to 3cbc708CompareFebruary 18, 2022 18:24
@victorplusc

Copy link
Copy Markdown
ContributorAuthor

Run Python PreCommit

@nika-qubit
nika-qubit merged commit 0e45de7 into apache:masterFeb 18, 2022
@aaltay

Copy link
Copy Markdown
Member

colab users are reporting error logs showing "No cluster_manager is associated with the provided pipeline!". Could you please file a bug / fix the problem?

@victorplusc

Copy link
Copy Markdown
ContributorAuthor

Hi @aaltay,

Thanks for letting me know. I am working on a fix in this PR: #16936. Here is the link to the Beam ASF thread: BEAM-13996.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@victorplusc@nika-qubit@aaltay@rohdesamuel