Replace more uses of `ClassLoadingStrategy.Default.INJECTION` by cushon · Pull Request #23210 · apache/beam

cushon · 2022-09-13T15:55:51Z

in preparation for Java 17+.

See "Supporting proxies on Java versions prior to 9 and past 10" in http://mydailyjava.blogspot.com/2018/04/jdk-11-and-proxies-in-world-past.html

Follow-up to: 98f1f75.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

cushon · 2022-09-13T15:56:02Z

R: @kileys

github-actions · 2022-09-13T16:52:49Z

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions · 2022-11-14T12:51:52Z

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

github-actions · 2022-12-03T12:44:47Z

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

kileys · 2023-01-30T18:46:06Z

@lukecwik

lukecwik

.

in preparation for Java 17+. Follow-up to: apache@98f1f75.

Co-authored-by: Lukasz Cwik <lcwik@google.com>

…yUtils.java Co-authored-by: Lukasz Cwik <lcwik@google.com>

lukecwik · 2023-02-16T22:58:56Z

Run Java_Kafka_IO_Direct PreCommit

lukecwik · 2023-02-16T22:59:02Z

Run Java PreCommit

lukecwik · 2023-02-16T22:59:09Z

Run Java_Cdap_IO_Direct PreCommit

lukecwik · 2023-02-16T22:59:17Z

Run Java_Hadoop_IO_Direct PreCommit

lukecwik · 2023-02-17T01:04:29Z

Run Java PreCommit

lukecwik · 2023-02-17T01:04:34Z

Run Java_Kafka_IO_Direct PreCommit

lukecwik · 2023-02-17T16:43:33Z

Run Java_Kafka_IO_Direct PreCommit

…apache#23210)" This reverts commit 2b62912.

…#23210)" (#25566) This reverts commit 2b62912.

…apache#23210)" (apache#25566) This reverts commit 2b62912.

…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.

* revert a change to the classloader used in RowCoderGenerator (apache#23210 (comment)) * don't use the lookup strategy for built-in JDK classes

github-actionsBot added the java label Sep 13, 2022

cushon force-pushed the ClassLoadingStrategy branch from 5b638cb to f49fc3aCompare September 14, 2022 17:12

github-actionsBot added the stale label Nov 14, 2022

github-actionsBot closed this Dec 3, 2022

kileys reopened this Jan 11, 2023

kileys reviewed Jan 11, 2023
View reviewed changes

Comment threadsdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoderGenerator.java Outdated

github-actionsBot removed the stale label Jan 12, 2023

cushon force-pushed the ClassLoadingStrategy branch from f49fc3a to 3340d37Compare February 6, 2023 20:06

lukecwik requested changes Feb 10, 2023
View reviewed changes

cushon requested a review from lukecwik February 10, 2023 02:44

lukecwik reviewed Feb 10, 2023
View reviewed changes

Comment threadsdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteBuddyUtils.java Outdated

cushon requested a review from lukecwik February 10, 2023 19:56

cushon force-pushed the ClassLoadingStrategy branch from f4626ee to c953fe5Compare February 13, 2023 22:39

lukecwik approved these changes Feb 13, 2023
View reviewed changes

cushonand others added 11 commits February 14, 2023 09:22

Replace more uses of ClassLoadingStrategy.Default.INJECTION
6164fc8
in preparation for Java 17+. Follow-up to: apache@98f1f75.

Move helper method to a shared ByteBuddyUtils class
40bc893

spotlessApply
37bc0fc

Apply suggestions from code review
95c749c
Co-authored-by: Lukasz Cwik <lcwik@google.com>

Fix nullness issues, add an overload that takes a custom classloader
267440f

spotless apply
f5ae913

Fix imports
e376095

Update sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteBudd…
4453290
…yUtils.java Co-authored-by: Lukasz Cwik <lcwik@google.com>

Use ISE instead of LinkageError
9943d72

Add a missing import
e666a98

s/getClassLoader/findClassLoader
fbd11b6

lukecwik approved these changes Feb 14, 2023
View reviewed changes

lukecwik merged commit 2b62912 into apache:masterFeb 17, 2023

Abacn added a commit to Abacn/beam that referenced this pull request Feb 20, 2023
Revert "Replace more uses ofClassLoadingStrategy.Default.INJECTION(…
ed4ddc1
…apache#23210)" This reverts commit 2b62912.

Abacn mentioned this pull request Feb 20, 2023
[Avro] Use "extensions/avro" instead of avro from"core" in Java SDK modules #24992
Merged
3 tasks

cushon mentioned this pull request Feb 21, 2023
Revert "Replace more uses of ClassLoadingStrategy.Default.INJECTION (#23210)" #25566
Merged
3 tasks

Abacn added a commit that referenced this pull request Feb 21, 2023
Revert "Replace more uses ofClassLoadingStrategy.Default.INJECTION(…
b92600a
…#23210)" (#25566) This reverts commit 2b62912.

ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
Revert "Replace more uses ofClassLoadingStrategy.Default.INJECTION(…
549f2db
…apache#23210)" (apache#25566) This reverts commit 2b62912.

cushon added a commit to cushon/beam that referenced this pull request Apr 20, 2023
Revert "Revert "Replace more uses of `ClassLoadingStrategy.Default.IN…
41ee4c6
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.

cushon added a commit to cushon/beam that referenced this pull request Apr 20, 2023
Fixes
78efaf8
* revert a change to the classloader used in RowCoderGenerator (apache#23210 (comment)) * don't use the lookup strategy for built-in JDK classes

Abacn mentioned this pull request Feb 26, 2024
Remove some uses of ClassLoadingStrategy.Default.INJECTION #30367
Merged
3 tasks

Uh oh!

Conversation

cushon commented Sep 13, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Actions Tests Status (on master branch)

Uh oh!

cushon commented Sep 13, 2022

Uh oh!

github-actionsBot commented Sep 13, 2022

Uh oh!

github-actionsBot commented Nov 14, 2022

Uh oh!

github-actionsBot commented Dec 3, 2022

Uh oh!

Uh oh!

kileys commented Jan 30, 2023

Uh oh!

lukecwik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukecwik commented Feb 16, 2023

Uh oh!

lukecwik commented Feb 16, 2023

Uh oh!

lukecwik commented Feb 16, 2023

Uh oh!

lukecwik commented Feb 16, 2023

Uh oh!

lukecwik commented Feb 17, 2023

Uh oh!

lukecwik commented Feb 17, 2023

Uh oh!

lukecwik commented Feb 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cushon commented Sep 13, 2022•
edited
Loading