Uh oh!
There was an error while loading. Please reload this page.
Revert "Replace more uses of ClassLoadingStrategy.Default.INJECTION (#23210)" - #25566
Merged
Conversation
…apache#23210)" This reverts commit 2b62912.
Abacn
commented
Feb 20, 2023
ContributorAuthor
Run SQL_Java17 PreCommit |
Abacn
commented
Feb 20, 2023
ContributorAuthor
Run SQL_Java11 PreCommit |
3 tasks
Abacn
commented
Feb 21, 2023
ContributorAuthor
Abacn
marked this pull request as ready for review
February 21, 2023 15:23
ClassLoadingStrategy.Default.INJECTION (#23210)"ClassLoadingStrategy.Default.INJECTION (#23210)"Abacn
commented
Feb 21, 2023
ContributorAuthor
Contributor
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
ContributorAuthor
Kafka_IO_Direct PreCommit known flake related to #25261; other tests not updated to GitHub UI are avtually succeeded. |
lukecwik
commented
Feb 21, 2023
Member
LGTM |
lukecwik
approved these changes
Feb 21, 2023
pabloem
commented
Feb 21, 2023
Member
thanks @Abacn - indeed this looks like it's causing trouble : ) |
pabloem
commented
Feb 21, 2023
Member
Run Java_Kafka_IO_Direct PreCommit |
4 tasks
cushon
commented
Feb 21, 2023
Contributor
I can reproduce with I think most of the failures are related to this change from the original PR: #23210 (comment) |
Abacn
commented
Feb 21, 2023
ContributorAuthor
Kafka_IO_Direct passed, merging for now |
ruslan-ikhsan pushed a commit
to akvelon/beam
that referenced
this pull request
Mar 10, 2023
…apache#23210)" (apache#25566) This reverts commit 2b62912.
cushon added a commit
to cushon/beam
that referenced
this pull request
Apr 20, 2023
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigate Java11/17 postcommit test failures
This reverts commit 2b62912.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.