Skip to content

Fix flaky precommit java test on prism caused by PR 35202 - #35336

Merged
shunping merged 3 commits into
apache:masterfrom
shunping:fix-35202
Jun 17, 2025
Merged

Fix flaky precommit java test on prism caused by PR 35202#35336
shunping merged 3 commits into
apache:masterfrom
shunping:fix-35202

Conversation

@shunping

@shunpingshunping commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator

Get back #35202 (reverted at #35306) and fix the type assertion issue that causes PreCommit Java test failure.

fixes#35233

The original error can be reproduced by the simple code below:

package main
import"fmt"funcmain() {
varmmap[string]interface{}
v:=m["foo"].([]interface{})
fmt.Println(v)
}

By adding the ok returned value for type assertion, the error is not raised and ok is False in this case.

package main
import"fmt"funcmain() {
varmmap[string]interface{}
v, ok:=m["foo"].([]interface{})
fmt.Println(v, ok)
}

@shunpingshunping self-assigned this Jun 17, 2025
@shunping

shunping commented Jun 17, 2025

Copy link
Copy Markdown
CollaboratorAuthor

cc'ed @Abacn@Amar3tto

@shunping

Copy link
Copy Markdown
CollaboratorAuthor

The PreCommit Java test is green (https://github.com/apache/beam/actions/runs/15715290813).

@shunping
shunping marked this pull request as ready for review June 17, 2025 19:01
@shunpingshunping changed the title Fix 35202Fix flaky precommit java test on prism caused by PR 35202Jun 17, 2025

@lostlucklostluck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shunping
shunping merged commit bc022ba into apache:masterJun 17, 2025
shunping added a commit to shunping/beam that referenced this pull request Jun 17, 2025
* Revert "Reverts apache#35202 (apache#35306)"
This reverts commit 71073a0.
* Check if type assertion is ok before using it in range.
* Trigger PreCommit Java test.
shunping added a commit that referenced this pull request Jun 17, 2025
* Reverts #35202 (#35306)
* Fix flaky precommit java test on prism caused by PR 35202 (#35336)
* Revert "Reverts #35202 (#35306)"
This reverts commit 71073a0.
* Check if type assertion is ok before using it in range.
* Trigger PreCommit Java test.
---------
Co-authored-by: akashorabek <70029317+akashorabek@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Flaky Prism Runner unit tests in Java PreCommit

2 participants

@shunping@lostluck