Uh oh!
There was an error while loading. Please reload this page.
Cherry pick PR 35306 and 35336 - #35339
Merged
shunping merged 2 commits intoJun 17, 2025
Merged
Conversation
* Revert "Reverts apache#35202 (apache#35306)" This reverts commit 71073a0. * Check if type assertion is ok before using it in range. * Trigger PreCommit Java test.
Amar3tto
approved these changes
Jun 17, 2025
shunping
commented
Jun 17, 2025
CollaboratorAuthor
Thanks! I will merge once all tests are green. |
shunping
marked this pull request as ready for review
June 17, 2025 21:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #35202 (supporting real-time clock for processing time in prism) has caused Precommit Java unit tests to fail on prism. The root cause is related to applying type assertion on a possibly
nilvalue.This PR was reverted in #35306 and was brought back in #35336 with a fix.