Skip to content

[BEAM-4046] Remove old project name mappings. - #8915

Merged
lukecwik merged 1 commit into
apache:masterfrom
lukecwik:beam4046
Oct 14, 2019
Merged

[BEAM-4046] Remove old project name mappings.#8915
lukecwik merged 1 commit into
apache:masterfrom
lukecwik:beam4046

Conversation

@lukecwik

Copy link
Copy Markdown
Member

This finishes the migration to use the canonical gradle directory layout / project naming.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
PythonBuild Status
Build Status
---Build Status
Build Status
Build Status------Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@lukecwik
lukecwik requested review from adude3141 and udimJune 20, 2019 16:20
@lukecwik

Copy link
Copy Markdown
MemberAuthor

R: @adude3141@udim

@lukecwik

Copy link
Copy Markdown
MemberAuthor

Run Spotless PreCommit

@lukecwik

Copy link
Copy Markdown
MemberAuthor

Run RAT PreCommit

@adude3141

Copy link
Copy Markdown
Contributor

Although I d really love to get that in, I think we are not yet in the state to remove that translation layer.

Rationale for introducing this layer was to give users the chance to adapt to the new style. I believe we should at least prepare our documentation (e.g. cwiki) to reflect the new style, which was not done yet.

Unfortunately I did not take care to get edit rights for cwiki yet, but I d volunteer to look into this.

wdyt?

@lukecwiklukecwik changed the title [BEAM-4046] Remove old project name mappings.[DO NOT MERGE] [BEAM-4046] Remove old project name mappings.Jun 20, 2019
@lukecwik

lukecwik commented Jun 20, 2019

Copy link
Copy Markdown
MemberAuthor

SGTM, I granted you access to the cwiki.

@adude3141

Copy link
Copy Markdown
Contributor

Adapted https://cwiki.apache.org/confluence/display/BEAM/Apache+Beam to use the canonical gradle directory layout / project naming.

So currently both, beam git repo and beam cwiki should be migrated.

I guess, there will be resources still referecing the old style, which are unfortunately not on our control, eg. stack overflow, blogs etc. But are there any further resources under our control missing migration?

@lukecwik

Copy link
Copy Markdown
MemberAuthor

Not that I'm aware of.

@stale

staleBot commented Aug 23, 2019

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stalestaleBot added the stale label Aug 23, 2019
@stale

staleBot commented Aug 30, 2019

Copy link
Copy Markdown

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stalestaleBot closed this Aug 30, 2019
@adude3141

Copy link
Copy Markdown
Contributor

Now another quarter passed... guess we should finally get this done.

@adude3141adude3141 reopened this Oct 13, 2019
@stale

staleBot commented Oct 13, 2019

Copy link
Copy Markdown

This pull request is no longer marked as stale.

@lukecwiklukecwik changed the title [DO NOT MERGE] [BEAM-4046] Remove old project name mappings.[BEAM-4046] Remove old project name mappings.Oct 14, 2019
@lukecwik

Copy link
Copy Markdown
MemberAuthor

I rebased this on top of master.

@adude3141adude3141 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukecwik
lukecwik merged commit 2a367c3 into apache:masterOct 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lukecwik@adude3141