Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8377] Remove the flink-1.6 from the project-mappings - #9760
Closed
sunjincheng121 wants to merge 2 commits into
Closed
[BEAM-8377] Remove the flink-1.6 from the project-mappings#9760sunjincheng121 wants to merge 2 commits into
sunjincheng121 wants to merge 2 commits into
Conversation
sunjincheng121
commented
Oct 10, 2019
MemberAuthor
R: @adude3141 |
mxm
reviewed
Oct 11, 2019
Uh oh!
There was an error while loading. Please reload this page.
sunjincheng121
commented
Oct 12, 2019
MemberAuthor
Thanks for the review @mxm! |
adude3141
commented
Oct 13, 2019
Contributor
mxm
reviewed
Oct 13, 2019
mxm
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sunjincheng121. Looks good to me except for a minor correction. Considering #8915 is not yet in a mergeable state, I think it would be ok to merge this.
| :beam-runners-flink_2.11 :runners:flink:1.8 | ||
| :beam-runners-flink_1.8-job-server-container :runners:flink:1.8:job-server-container | ||
| :beam-runners-flink_1.8-job-server :runners:flink:1.8:job-server | ||
| :beam-runners-flink_1.8 :runners:flink:1.8 |
Contributor
There was a problem hiding this comment.
Suggested change
| :beam-runners-flink_1.8 :runners:flink:1.8 | |
| :beam-runners-flink-1.8 :runners:flink:1.8 |
| :beam-runners-flink_2.11-job-server :runners:flink:1.8:job-server | ||
| :beam-runners-flink_2.11 :runners:flink:1.8 | ||
| :beam-runners-flink_1.8-job-server-container :runners:flink:1.8:job-server-container | ||
| :beam-runners-flink_1.8-job-server :runners:flink:1.8:job-server |
Contributor
There was a problem hiding this comment.
Suggested change
| :beam-runners-flink_1.8-job-server :runners:flink:1.8:job-server | |
| :beam-runners-flink-1.8-job-server :runners:flink:1.8:job-server |
| :beam-runners-flink_2.11-job-server-container :runners:flink:1.8:job-server-container | ||
| :beam-runners-flink_2.11-job-server :runners:flink:1.8:job-server | ||
| :beam-runners-flink_2.11 :runners:flink:1.8 | ||
| :beam-runners-flink_1.8-job-server-container :runners:flink:1.8:job-server-container |
Contributor
There was a problem hiding this comment.
Suggested change
| :beam-runners-flink_1.8-job-server-container :runners:flink:1.8:job-server-container | |
| :beam-runners-flink-1.8-job-server-container :runners:flink:1.8:job-server-container |
sunjincheng121
commented
Oct 14, 2019
MemberAuthor
Thanks @mxm@adude3141. |
mxm
commented
Oct 15, 2019
Contributor
Closing this since #8915 has been merged. Thanks for opening the PR @sunjincheng121. I think it led to merging the aforementioned PR ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flink 1.5 and 1.6 have been drop in #9632, So we should remove the flink-1.6 from the project-mappings.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.