Uh oh!
There was an error while loading. Please reload this page.
Schema conversion cleanup - #8943
Merged
Merged
Conversation
TheNeuralBitforce-pushed
the
schema-conversion-cleanup
branch
from
June 25, 2019 18:00
146fc7b to
5ecd82bCompareTheNeuralBit
commented
Jun 25, 2019
MemberAuthor
Run Java PreCommit |
TheNeuralBitforce-pushed
the
schema-conversion-cleanup
branch
2 times, most recently
from
June 26, 2019 22:48
bf1cf94 to
7a43a18CompareTheNeuralBitforce-pushed
the
schema-conversion-cleanup
branch
from
June 28, 2019 00:13
7a43a18 to
d584f40CompareTheNeuralBit
commented
Jun 28, 2019
MemberAuthor
Run Portable_Python PreCommit |
TheNeuralBit
commented
Jun 28, 2019
MemberAuthor
Run Python_PVR_Flink PreCommit |
TheNeuralBit
commented
Jun 28, 2019
MemberAuthor
Run Java PreCommit |
2 similar comments
TheNeuralBit
commented
Jun 28, 2019
MemberAuthor
Run Java PreCommit |
TheNeuralBit
commented
Jul 1, 2019
MemberAuthor
Run Java PreCommit |
TheNeuralBit
commented
Jul 1, 2019
MemberAuthor
Run Portable_Python PreCommit |
TheNeuralBit
commented
Jul 19, 2019
MemberAuthor
Run Go PreCommit |
TheNeuralBit
commented
Jul 19, 2019
MemberAuthor
Run JavaPortabilityApi PreCommit |
TheNeuralBit
commented
Jul 19, 2019
MemberAuthor
@reuvenlax do you have time to take a look at this now? |
| } | ||
| enum AtomicType { | ||
| UNSPECIFIED = 0; |
Contributor
There was a problem hiding this comment.
what does UNSPECIFIED mean here?
MemberAuthor
There was a problem hiding this comment.
This was added in the previous PR: #8853 (comment)
reuvenlax
commented
Jul 23, 2019
Contributor
lgtm |
lostluck pushed a commit
to lostluck/beam
that referenced
this pull request
Jul 23, 2019
lostluck pushed a commit
to lostluck/beam
that referenced
this pull request
Jul 23, 2019
TheNeuralBit added a commit
to TheNeuralBit/beam
that referenced
this pull request
Aug 28, 2019
This reverts commit 5597086.
TheNeuralBit added a commit
to TheNeuralBit/beam
that referenced
this pull request
Sep 18, 2019
…anup"" This reverts commit c9da964.
soyrice pushed a commit
to soyrice/beam
that referenced
this pull request
Sep 19, 2019
This reverts commit 5597086.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up based on comments in #8853
ATOMIC_TYPE_MAPPINGin SchemaTranslation in favor of inline switch statementsPost-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
R: @reuvenlax