Skip to content

[BEAM-7060] Prefer inspect module over funcsigs - #9562

Merged
udim merged 1 commit into
apache:masterfrom
udim:funcsigs-py3
Sep 12, 2019
Merged

[BEAM-7060] Prefer inspect module over funcsigs#9562
udim merged 1 commit into
apache:masterfrom
udim:funcsigs-py3

Conversation

@udim

@udimudim commented Sep 12, 2019

Copy link
Copy Markdown
Member

In Python 3 with funcsigs installed, prefer inspect.{signature,Paramter}
over funcsigs equivalents.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

In Python 3 with funcsigs installed, prefer inspect.{signature,Paramter}
over funcsigs equivalents.
@udim

udim commented Sep 12, 2019

Copy link
Copy Markdown
MemberAuthor

R: @robinyqiu

@udim
udim merged commit 43ae56a into apache:masterSep 12, 2019
@robertwb

Copy link
Copy Markdown
Contributor

Should this be cherry-picked into the release?

@udim

udim commented Sep 19, 2019

Copy link
Copy Markdown
MemberAuthor

Probably, yes

@udim

udim commented Sep 19, 2019

Copy link
Copy Markdown
MemberAuthor

I'll make one

markflyhigh added a commit that referenced this pull request Sep 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@udim@robertwb@robinyqiu