Uh oh!
There was an error while loading. Please reload this page.
[8229] Revert "[7746] Create a more user friendly external transform API" - #9565
Closed
aaltay wants to merge 1 commit into
Closed
[8229] Revert "[7746] Create a more user friendly external transform API"#9565aaltay wants to merge 1 commit into
aaltay wants to merge 1 commit into
Conversation
aaltay
commented
Sep 13, 2019
MemberAuthor
chadrik
commented
Sep 13, 2019
Contributor
I introduced some tests of a feature that makes use of PEP526 syntax changes introduced in python 3.6. I got everything passing for the pre-commit tests but did not anticipate the post-commit problems. I'll get those fixed up ASAP. |
chadrik
commented
Sep 13, 2019
Contributor
Note that the other solution to this is dropping support for python 3.5, but that's a bigger discussion. |
aaltay
commented
Sep 13, 2019
MemberAuthor
I was wrong in my JIRA issue. Py2 post commit is failing on py3.7 test. I thought py2 post commit was meant to skip these files. |
aaltay
commented
Sep 13, 2019
MemberAuthor
Run Portable_Python PreCommit |
aaltay
commented
Sep 13, 2019
MemberAuthor
Run Python 2 PostCommit |
3 tasks
aaltay
commented
Sep 13, 2019
MemberAuthor
Closing this. #9570 - addressed the test issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9098
Py 3.7 tests are failing with a syntax error.