Skip to content

[BEAM-8229] Exclude python 3-specific test files from running in post-commit - #9570

Merged
markflyhigh merged 1 commit into
apache:masterfrom
chadrik:py-post-commit-test-fix
Sep 13, 2019
Merged

[BEAM-8229] Exclude python 3-specific test files from running in post-commit#9570
markflyhigh merged 1 commit into
apache:masterfrom
chadrik:py-post-commit-test-fix

Conversation

@chadrik

Copy link
Copy Markdown
Contributor

Fixes#9098 and removes the need for #9565.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@chadrik

Copy link
Copy Markdown
ContributorAuthor

R: @aaltay
R: @robertwb

Here's a quick fix if you want to use this instead of reverting and resubmitting #9098.

It would be good if we could preemptively run post-commit test, since running the integration tests on my laptop seems like a bit of a non-starter.

@chadrik

Copy link
Copy Markdown
ContributorAuthor

Run Python PostCommit

@aaltay

Copy link
Copy Markdown
Member

Run Python 2 PostCommit

@chadrik

Copy link
Copy Markdown
ContributorAuthor

Run Python 3.5 PostCommit

@chadrik

Copy link
Copy Markdown
ContributorAuthor

Run Python 3.6 PostCommit

@robertwbrobertwb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out; let's see if it fixes all the tests.

@chadrik

Copy link
Copy Markdown
ContributorAuthor

I'm happy to clean up my own mess. Sorry about the downtime, still learning my way around the build system.

@chadrik

Copy link
Copy Markdown
ContributorAuthor

@robertwb speaking of builds, you may be interested to weigh in on this ticket: https://jira.apache.org/jira/projects/BEAM/issues/BEAM-8213

@chadrik

Copy link
Copy Markdown
ContributorAuthor

Looks like this is ready to go

@markflyhigh

Copy link
Copy Markdown
Contributor

Thank you @chadrik for this quick fix! I can merge since you got enough approvals.

@markflyhigh
markflyhigh merged commit b04895b into apache:masterSep 13, 2019
@chadrik
chadrik deleted the py-post-commit-test-fix branch September 15, 2019 16:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@chadrik@aaltay@markflyhigh@robertwb