Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8229] Exclude python 3-specific test files from running in post-commit - #9570
Merged
Merged
Conversation
chadrik
commented
Sep 13, 2019
ContributorAuthor
chadrik
commented
Sep 13, 2019
ContributorAuthor
Run Python PostCommit |
aaltay
commented
Sep 13, 2019
Member
Run Python 2 PostCommit |
aaltay
approved these changes
Sep 13, 2019
chadrik
commented
Sep 13, 2019
ContributorAuthor
Run Python 3.5 PostCommit |
chadrik
commented
Sep 13, 2019
ContributorAuthor
Run Python 3.6 PostCommit |
robertwb
approved these changes
Sep 13, 2019
robertwb
left a comment
Contributor
There was a problem hiding this comment.
Thanks for figuring this out; let's see if it fixes all the tests.
chadrik
commented
Sep 13, 2019
ContributorAuthor
I'm happy to clean up my own mess. Sorry about the downtime, still learning my way around the build system. |
chadrik
commented
Sep 13, 2019
ContributorAuthor
@robertwb speaking of builds, you may be interested to weigh in on this ticket: https://jira.apache.org/jira/projects/BEAM/issues/BEAM-8213 |
chadrik
commented
Sep 13, 2019
ContributorAuthor
Looks like this is ready to go |
markflyhigh
commented
Sep 13, 2019
Contributor
Thank you @chadrik for this quick fix! I can merge since you got enough approvals. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9098 and removes the need for #9565.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.