[CELEBORN-1400] Bump Ratis version from 2.5.1 to 3.0.1 by SteNicholas · Pull Request #2480 · apache/celeborn

SteNicholas · 2024-04-24T12:40:14Z

What changes were proposed in this pull request?

Bump Ratis version from 2.5.1 to 3.0.1. Address incompatible changes:

RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream.(RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream. ratis#964)
RATIS-1677. Do not auto format RaftStorage in RECOVER.(RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)

Why are the changes needed?

Bump Ratis version from 2.5.1 to 3.0.1. Ratis has released v3.0.0, v3.0.1, which release note refers to 3.0.0, 3.0.1. The 3.0.x version include new features like pluggable metrics and lease read, etc, some improvements and bugfixes including:

3.0.0: Change list of ratis 3.0.0 In total, there are roughly 100 commits diffing from 2.5.1 including:
- Incompatible Changes
  - RaftStorage Auto-Format
  - RATIS-1677. Do not auto format RaftStorage in RECOVER. (RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
  - RATIS-1694. Fix the compatibility issue of RATIS-1677. (RATIS-1694. Fix the compatibility issue of RATIS-1677. ratis#731)
  - RATIS-1871. Auto format RaftStorage when there is only one directory configured. (RATIS-1871. Auto format RaftStorage when there is only one directory configured. ratis#903)
  - Pluggable Ratis-Metrics (RATIS-1688)
  - RATIS-1689. Remove the use of the thirdparty Gauge. (RATIS-1689. Remove the use of the thirdparty Gauge. ratis#728)
  - RATIS-1692. Remove the use of the thirdparty Counter. (RATIS-1692. Remove the use of the thirdparty Counter. ratis#732)
  - RATIS-1693. Remove the use of the thirdparty Timer. (RATIS-1693. Remove the use of the thirdparty Timer. ratis#734)
  - RATIS-1703. Move MetricsReporting and JvmMetrics to impl. (RATIS-1703. Move MetricsReporting and JvmMetrics to impl. ratis#741)
  - RATIS-1704. Fix SuppressWarnings(“VisibilityModifier”) in RatisMetrics. (RATIS-1704. Fix SuppressWarnings("VisibilityModifier") in RatisMetrics. ratis#742)
  - RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)
  - RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. (RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. ratis#751)
  - RATIS-1391. Update library dropwizard.metrics version to 4.x (RATIS-1391. Update library dropwizard.metrics version to 4.x ratis#632)
  - RATIS-1601. Use the shaded dropwizard metrics and remove the dependency (RATIS-1601. Use the shaded dropwizard metrics and remove the dependency ratis#671)
  - Streaming Protocol Change
  - RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side. (RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side ratis#635)
- New Features
  - Leader Lease (RATIS-1864)
  - RATIS-1865. Add leader lease bound ratio configuration (RATIS-1865. Add leader lease bound ratio configuration ratis#897)
  - RATIS-1866. Maintain leader lease after AppendEntries (RATIS-1866. Maintain leader lease after AppendEntries ratis#898)
  - RATIS-1894. Implement ReadOnly based on leader lease (RATIS-1894. Implement ReadOnly based on leader lease ratis#925)
  - RATIS-1882. Support read-after-write consistency (RATIS-1882. Support read-after-write consistency ratis#913)
  - StateMachine API
  - RATIS-1874. Add notifyLeaderReady function in IStateMachine (RATIS-1874 Add notifyLeaderReady function in IStateMachine ratis#906)
  - RATIS-1897. Make TransactionContext available in DataApi.write(..). (RATIS-1897. Make TransactionContext available in DataApi.write(..). ratis#930)
  - New Configuration Properties
  - RATIS-1862. Add the parameter whether to take Snapshot when stopping to adapt to different services (RATIS-1862 Add the parameter whether to take Snapshot when stopping to adapt to different services ratis#896)
  - RATIS-1930. Add a conf for enable/disable majority-add. (RATIS-1930. Add a conf for enable/disable majority-add. ratis#961)
  - RATIS-1918. Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor. (RATIS-1918 Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor ratis#950)
  - RATIS-1636. Support re-config ratis properties (RATIS-1636. Support re-config ratis properties ratis#800)
  - RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. (RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. ratis#901)
- Improvements & Bug Fixes
  - Netty
    - RATIS-1898. Netty should use EpollEventLoopGroup by default (RATIS-1898. Netty should use EpollEventLoopGroup by default ratis#931)
    - RATIS-1899. Use EpollEventLoopGroup for Netty Proxies (RATIS-1899. Use EpollEventLoopGroup for Netty Proxies ratis#932)
    - RATIS-1921. Shared worker group in WorkerGroupGetter should be closed. (RATIS-1921. Shared worker group in WorkerGroupGetter should be closed ratis#955)
    - RATIS-1923. Netty: atomic operations require side-effect-free functions. (RATIS-1923. Netty: atomic operations require side-effect-free functions. ratis#956)
  - RaftServer
    - RATIS-1924. Increase the default of raft.server.log.segment.size.max. (RATIS-1924. Increase the default of raft.server.log.segment.size.max. ratis#957)
    - RATIS-1892. Unify the lifetime of the RaftServerProxy thread pool (RATIS-1892 Unify the lifetime of the RaftServerProxy thread pool ratis#923)
    - RATIS-1889. NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922 (RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922)
    - RATIS-761. Handle writeStateMachineData failure in leader. (RATIS-761. Handle writeStateMachineData failure in leader. ratis#927)
    - RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. (RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. ratis#933)
    - RATIS-1912. Fix infinity election when perform membership change. (RATIS-1912. Fix infinity election when perform membership change. ratis#954)
    - RATIS-1858. Follower keeps logging first election timeout. (RATIS-1858. Follower keeps logging first election timeout. ratis#894)
3.0.1:This is a bugfix release. See the changes between 3.0.0 and 3.0.1 releases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Cluster manual test.

SteNicholas · 2024-04-24T19:24:28Z

Ping @FMX, @szetszwo, @pan3793, @cxzl25.

szetszwo

The change looks good. (Note that I am not familiar with CELEBORN.)

SteNicholas · 2024-04-25T05:28:12Z

@szetszwo, thanks for your review. cc @FMX.

pan3793 · 2024-04-25T05:31:35Z

does it allow rolling upgrades? should we upgrade followers or the leader first or something else?

SteNicholas · 2024-04-25T05:36:05Z

@pan3793, the rolling upgrade strategy should be:

Try to upgrade a non-leader master node first.
Follow the strategy of upgrading a single worker node - multiple worker nodes - all upgrades.

cc @RexXiong.

FMX · 2024-04-25T08:46:54Z

@SteNicholas Hi, I wonder if this PR affects the rolling upgrade process. Can ratis 3.0.1 servers communicate with ratis 2.5.1 servers?
Can a server of ratis 3.0.1 recover from meta data generated by the ratis 2.5.1 server?

SteNicholas · 2024-04-25T08:51:09Z

@FMX, I didn't test the rolling upgrade process in cluster. I would like to try rolling upgrade for validation of above question.

AngersZhuuuu · 2024-05-10T07:43:38Z

We meet same issue as https://issues.apache.org/jira/browse/RATIS-1860, better to upgrade ratis

SteNicholas · 2024-05-28T11:59:26Z

@FMX, @pan3793, @AngersZhuuuu, I have tested the rolling upgrade process in test environment as follows:

The result of rolling upgrade is that there is no compatibility problem between the communication of 2.5.1 ratis server and 3.0.1 ratis server.

Meanwhile, I have run a test application successfully based on the above situation of master:

PTAL.

RexXiong

Thanks @SteNicholas, LGTM overall. I am just wondering what the write buffer size we should set, and what is the reason?

AngersZhuuuu

LGTM

RexXiong

LGTM, thanks!

SteNicholas · 2024-05-30T06:58:32Z

Ping @pan3793, @FMX. PTAL.

RexXiong · 2024-05-30T09:22:14Z

Merge to main(v0.5.0)

SteNicholas · 2024-04-24T12:40:14Z

What changes were proposed in this pull request?

Bump Ratis version from 2.5.1 to 3.0.1. Address incompatible changes:

RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream.(RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream. ratis#964)
RATIS-1677. Do not auto format RaftStorage in RECOVER.(RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)

Why are the changes needed?

Bump Ratis version from 2.5.1 to 3.0.1. Ratis has released v3.0.0, v3.0.1, which release note refers to 3.0.0, 3.0.1. The 3.0.x version include new features like pluggable metrics and lease read, etc, some improvements and bugfixes including:

3.0.0: Change list of ratis 3.0.0 In total, there are roughly 100 commits diffing from 2.5.1 including:
- Incompatible Changes
  - RaftStorage Auto-Format
  - RATIS-1677. Do not auto format RaftStorage in RECOVER. (RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
  - RATIS-1694. Fix the compatibility issue of RATIS-1677. (RATIS-1694. Fix the compatibility issue of RATIS-1677. ratis#731)
  - RATIS-1871. Auto format RaftStorage when there is only one directory configured. (RATIS-1871. Auto format RaftStorage when there is only one directory configured. ratis#903)
  - Pluggable Ratis-Metrics (RATIS-1688)
  - RATIS-1689. Remove the use of the thirdparty Gauge. (RATIS-1689. Remove the use of the thirdparty Gauge. ratis#728)
  - RATIS-1692. Remove the use of the thirdparty Counter. (RATIS-1692. Remove the use of the thirdparty Counter. ratis#732)
  - RATIS-1693. Remove the use of the thirdparty Timer. (RATIS-1693. Remove the use of the thirdparty Timer. ratis#734)
  - RATIS-1703. Move MetricsReporting and JvmMetrics to impl. (RATIS-1703. Move MetricsReporting and JvmMetrics to impl. ratis#741)
  - RATIS-1704. Fix SuppressWarnings(“VisibilityModifier”) in RatisMetrics. (RATIS-1704. Fix SuppressWarnings("VisibilityModifier") in RatisMetrics. ratis#742)
  - RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)
  - RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. (RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. ratis#751)
  - RATIS-1391. Update library dropwizard.metrics version to 4.x (RATIS-1391. Update library dropwizard.metrics version to 4.x ratis#632)
  - RATIS-1601. Use the shaded dropwizard metrics and remove the dependency (RATIS-1601. Use the shaded dropwizard metrics and remove the dependency ratis#671)
  - Streaming Protocol Change
  - RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side. (RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side ratis#635)
- New Features
  - Leader Lease (RATIS-1864)
  - RATIS-1865. Add leader lease bound ratio configuration (RATIS-1865. Add leader lease bound ratio configuration ratis#897)
  - RATIS-1866. Maintain leader lease after AppendEntries (RATIS-1866. Maintain leader lease after AppendEntries ratis#898)
  - RATIS-1894. Implement ReadOnly based on leader lease (RATIS-1894. Implement ReadOnly based on leader lease ratis#925)
  - RATIS-1882. Support read-after-write consistency (RATIS-1882. Support read-after-write consistency ratis#913)
  - StateMachine API
  - RATIS-1874. Add notifyLeaderReady function in IStateMachine (RATIS-1874 Add notifyLeaderReady function in IStateMachine ratis#906)
  - RATIS-1897. Make TransactionContext available in DataApi.write(..). (RATIS-1897. Make TransactionContext available in DataApi.write(..). ratis#930)
  - New Configuration Properties
  - RATIS-1862. Add the parameter whether to take Snapshot when stopping to adapt to different services (RATIS-1862 Add the parameter whether to take Snapshot when stopping to adapt to different services ratis#896)
  - RATIS-1930. Add a conf for enable/disable majority-add. (RATIS-1930. Add a conf for enable/disable majority-add. ratis#961)
  - RATIS-1918. Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor. (RATIS-1918 Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor ratis#950)
  - RATIS-1636. Support re-config ratis properties (RATIS-1636. Support re-config ratis properties ratis#800)
  - RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. (RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. ratis#901)
- Improvements & Bug Fixes
  - Netty
    - RATIS-1898. Netty should use EpollEventLoopGroup by default (RATIS-1898. Netty should use EpollEventLoopGroup by default ratis#931)
    - RATIS-1899. Use EpollEventLoopGroup for Netty Proxies (RATIS-1899. Use EpollEventLoopGroup for Netty Proxies ratis#932)
    - RATIS-1921. Shared worker group in WorkerGroupGetter should be closed. (RATIS-1921. Shared worker group in WorkerGroupGetter should be closed ratis#955)
    - RATIS-1923. Netty: atomic operations require side-effect-free functions. (RATIS-1923. Netty: atomic operations require side-effect-free functions. ratis#956)
  - RaftServer
    - RATIS-1924. Increase the default of raft.server.log.segment.size.max. (RATIS-1924. Increase the default of raft.server.log.segment.size.max. ratis#957)
    - RATIS-1892. Unify the lifetime of the RaftServerProxy thread pool (RATIS-1892 Unify the lifetime of the RaftServerProxy thread pool ratis#923)
    - RATIS-1889. NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922 (RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922)
    - RATIS-761. Handle writeStateMachineData failure in leader. (RATIS-761. Handle writeStateMachineData failure in leader. ratis#927)
    - RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. (RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. ratis#933)
    - RATIS-1912. Fix infinity election when perform membership change. (RATIS-1912. Fix infinity election when perform membership change. ratis#954)
    - RATIS-1858. Follower keeps logging first election timeout. (RATIS-1858. Follower keeps logging first election timeout. ratis#894)
3.0.1:This is a bugfix release. See the changes between 3.0.0 and 3.0.1 releases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Cluster manual test.

SteNicholas · 2024-04-24T19:24:28Z

Ping @FMX, @szetszwo, @pan3793, @cxzl25.

szetszwo

The change looks good. (Note that I am not familiar with CELEBORN.)

SteNicholas · 2024-04-25T05:28:12Z

@szetszwo, thanks for your review. cc @FMX.

pan3793 · 2024-04-25T05:31:35Z

does it allow rolling upgrades? should we upgrade followers or the leader first or something else?

SteNicholas · 2024-04-25T05:36:05Z

@pan3793, the rolling upgrade strategy should be:

Try to upgrade a non-leader master node first.
Follow the strategy of upgrading a single worker node - multiple worker nodes - all upgrades.

cc @RexXiong.

FMX · 2024-04-25T08:46:54Z

@SteNicholas Hi, I wonder if this PR affects the rolling upgrade process. Can ratis 3.0.1 servers communicate with ratis 2.5.1 servers?
Can a server of ratis 3.0.1 recover from meta data generated by the ratis 2.5.1 server?

SteNicholas · 2024-04-25T08:51:09Z

@FMX, I didn't test the rolling upgrade process in cluster. I would like to try rolling upgrade for validation of above question.

AngersZhuuuu · 2024-05-10T07:43:38Z

We meet same issue as https://issues.apache.org/jira/browse/RATIS-1860, better to upgrade ratis

SteNicholas · 2024-05-28T11:59:26Z

@FMX, @pan3793, @AngersZhuuuu, I have tested the rolling upgrade process in test environment as follows:

The result of rolling upgrade is that there is no compatibility problem between the communication of 2.5.1 ratis server and 3.0.1 ratis server.

Meanwhile, I have run a test application successfully based on the above situation of master:

PTAL.

RexXiong

Thanks @SteNicholas, LGTM overall. I am just wondering what the write buffer size we should set, and what is the reason?

AngersZhuuuu

LGTM

RexXiong

LGTM, thanks!

SteNicholas · 2024-05-30T06:58:32Z

Ping @pan3793, @FMX. PTAL.

RexXiong · 2024-05-30T09:22:14Z

Merge to main(v0.5.0)

SteNicholas · 2024-04-24T12:40:14Z

What changes were proposed in this pull request?

Bump Ratis version from 2.5.1 to 3.0.1. Address incompatible changes:

RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream.(RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream. ratis#964)
RATIS-1677. Do not auto format RaftStorage in RECOVER.(RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)

Why are the changes needed?

Bump Ratis version from 2.5.1 to 3.0.1. Ratis has released v3.0.0, v3.0.1, which release note refers to 3.0.0, 3.0.1. The 3.0.x version include new features like pluggable metrics and lease read, etc, some improvements and bugfixes including:

3.0.0: Change list of ratis 3.0.0 In total, there are roughly 100 commits diffing from 2.5.1 including:
- Incompatible Changes
  - RaftStorage Auto-Format
  - RATIS-1677. Do not auto format RaftStorage in RECOVER. (RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
  - RATIS-1694. Fix the compatibility issue of RATIS-1677. (RATIS-1694. Fix the compatibility issue of RATIS-1677. ratis#731)
  - RATIS-1871. Auto format RaftStorage when there is only one directory configured. (RATIS-1871. Auto format RaftStorage when there is only one directory configured. ratis#903)
  - Pluggable Ratis-Metrics (RATIS-1688)
  - RATIS-1689. Remove the use of the thirdparty Gauge. (RATIS-1689. Remove the use of the thirdparty Gauge. ratis#728)
  - RATIS-1692. Remove the use of the thirdparty Counter. (RATIS-1692. Remove the use of the thirdparty Counter. ratis#732)
  - RATIS-1693. Remove the use of the thirdparty Timer. (RATIS-1693. Remove the use of the thirdparty Timer. ratis#734)
  - RATIS-1703. Move MetricsReporting and JvmMetrics to impl. (RATIS-1703. Move MetricsReporting and JvmMetrics to impl. ratis#741)
  - RATIS-1704. Fix SuppressWarnings(“VisibilityModifier”) in RatisMetrics. (RATIS-1704. Fix SuppressWarnings("VisibilityModifier") in RatisMetrics. ratis#742)
  - RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)
  - RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. (RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. ratis#751)
  - RATIS-1391. Update library dropwizard.metrics version to 4.x (RATIS-1391. Update library dropwizard.metrics version to 4.x ratis#632)
  - RATIS-1601. Use the shaded dropwizard metrics and remove the dependency (RATIS-1601. Use the shaded dropwizard metrics and remove the dependency ratis#671)
  - Streaming Protocol Change
  - RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side. (RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side ratis#635)
- New Features
  - Leader Lease (RATIS-1864)
  - RATIS-1865. Add leader lease bound ratio configuration (RATIS-1865. Add leader lease bound ratio configuration ratis#897)
  - RATIS-1866. Maintain leader lease after AppendEntries (RATIS-1866. Maintain leader lease after AppendEntries ratis#898)
  - RATIS-1894. Implement ReadOnly based on leader lease (RATIS-1894. Implement ReadOnly based on leader lease ratis#925)
  - RATIS-1882. Support read-after-write consistency (RATIS-1882. Support read-after-write consistency ratis#913)
  - StateMachine API
  - RATIS-1874. Add notifyLeaderReady function in IStateMachine (RATIS-1874 Add notifyLeaderReady function in IStateMachine ratis#906)
  - RATIS-1897. Make TransactionContext available in DataApi.write(..). (RATIS-1897. Make TransactionContext available in DataApi.write(..). ratis#930)
  - New Configuration Properties
  - RATIS-1862. Add the parameter whether to take Snapshot when stopping to adapt to different services (RATIS-1862 Add the parameter whether to take Snapshot when stopping to adapt to different services ratis#896)
  - RATIS-1930. Add a conf for enable/disable majority-add. (RATIS-1930. Add a conf for enable/disable majority-add. ratis#961)
  - RATIS-1918. Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor. (RATIS-1918 Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor ratis#950)
  - RATIS-1636. Support re-config ratis properties (RATIS-1636. Support re-config ratis properties ratis#800)
  - RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. (RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. ratis#901)
- Improvements & Bug Fixes
  - Netty
    - RATIS-1898. Netty should use EpollEventLoopGroup by default (RATIS-1898. Netty should use EpollEventLoopGroup by default ratis#931)
    - RATIS-1899. Use EpollEventLoopGroup for Netty Proxies (RATIS-1899. Use EpollEventLoopGroup for Netty Proxies ratis#932)
    - RATIS-1921. Shared worker group in WorkerGroupGetter should be closed. (RATIS-1921. Shared worker group in WorkerGroupGetter should be closed ratis#955)
    - RATIS-1923. Netty: atomic operations require side-effect-free functions. (RATIS-1923. Netty: atomic operations require side-effect-free functions. ratis#956)
  - RaftServer
    - RATIS-1924. Increase the default of raft.server.log.segment.size.max. (RATIS-1924. Increase the default of raft.server.log.segment.size.max. ratis#957)
    - RATIS-1892. Unify the lifetime of the RaftServerProxy thread pool (RATIS-1892 Unify the lifetime of the RaftServerProxy thread pool ratis#923)
    - RATIS-1889. NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922 (RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922)
    - RATIS-761. Handle writeStateMachineData failure in leader. (RATIS-761. Handle writeStateMachineData failure in leader. ratis#927)
    - RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. (RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. ratis#933)
    - RATIS-1912. Fix infinity election when perform membership change. (RATIS-1912. Fix infinity election when perform membership change. ratis#954)
    - RATIS-1858. Follower keeps logging first election timeout. (RATIS-1858. Follower keeps logging first election timeout. ratis#894)
3.0.1:This is a bugfix release. See the changes between 3.0.0 and 3.0.1 releases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Cluster manual test.

SteNicholas · 2024-04-24T19:24:28Z

Ping @FMX, @szetszwo, @pan3793, @cxzl25.

szetszwo

The change looks good. (Note that I am not familiar with CELEBORN.)

SteNicholas · 2024-04-25T05:28:12Z

@szetszwo, thanks for your review. cc @FMX.

pan3793 · 2024-04-25T05:31:35Z

does it allow rolling upgrades? should we upgrade followers or the leader first or something else?

SteNicholas · 2024-04-25T05:36:05Z

@pan3793, the rolling upgrade strategy should be:

Try to upgrade a non-leader master node first.
Follow the strategy of upgrading a single worker node - multiple worker nodes - all upgrades.

cc @RexXiong.

FMX · 2024-04-25T08:46:54Z

@SteNicholas Hi, I wonder if this PR affects the rolling upgrade process. Can ratis 3.0.1 servers communicate with ratis 2.5.1 servers?
Can a server of ratis 3.0.1 recover from meta data generated by the ratis 2.5.1 server?

SteNicholas · 2024-04-25T08:51:09Z

@FMX, I didn't test the rolling upgrade process in cluster. I would like to try rolling upgrade for validation of above question.

AngersZhuuuu · 2024-05-10T07:43:38Z

We meet same issue as https://issues.apache.org/jira/browse/RATIS-1860, better to upgrade ratis

SteNicholas · 2024-05-28T11:59:26Z

@FMX, @pan3793, @AngersZhuuuu, I have tested the rolling upgrade process in test environment as follows:

The result of rolling upgrade is that there is no compatibility problem between the communication of 2.5.1 ratis server and 3.0.1 ratis server.

Meanwhile, I have run a test application successfully based on the above situation of master:

PTAL.

RexXiong

Thanks @SteNicholas, LGTM overall. I am just wondering what the write buffer size we should set, and what is the reason?

AngersZhuuuu

LGTM

RexXiong

LGTM, thanks!

SteNicholas · 2024-05-30T06:58:32Z

Ping @pan3793, @FMX. PTAL.

RexXiong · 2024-05-30T09:22:14Z

Merge to main(v0.5.0)

SteNicholas · 2024-04-24T12:40:14Z

What changes were proposed in this pull request?

Bump Ratis version from 2.5.1 to 3.0.1. Address incompatible changes:

RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream.(RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream. ratis#964)
RATIS-1677. Do not auto format RaftStorage in RECOVER.(RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)

Why are the changes needed?

Bump Ratis version from 2.5.1 to 3.0.1. Ratis has released v3.0.0, v3.0.1, which release note refers to 3.0.0, 3.0.1. The 3.0.x version include new features like pluggable metrics and lease read, etc, some improvements and bugfixes including:

3.0.0: Change list of ratis 3.0.0 In total, there are roughly 100 commits diffing from 2.5.1 including:
- Incompatible Changes
  - RaftStorage Auto-Format
  - RATIS-1677. Do not auto format RaftStorage in RECOVER. (RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
  - RATIS-1694. Fix the compatibility issue of RATIS-1677. (RATIS-1694. Fix the compatibility issue of RATIS-1677. ratis#731)
  - RATIS-1871. Auto format RaftStorage when there is only one directory configured. (RATIS-1871. Auto format RaftStorage when there is only one directory configured. ratis#903)
  - Pluggable Ratis-Metrics (RATIS-1688)
  - RATIS-1689. Remove the use of the thirdparty Gauge. (RATIS-1689. Remove the use of the thirdparty Gauge. ratis#728)
  - RATIS-1692. Remove the use of the thirdparty Counter. (RATIS-1692. Remove the use of the thirdparty Counter. ratis#732)
  - RATIS-1693. Remove the use of the thirdparty Timer. (RATIS-1693. Remove the use of the thirdparty Timer. ratis#734)
  - RATIS-1703. Move MetricsReporting and JvmMetrics to impl. (RATIS-1703. Move MetricsReporting and JvmMetrics to impl. ratis#741)
  - RATIS-1704. Fix SuppressWarnings(“VisibilityModifier”) in RatisMetrics. (RATIS-1704. Fix SuppressWarnings("VisibilityModifier") in RatisMetrics. ratis#742)
  - RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)
  - RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. (RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. ratis#751)
  - RATIS-1391. Update library dropwizard.metrics version to 4.x (RATIS-1391. Update library dropwizard.metrics version to 4.x ratis#632)
  - RATIS-1601. Use the shaded dropwizard metrics and remove the dependency (RATIS-1601. Use the shaded dropwizard metrics and remove the dependency ratis#671)
  - Streaming Protocol Change
  - RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side. (RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side ratis#635)
- New Features
  - Leader Lease (RATIS-1864)
  - RATIS-1865. Add leader lease bound ratio configuration (RATIS-1865. Add leader lease bound ratio configuration ratis#897)
  - RATIS-1866. Maintain leader lease after AppendEntries (RATIS-1866. Maintain leader lease after AppendEntries ratis#898)
  - RATIS-1894. Implement ReadOnly based on leader lease (RATIS-1894. Implement ReadOnly based on leader lease ratis#925)
  - RATIS-1882. Support read-after-write consistency (RATIS-1882. Support read-after-write consistency ratis#913)
  - StateMachine API
  - RATIS-1874. Add notifyLeaderReady function in IStateMachine (RATIS-1874 Add notifyLeaderReady function in IStateMachine ratis#906)
  - RATIS-1897. Make TransactionContext available in DataApi.write(..). (RATIS-1897. Make TransactionContext available in DataApi.write(..). ratis#930)
  - New Configuration Properties
  - RATIS-1862. Add the parameter whether to take Snapshot when stopping to adapt to different services (RATIS-1862 Add the parameter whether to take Snapshot when stopping to adapt to different services ratis#896)
  - RATIS-1930. Add a conf for enable/disable majority-add. (RATIS-1930. Add a conf for enable/disable majority-add. ratis#961)
  - RATIS-1918. Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor. (RATIS-1918 Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor ratis#950)
  - RATIS-1636. Support re-config ratis properties (RATIS-1636. Support re-config ratis properties ratis#800)
  - RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. (RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. ratis#901)
- Improvements & Bug Fixes
  - Netty
    - RATIS-1898. Netty should use EpollEventLoopGroup by default (RATIS-1898. Netty should use EpollEventLoopGroup by default ratis#931)
    - RATIS-1899. Use EpollEventLoopGroup for Netty Proxies (RATIS-1899. Use EpollEventLoopGroup for Netty Proxies ratis#932)
    - RATIS-1921. Shared worker group in WorkerGroupGetter should be closed. (RATIS-1921. Shared worker group in WorkerGroupGetter should be closed ratis#955)
    - RATIS-1923. Netty: atomic operations require side-effect-free functions. (RATIS-1923. Netty: atomic operations require side-effect-free functions. ratis#956)
  - RaftServer
    - RATIS-1924. Increase the default of raft.server.log.segment.size.max. (RATIS-1924. Increase the default of raft.server.log.segment.size.max. ratis#957)
    - RATIS-1892. Unify the lifetime of the RaftServerProxy thread pool (RATIS-1892 Unify the lifetime of the RaftServerProxy thread pool ratis#923)
    - RATIS-1889. NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922 (RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922)
    - RATIS-761. Handle writeStateMachineData failure in leader. (RATIS-761. Handle writeStateMachineData failure in leader. ratis#927)
    - RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. (RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. ratis#933)
    - RATIS-1912. Fix infinity election when perform membership change. (RATIS-1912. Fix infinity election when perform membership change. ratis#954)
    - RATIS-1858. Follower keeps logging first election timeout. (RATIS-1858. Follower keeps logging first election timeout. ratis#894)
3.0.1:This is a bugfix release. See the changes between 3.0.0 and 3.0.1 releases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Cluster manual test.

SteNicholas · 2024-04-24T19:24:28Z

Ping @FMX, @szetszwo, @pan3793, @cxzl25.

szetszwo

The change looks good. (Note that I am not familiar with CELEBORN.)

SteNicholas · 2024-04-25T05:28:12Z

@szetszwo, thanks for your review. cc @FMX.

pan3793 · 2024-04-25T05:31:35Z

does it allow rolling upgrades? should we upgrade followers or the leader first or something else?

SteNicholas · 2024-04-25T05:36:05Z

@pan3793, the rolling upgrade strategy should be:

Try to upgrade a non-leader master node first.
Follow the strategy of upgrading a single worker node - multiple worker nodes - all upgrades.

cc @RexXiong.

FMX · 2024-04-25T08:46:54Z

@SteNicholas Hi, I wonder if this PR affects the rolling upgrade process. Can ratis 3.0.1 servers communicate with ratis 2.5.1 servers?
Can a server of ratis 3.0.1 recover from meta data generated by the ratis 2.5.1 server?

SteNicholas · 2024-04-25T08:51:09Z

@FMX, I didn't test the rolling upgrade process in cluster. I would like to try rolling upgrade for validation of above question.

AngersZhuuuu · 2024-05-10T07:43:38Z

We meet same issue as https://issues.apache.org/jira/browse/RATIS-1860, better to upgrade ratis

SteNicholas · 2024-05-28T11:59:26Z

@FMX, @pan3793, @AngersZhuuuu, I have tested the rolling upgrade process in test environment as follows:

The result of rolling upgrade is that there is no compatibility problem between the communication of 2.5.1 ratis server and 3.0.1 ratis server.

Meanwhile, I have run a test application successfully based on the above situation of master:

PTAL.

RexXiong

Thanks @SteNicholas, LGTM overall. I am just wondering what the write buffer size we should set, and what is the reason?

AngersZhuuuu

LGTM

RexXiong

LGTM, thanks!

SteNicholas · 2024-05-30T06:58:32Z

Ping @pan3793, @FMX. PTAL.

RexXiong · 2024-05-30T09:22:14Z

Merge to main(v0.5.0)

SteNicholas · 2024-04-24T12:40:14Z

What changes were proposed in this pull request?

Bump Ratis version from 2.5.1 to 3.0.1. Address incompatible changes:

RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream.(RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream. ratis#964)
RATIS-1677. Do not auto format RaftStorage in RECOVER.(RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)

Why are the changes needed?

Bump Ratis version from 2.5.1 to 3.0.1. Ratis has released v3.0.0, v3.0.1, which release note refers to 3.0.0, 3.0.1. The 3.0.x version include new features like pluggable metrics and lease read, etc, some improvements and bugfixes including:

3.0.0: Change list of ratis 3.0.0 In total, there are roughly 100 commits diffing from 2.5.1 including:
- Incompatible Changes
  - RaftStorage Auto-Format
  - RATIS-1677. Do not auto format RaftStorage in RECOVER. (RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
  - RATIS-1694. Fix the compatibility issue of RATIS-1677. (RATIS-1694. Fix the compatibility issue of RATIS-1677. ratis#731)
  - RATIS-1871. Auto format RaftStorage when there is only one directory configured. (RATIS-1871. Auto format RaftStorage when there is only one directory configured. ratis#903)
  - Pluggable Ratis-Metrics (RATIS-1688)
  - RATIS-1689. Remove the use of the thirdparty Gauge. (RATIS-1689. Remove the use of the thirdparty Gauge. ratis#728)
  - RATIS-1692. Remove the use of the thirdparty Counter. (RATIS-1692. Remove the use of the thirdparty Counter. ratis#732)
  - RATIS-1693. Remove the use of the thirdparty Timer. (RATIS-1693. Remove the use of the thirdparty Timer. ratis#734)
  - RATIS-1703. Move MetricsReporting and JvmMetrics to impl. (RATIS-1703. Move MetricsReporting and JvmMetrics to impl. ratis#741)
  - RATIS-1704. Fix SuppressWarnings(“VisibilityModifier”) in RatisMetrics. (RATIS-1704. Fix SuppressWarnings("VisibilityModifier") in RatisMetrics. ratis#742)
  - RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)
  - RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. (RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. ratis#751)
  - RATIS-1391. Update library dropwizard.metrics version to 4.x (RATIS-1391. Update library dropwizard.metrics version to 4.x ratis#632)
  - RATIS-1601. Use the shaded dropwizard metrics and remove the dependency (RATIS-1601. Use the shaded dropwizard metrics and remove the dependency ratis#671)
  - Streaming Protocol Change
  - RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side. (RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side ratis#635)
- New Features
  - Leader Lease (RATIS-1864)
  - RATIS-1865. Add leader lease bound ratio configuration (RATIS-1865. Add leader lease bound ratio configuration ratis#897)
  - RATIS-1866. Maintain leader lease after AppendEntries (RATIS-1866. Maintain leader lease after AppendEntries ratis#898)
  - RATIS-1894. Implement ReadOnly based on leader lease (RATIS-1894. Implement ReadOnly based on leader lease ratis#925)
  - RATIS-1882. Support read-after-write consistency (RATIS-1882. Support read-after-write consistency ratis#913)
  - StateMachine API
  - RATIS-1874. Add notifyLeaderReady function in IStateMachine (RATIS-1874 Add notifyLeaderReady function in IStateMachine ratis#906)
  - RATIS-1897. Make TransactionContext available in DataApi.write(..). (RATIS-1897. Make TransactionContext available in DataApi.write(..). ratis#930)
  - New Configuration Properties
  - RATIS-1862. Add the parameter whether to take Snapshot when stopping to adapt to different services (RATIS-1862 Add the parameter whether to take Snapshot when stopping to adapt to different services ratis#896)
  - RATIS-1930. Add a conf for enable/disable majority-add. (RATIS-1930. Add a conf for enable/disable majority-add. ratis#961)
  - RATIS-1918. Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor. (RATIS-1918 Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor ratis#950)
  - RATIS-1636. Support re-config ratis properties (RATIS-1636. Support re-config ratis properties ratis#800)
  - RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. (RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. ratis#901)
- Improvements & Bug Fixes
  - Netty
    - RATIS-1898. Netty should use EpollEventLoopGroup by default (RATIS-1898. Netty should use EpollEventLoopGroup by default ratis#931)
    - RATIS-1899. Use EpollEventLoopGroup for Netty Proxies (RATIS-1899. Use EpollEventLoopGroup for Netty Proxies ratis#932)
    - RATIS-1921. Shared worker group in WorkerGroupGetter should be closed. (RATIS-1921. Shared worker group in WorkerGroupGetter should be closed ratis#955)
    - RATIS-1923. Netty: atomic operations require side-effect-free functions. (RATIS-1923. Netty: atomic operations require side-effect-free functions. ratis#956)
  - RaftServer
    - RATIS-1924. Increase the default of raft.server.log.segment.size.max. (RATIS-1924. Increase the default of raft.server.log.segment.size.max. ratis#957)
    - RATIS-1892. Unify the lifetime of the RaftServerProxy thread pool (RATIS-1892 Unify the lifetime of the RaftServerProxy thread pool ratis#923)
    - RATIS-1889. NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922 (RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922)
    - RATIS-761. Handle writeStateMachineData failure in leader. (RATIS-761. Handle writeStateMachineData failure in leader. ratis#927)
    - RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. (RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. ratis#933)
    - RATIS-1912. Fix infinity election when perform membership change. (RATIS-1912. Fix infinity election when perform membership change. ratis#954)
    - RATIS-1858. Follower keeps logging first election timeout. (RATIS-1858. Follower keeps logging first election timeout. ratis#894)
3.0.1:This is a bugfix release. See the changes between 3.0.0 and 3.0.1 releases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Cluster manual test.

SteNicholas · 2024-04-24T19:24:28Z

Ping @FMX, @szetszwo, @pan3793, @cxzl25.

szetszwo

The change looks good. (Note that I am not familiar with CELEBORN.)

SteNicholas · 2024-04-25T05:28:12Z

@szetszwo, thanks for your review. cc @FMX.

pan3793 · 2024-04-25T05:31:35Z

does it allow rolling upgrades? should we upgrade followers or the leader first or something else?

SteNicholas · 2024-04-25T05:36:05Z

@pan3793, the rolling upgrade strategy should be:

Try to upgrade a non-leader master node first.
Follow the strategy of upgrading a single worker node - multiple worker nodes - all upgrades.

cc @RexXiong.

FMX · 2024-04-25T08:46:54Z

@SteNicholas Hi, I wonder if this PR affects the rolling upgrade process. Can ratis 3.0.1 servers communicate with ratis 2.5.1 servers?
Can a server of ratis 3.0.1 recover from meta data generated by the ratis 2.5.1 server?

SteNicholas · 2024-04-25T08:51:09Z

@FMX, I didn't test the rolling upgrade process in cluster. I would like to try rolling upgrade for validation of above question.

AngersZhuuuu · 2024-05-10T07:43:38Z

We meet same issue as https://issues.apache.org/jira/browse/RATIS-1860, better to upgrade ratis

SteNicholas · 2024-05-28T11:59:26Z

@FMX, @pan3793, @AngersZhuuuu, I have tested the rolling upgrade process in test environment as follows:

The result of rolling upgrade is that there is no compatibility problem between the communication of 2.5.1 ratis server and 3.0.1 ratis server.

Meanwhile, I have run a test application successfully based on the above situation of master:

PTAL.

RexXiong

Thanks @SteNicholas, LGTM overall. I am just wondering what the write buffer size we should set, and what is the reason?

AngersZhuuuu

LGTM

RexXiong

LGTM, thanks!

SteNicholas · 2024-05-30T06:58:32Z

Ping @pan3793, @FMX. PTAL.

RexXiong · 2024-05-30T09:22:14Z

Merge to main(v0.5.0)

SteNicholas · 2024-04-24T12:40:14Z

What changes were proposed in this pull request?

Bump Ratis version from 2.5.1 to 3.0.1. Address incompatible changes:

RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream.(RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream. ratis#964)
RATIS-1677. Do not auto format RaftStorage in RECOVER.(RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)

Why are the changes needed?

Bump Ratis version from 2.5.1 to 3.0.1. Ratis has released v3.0.0, v3.0.1, which release note refers to 3.0.0, 3.0.1. The 3.0.x version include new features like pluggable metrics and lease read, etc, some improvements and bugfixes including:

3.0.0: Change list of ratis 3.0.0 In total, there are roughly 100 commits diffing from 2.5.1 including:
- Incompatible Changes
  - RaftStorage Auto-Format
  - RATIS-1677. Do not auto format RaftStorage in RECOVER. (RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
  - RATIS-1694. Fix the compatibility issue of RATIS-1677. (RATIS-1694. Fix the compatibility issue of RATIS-1677. ratis#731)
  - RATIS-1871. Auto format RaftStorage when there is only one directory configured. (RATIS-1871. Auto format RaftStorage when there is only one directory configured. ratis#903)
  - Pluggable Ratis-Metrics (RATIS-1688)
  - RATIS-1689. Remove the use of the thirdparty Gauge. (RATIS-1689. Remove the use of the thirdparty Gauge. ratis#728)
  - RATIS-1692. Remove the use of the thirdparty Counter. (RATIS-1692. Remove the use of the thirdparty Counter. ratis#732)
  - RATIS-1693. Remove the use of the thirdparty Timer. (RATIS-1693. Remove the use of the thirdparty Timer. ratis#734)
  - RATIS-1703. Move MetricsReporting and JvmMetrics to impl. (RATIS-1703. Move MetricsReporting and JvmMetrics to impl. ratis#741)
  - RATIS-1704. Fix SuppressWarnings(“VisibilityModifier”) in RatisMetrics. (RATIS-1704. Fix SuppressWarnings("VisibilityModifier") in RatisMetrics. ratis#742)
  - RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)
  - RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. (RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. ratis#751)
  - RATIS-1391. Update library dropwizard.metrics version to 4.x (RATIS-1391. Update library dropwizard.metrics version to 4.x ratis#632)
  - RATIS-1601. Use the shaded dropwizard metrics and remove the dependency (RATIS-1601. Use the shaded dropwizard metrics and remove the dependency ratis#671)
  - Streaming Protocol Change
  - RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side. (RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side ratis#635)
- New Features
  - Leader Lease (RATIS-1864)
  - RATIS-1865. Add leader lease bound ratio configuration (RATIS-1865. Add leader lease bound ratio configuration ratis#897)
  - RATIS-1866. Maintain leader lease after AppendEntries (RATIS-1866. Maintain leader lease after AppendEntries ratis#898)
  - RATIS-1894. Implement ReadOnly based on leader lease (RATIS-1894. Implement ReadOnly based on leader lease ratis#925)
  - RATIS-1882. Support read-after-write consistency (RATIS-1882. Support read-after-write consistency ratis#913)
  - StateMachine API
  - RATIS-1874. Add notifyLeaderReady function in IStateMachine (RATIS-1874 Add notifyLeaderReady function in IStateMachine ratis#906)
  - RATIS-1897. Make TransactionContext available in DataApi.write(..). (RATIS-1897. Make TransactionContext available in DataApi.write(..). ratis#930)
  - New Configuration Properties
  - RATIS-1862. Add the parameter whether to take Snapshot when stopping to adapt to different services (RATIS-1862 Add the parameter whether to take Snapshot when stopping to adapt to different services ratis#896)
  - RATIS-1930. Add a conf for enable/disable majority-add. (RATIS-1930. Add a conf for enable/disable majority-add. ratis#961)
  - RATIS-1918. Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor. (RATIS-1918 Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor ratis#950)
  - RATIS-1636. Support re-config ratis properties (RATIS-1636. Support re-config ratis properties ratis#800)
  - RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. (RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. ratis#901)
- Improvements & Bug Fixes
  - Netty
    - RATIS-1898. Netty should use EpollEventLoopGroup by default (RATIS-1898. Netty should use EpollEventLoopGroup by default ratis#931)
    - RATIS-1899. Use EpollEventLoopGroup for Netty Proxies (RATIS-1899. Use EpollEventLoopGroup for Netty Proxies ratis#932)
    - RATIS-1921. Shared worker group in WorkerGroupGetter should be closed. (RATIS-1921. Shared worker group in WorkerGroupGetter should be closed ratis#955)
    - RATIS-1923. Netty: atomic operations require side-effect-free functions. (RATIS-1923. Netty: atomic operations require side-effect-free functions. ratis#956)
  - RaftServer
    - RATIS-1924. Increase the default of raft.server.log.segment.size.max. (RATIS-1924. Increase the default of raft.server.log.segment.size.max. ratis#957)
    - RATIS-1892. Unify the lifetime of the RaftServerProxy thread pool (RATIS-1892 Unify the lifetime of the RaftServerProxy thread pool ratis#923)
    - RATIS-1889. NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922 (RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922)
    - RATIS-761. Handle writeStateMachineData failure in leader. (RATIS-761. Handle writeStateMachineData failure in leader. ratis#927)
    - RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. (RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. ratis#933)
    - RATIS-1912. Fix infinity election when perform membership change. (RATIS-1912. Fix infinity election when perform membership change. ratis#954)
    - RATIS-1858. Follower keeps logging first election timeout. (RATIS-1858. Follower keeps logging first election timeout. ratis#894)
3.0.1:This is a bugfix release. See the changes between 3.0.0 and 3.0.1 releases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Cluster manual test.

SteNicholas · 2024-04-24T19:24:28Z

Ping @FMX, @szetszwo, @pan3793, @cxzl25.

szetszwo

The change looks good. (Note that I am not familiar with CELEBORN.)

SteNicholas · 2024-04-25T05:28:12Z

@szetszwo, thanks for your review. cc @FMX.

pan3793 · 2024-04-25T05:31:35Z

does it allow rolling upgrades? should we upgrade followers or the leader first or something else?

SteNicholas · 2024-04-25T05:36:05Z

@pan3793, the rolling upgrade strategy should be:

Try to upgrade a non-leader master node first.
Follow the strategy of upgrading a single worker node - multiple worker nodes - all upgrades.

cc @RexXiong.

FMX · 2024-04-25T08:46:54Z

@SteNicholas Hi, I wonder if this PR affects the rolling upgrade process. Can ratis 3.0.1 servers communicate with ratis 2.5.1 servers?
Can a server of ratis 3.0.1 recover from meta data generated by the ratis 2.5.1 server?

SteNicholas · 2024-04-25T08:51:09Z

@FMX, I didn't test the rolling upgrade process in cluster. I would like to try rolling upgrade for validation of above question.

AngersZhuuuu · 2024-05-10T07:43:38Z

We meet same issue as https://issues.apache.org/jira/browse/RATIS-1860, better to upgrade ratis

SteNicholas · 2024-05-28T11:59:26Z

@FMX, @pan3793, @AngersZhuuuu, I have tested the rolling upgrade process in test environment as follows:

The result of rolling upgrade is that there is no compatibility problem between the communication of 2.5.1 ratis server and 3.0.1 ratis server.

Meanwhile, I have run a test application successfully based on the above situation of master:

PTAL.

RexXiong

Thanks @SteNicholas, LGTM overall. I am just wondering what the write buffer size we should set, and what is the reason?

AngersZhuuuu

LGTM

RexXiong

LGTM, thanks!

SteNicholas · 2024-05-30T06:58:32Z

Ping @pan3793, @FMX. PTAL.

RexXiong · 2024-05-30T09:22:14Z

Merge to main(v0.5.0)

SteNicholas · 2024-04-24T12:40:14Z

What changes were proposed in this pull request?

Bump Ratis version from 2.5.1 to 3.0.1. Address incompatible changes:

RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream.(RATIS-589. Eliminate buffer copying in SegmentedRaftLogOutputStream. ratis#964)
RATIS-1677. Do not auto format RaftStorage in RECOVER.(RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)

Why are the changes needed?

Bump Ratis version from 2.5.1 to 3.0.1. Ratis has released v3.0.0, v3.0.1, which release note refers to 3.0.0, 3.0.1. The 3.0.x version include new features like pluggable metrics and lease read, etc, some improvements and bugfixes including:

3.0.0: Change list of ratis 3.0.0 In total, there are roughly 100 commits diffing from 2.5.1 including:
- Incompatible Changes
  - RaftStorage Auto-Format
  - RATIS-1677. Do not auto format RaftStorage in RECOVER. (RATIS-1677. Do not auto format RaftStorage in RECOVER. ratis#718)
  - RATIS-1694. Fix the compatibility issue of RATIS-1677. (RATIS-1694. Fix the compatibility issue of RATIS-1677. ratis#731)
  - RATIS-1871. Auto format RaftStorage when there is only one directory configured. (RATIS-1871. Auto format RaftStorage when there is only one directory configured. ratis#903)
  - Pluggable Ratis-Metrics (RATIS-1688)
  - RATIS-1689. Remove the use of the thirdparty Gauge. (RATIS-1689. Remove the use of the thirdparty Gauge. ratis#728)
  - RATIS-1692. Remove the use of the thirdparty Counter. (RATIS-1692. Remove the use of the thirdparty Counter. ratis#732)
  - RATIS-1693. Remove the use of the thirdparty Timer. (RATIS-1693. Remove the use of the thirdparty Timer. ratis#734)
  - RATIS-1703. Move MetricsReporting and JvmMetrics to impl. (RATIS-1703. Move MetricsReporting and JvmMetrics to impl. ratis#741)
  - RATIS-1704. Fix SuppressWarnings(“VisibilityModifier”) in RatisMetrics. (RATIS-1704. Fix SuppressWarnings("VisibilityModifier") in RatisMetrics. ratis#742)
  - RATIS-1710. Refactor metrics api and implementation to separated modules. (RATIS-1710. Refactor metrics api and implementation to separated modules. ratis#749)
  - RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. (RATIS-1712. Add a dropwizard 3 implementation of ratis-metrics-api. ratis#751)
  - RATIS-1391. Update library dropwizard.metrics version to 4.x (RATIS-1391. Update library dropwizard.metrics version to 4.x ratis#632)
  - RATIS-1601. Use the shaded dropwizard metrics and remove the dependency (RATIS-1601. Use the shaded dropwizard metrics and remove the dependency ratis#671)
  - Streaming Protocol Change
  - RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side. (RATIS-1569. Move the asyncRpcApi.sendForward(..) call to the client side ratis#635)
- New Features
  - Leader Lease (RATIS-1864)
  - RATIS-1865. Add leader lease bound ratio configuration (RATIS-1865. Add leader lease bound ratio configuration ratis#897)
  - RATIS-1866. Maintain leader lease after AppendEntries (RATIS-1866. Maintain leader lease after AppendEntries ratis#898)
  - RATIS-1894. Implement ReadOnly based on leader lease (RATIS-1894. Implement ReadOnly based on leader lease ratis#925)
  - RATIS-1882. Support read-after-write consistency (RATIS-1882. Support read-after-write consistency ratis#913)
  - StateMachine API
  - RATIS-1874. Add notifyLeaderReady function in IStateMachine (RATIS-1874 Add notifyLeaderReady function in IStateMachine ratis#906)
  - RATIS-1897. Make TransactionContext available in DataApi.write(..). (RATIS-1897. Make TransactionContext available in DataApi.write(..). ratis#930)
  - New Configuration Properties
  - RATIS-1862. Add the parameter whether to take Snapshot when stopping to adapt to different services (RATIS-1862 Add the parameter whether to take Snapshot when stopping to adapt to different services ratis#896)
  - RATIS-1930. Add a conf for enable/disable majority-add. (RATIS-1930. Add a conf for enable/disable majority-add. ratis#961)
  - RATIS-1918. Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor. (RATIS-1918 Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor ratis#950)
  - RATIS-1636. Support re-config ratis properties (RATIS-1636. Support re-config ratis properties ratis#800)
  - RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. (RATIS-1860. Add ratis-shell cmd to generate a new raft-meta.conf. ratis#901)
- Improvements & Bug Fixes
  - Netty
    - RATIS-1898. Netty should use EpollEventLoopGroup by default (RATIS-1898. Netty should use EpollEventLoopGroup by default ratis#931)
    - RATIS-1899. Use EpollEventLoopGroup for Netty Proxies (RATIS-1899. Use EpollEventLoopGroup for Netty Proxies ratis#932)
    - RATIS-1921. Shared worker group in WorkerGroupGetter should be closed. (RATIS-1921. Shared worker group in WorkerGroupGetter should be closed ratis#955)
    - RATIS-1923. Netty: atomic operations require side-effect-free functions. (RATIS-1923. Netty: atomic operations require side-effect-free functions. ratis#956)
  - RaftServer
    - RATIS-1924. Increase the default of raft.server.log.segment.size.max. (RATIS-1924. Increase the default of raft.server.log.segment.size.max. ratis#957)
    - RATIS-1892. Unify the lifetime of the RaftServerProxy thread pool (RATIS-1892 Unify the lifetime of the RaftServerProxy thread pool ratis#923)
    - RATIS-1889. NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922 (RATIS-1889 NoSuchMethodError: RaftServerMetricsImpl.addNumPendingRequestsGauge ratis#922)
    - RATIS-761. Handle writeStateMachineData failure in leader. (RATIS-761. Handle writeStateMachineData failure in leader. ratis#927)
    - RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. (RATIS-1902. The snapshot index is set incorrectly in InstallSnapshotReplyProto. ratis#933)
    - RATIS-1912. Fix infinity election when perform membership change. (RATIS-1912. Fix infinity election when perform membership change. ratis#954)
    - RATIS-1858. Follower keeps logging first election timeout. (RATIS-1858. Follower keeps logging first election timeout. ratis#894)
3.0.1:This is a bugfix release. See the changes between 3.0.0 and 3.0.1 releases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Cluster manual test.

SteNicholas · 2024-04-24T19:24:28Z

Ping @FMX, @szetszwo, @pan3793, @cxzl25.

szetszwo

The change looks good. (Note that I am not familiar with CELEBORN.)

SteNicholas · 2024-04-25T05:28:12Z

@szetszwo, thanks for your review. cc @FMX.

pan3793 · 2024-04-25T05:31:35Z

does it allow rolling upgrades? should we upgrade followers or the leader first or something else?

SteNicholas · 2024-04-25T05:36:05Z

@pan3793, the rolling upgrade strategy should be:

Try to upgrade a non-leader master node first.
Follow the strategy of upgrading a single worker node - multiple worker nodes - all upgrades.

cc @RexXiong.

FMX · 2024-04-25T08:46:54Z

@SteNicholas Hi, I wonder if this PR affects the rolling upgrade process. Can ratis 3.0.1 servers communicate with ratis 2.5.1 servers?
Can a server of ratis 3.0.1 recover from meta data generated by the ratis 2.5.1 server?

SteNicholas · 2024-04-25T08:51:09Z

@FMX, I didn't test the rolling upgrade process in cluster. I would like to try rolling upgrade for validation of above question.

AngersZhuuuu · 2024-05-10T07:43:38Z

We meet same issue as https://issues.apache.org/jira/browse/RATIS-1860, better to upgrade ratis

SteNicholas · 2024-05-28T11:59:26Z

@FMX, @pan3793, @AngersZhuuuu, I have tested the rolling upgrade process in test environment as follows:

The result of rolling upgrade is that there is no compatibility problem between the communication of 2.5.1 ratis server and 3.0.1 ratis server.

Meanwhile, I have run a test application successfully based on the above situation of master:

PTAL.

RexXiong

Thanks @SteNicholas, LGTM overall. I am just wondering what the write buffer size we should set, and what is the reason?

AngersZhuuuu

LGTM

RexXiong

LGTM, thanks!

SteNicholas · 2024-05-30T06:58:32Z

Ping @pan3793, @FMX. PTAL.

RexXiong · 2024-05-30T09:22:14Z

Merge to main(v0.5.0)

SteNicholas requested review from FMX, cxzl25 and pan3793 April 24, 2024 12:42

SteNicholas force-pushed the CELEBORN-1400 branch 5 times, most recently from 4ac7ef8 to b9e92b9Compare April 24, 2024 18:53

szetszwo reviewed Apr 25, 2024
View reviewed changes

SteNicholas requested a review from RexXiong May 28, 2024 12:52

RexXiong approved these changes May 28, 2024
View reviewed changes

Comment threadcommon/src/main/scala/org/apache/celeborn/common/CelebornConf.scala

SteNicholas force-pushed the CELEBORN-1400 branch from b9e92b9 to 79cf2dcCompare May 29, 2024 01:06

SteNicholas requested a review from RexXiong May 29, 2024 01:08

AngersZhuuuu reviewed May 29, 2024
View reviewed changes

Comment threadmaster/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HARaftServer.java Outdated

SteNicholas force-pushed the CELEBORN-1400 branch from 79cf2dc to edc610cCompare May 29, 2024 06:37

SteNicholas requested a review from AngersZhuuuu May 29, 2024 06:45

SteNicholas force-pushed the CELEBORN-1400 branch from edc610c to 39523e4Compare May 29, 2024 07:05

[CELEBORN-1400] Bump Ratis version from 2.5.1 to 3.0.1
5df6bdc

SteNicholas force-pushed the CELEBORN-1400 branch from 39523e4 to 5df6bdcCompare May 29, 2024 07:08

AngersZhuuuu approved these changes May 29, 2024
View reviewed changes

RexXiong approved these changes May 29, 2024
View reviewed changes

pan3793 approved these changes May 30, 2024
View reviewed changes

RexXiong closed this in 2a57fabMay 30, 2024