Skip to content

Modified project details - role based users in projects - #145

Merged
yadvr merged 4 commits into
apache:masterfrom
shapeblue:proj-roleBased-users
Sep 24, 2020
Merged

Modified project details - role based users in projects#145
yadvr merged 4 commits into
apache:masterfrom
shapeblue:proj-roleBased-users

Conversation

@Pearl1594

@Pearl1594Pearl1594 commented Aug 11, 2020

Copy link
Copy Markdown
Contributor

Added details with respect to support for:

  • multiple project admins
  • project roles to restrict users from performing operations at project level

@Pearl1594

Pearl1594 commented Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

requesting docbuild

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

@Pearl1594
Pearl1594force-pushed the proj-roleBased-users branch from 59da762 to f903066CompareAugust 11, 2020 04:52
@Pearl1594

Pearl1594 commented Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

requesting docbuild

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

@Pearl1594
Pearl1594force-pushed the proj-roleBased-users branch from f903066 to 948217fCompareAugust 11, 2020 05:04
@Pearl1594

Pearl1594 commented Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

requesting docbuild

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

DaanHoogland
DaanHoogland reviewed Aug 11, 2020
View reviewed changes

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor remarks

Comment threadsource/adminguide/projects.rst Outdated
invitation to any email address.

#. To view and manage the invitations you have sent, return to this tab.
5. To view and manage the invitations you have sent, return to this tab.

@DaanHooglandDaanHooglandAug 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should th 5. here be a #.?

@Pearl1594Pearl1594Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment threadsource/adminguide/projects.rst
by the Account level role. If there are no specific deny rules in the
project role, it would again fallback onto the account-level role to decide
whether the user has permissions to perform a specific action.

@DaanHooglandDaanHooglandAug 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like to see a second note to make clear that a user's rights can not be widened in comparison to their account role but only restricted.

@Pearl1594Pearl1594Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added relevant details

@Pearl1594

Pearl1594 commented Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

requesting docbuild

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

@Pearl1594

Pearl1594 commented Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

requesting docbuild

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

GabrielBrascher
GabrielBrascher reviewed Aug 11, 2020
View reviewed changes

@GabrielBrascherGabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece of documentation, thanks @Pearl1594! I raised a few points to change.

Bear in mind that I am not a native English speaker, therefore, some of my suggestions might not be ideal.

Comment threadsource/adminguide/projects.rst Outdated
Comment threadsource/adminguide/projects.rst Outdated
it is possible to restrict access of users in a project, i.e., in
addition to account-level roles, one can further restrict access to
operations (or APIs) by associating a project-level role to the
user or account. However, If an account has already been added, one will not

@GabrielBrascherGabrielBrascherAug 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, If ➡️ However, if

Comment threadsource/adminguide/projects.rst Outdated
Comment threadsource/adminguide/projects.rst Outdated
Comment threadsource/adminguide/projects.rst
Comment threadsource/adminguide/projects.rst Outdated
@GabrielBrascher

GabrielBrascher commented Aug 11, 2020

Copy link
Copy Markdown
Member

@Pearl1594@DaanHoogland Is this still draft or can we put it into "Ready for review"?

@Pearl1594
Pearl1594 marked this pull request as ready for review August 11, 2020 12:35
@Pearl1594

Pearl1594 commented Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

@GabrielBrascher I've addressed your comments. Thanks for pointing them out.

@Pearl1594

Pearl1594 commented Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

requesting docbuild

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

ACSGitBot commented Aug 11, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

GabrielBrascher
GabrielBrascher approved these changes Aug 11, 2020
View reviewed changes

@GabrielBrascherGabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yadvr pushed a commit to apache/cloudstack that referenced this pull request Aug 13, 2020
@Pearl1594Pearl Dsilva@sureshanaparti
projects: Role based users in Projects (#4128)
c578004
Enabling Role Based users in projects
Primate PR related to the FR: apache/cloudstack-primate#382
Doc PR: apache/cloudstack-documentation#145
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
@yadvr
yadvr merged commit 316861b into apache:masterSep 24, 2020
@yadvryadvr added this to the 4.15 milestone Sep 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHooglandDaanHooglandDaanHoogland approved these changes
@GabrielBrascherGabrielBrascherGabrielBrascher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15

Development

Successfully merging this pull request may close these issues.

5 participants

@Pearl1594@ACSGitBot@GabrielBrascher@DaanHoogland@yadvr