Uh oh!
There was an error while loading. Please reload this page.
VM ingestion - #84
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
| - listUnmanagedInstances - to list unmanaged virtual machines for a cluster. | ||
| - importUnmanagedInstance - to import an unmanaged virtual machine into CloudStack. | ||
There was a problem hiding this comment.
@shwstppr add details on how to use the .py script etc?
There was a problem hiding this comment.
@rhtyd yes, will be adding that. This was just initial commit to create PR, working on rest of the documentation
@andrijapanicsb@PaulAngus Can you please review changes |
PaulAngus
commented
Nov 18, 2019
requesting docbuild |
ACSGitBot
commented
Nov 18, 2019
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
ACSGitBot
commented
Nov 18, 2019
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84 Build Log Output: No log errors found to report. |
shwstppr
commented
Dec 2, 2019
requesting docbuild |
ACSGitBot
commented
Dec 2, 2019
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
ACSGitBot
commented
Dec 2, 2019
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84 Build Log Output: No log errors found to report. |
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
and separate "importing VMs" into a separate file.
PaulAngus
commented
Jan 13, 2020
requesting docbuild |
ACSGitBot
commented
Jan 13, 2020
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
ACSGitBot
commented
Jan 13, 2020
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84 Build Log Output: No log errors found to report. |
PaulAngus
commented
Jan 15, 2020
requesting docbuild |
ACSGitBot
commented
Jan 15, 2020
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
ACSGitBot
commented
Jan 15, 2020
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84 Build Log Output: No log errors found to report. |
shwstppr
left a comment
There was a problem hiding this comment.
Some minor suggestions @PaulAngus
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ############### | ||
| To import a VM which has data disks attached, a map of the disk ID and corresponding disk offering ID must be passed via the *datadiskofferinglist* parameter. |
There was a problem hiding this comment.
@PaulAngus We also have diskofferingid parameter for specifying offering for root disk so do we need to mention that here.
There was a problem hiding this comment.
oh boy, what happens in code? the diskoffering is a messy subject, a user doesn't choose a disk offering for the root, it's linked to the serviceoffering ID
There was a problem hiding this comment.
While importing it uses disk offeering passedc with param diskofferingid. It is a required parameter for importUnmanagedInstance API
There was a problem hiding this comment.
hmm. if you consider creating a VM from a template, you don't pass a disk offering, it's implicit from the service offering...
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr
commented
Mar 17, 2020
requesting docbuild |
ACSGitBot
commented
Mar 17, 2020
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
ACSGitBot
commented
Mar 17, 2020
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr84 Build Log Output: No log errors found to report. |
andrijapanicsb
commented
May 13, 2020
@shwstppr Can you please update this one:
|
PaulAngus
commented
May 13, 2020
if you merge B&R, the commits will match. |
@PaulAngus are you saying that this one is reviewed and LGTM? |
PaulAngus
commented
May 13, 2020
@shwstppr it doesn't look like you've updated this PR after review by Steve Roles ..? |
shwstppr
commented
May 13, 2020
@PaulAngus I don't think Steve ever reviewed this one. There was no draft word doc for it. After initial updates it was mostly updated by you. |
shwstppr
commented
May 13, 2020
@andrijapanic will resolve the conflict tomorrow morning |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr
commented
May 14, 2020
@andrijapanicsb I've fixed conflicts. cc @PaulAngus |
andrijapanicsb
commented
May 14, 2020
requesting docbuild |
ACSGitBot
commented
May 14, 2020
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
ACSGitBot
commented
May 14, 2020
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr84 Build Log Output: No log errors found to report. |
andrijapanicsb
commented
May 21, 2020
@shwstppr@PaulAngus - can you advise if this is good to go or not, we need it asap for 4.14. |
Uh oh!
There was an error while loading. Please reload this page.
andrijapanicsb
commented
May 23, 2020
pinging again for LGTM if possible. |
andrijapanicsb
commented
May 25, 2020
Merging as it is, looks LGTM in general, but we can always improve it if needed. |
Documentation PR for VM Ingestion feature.
Feature PR: apache/cloudstack#3606