Skip to content

VM ingestion - #84

Merged
andrijapanicsb merged 19 commits into
apache:masterfrom
shapeblue:feature-vm-ingestion
May 25, 2020
Merged

VM ingestion#84
andrijapanicsb merged 19 commits into
apache:masterfrom
shapeblue:feature-vm-ingestion

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Documentation PR for VM Ingestion feature.
Feature PR: apache/cloudstack#3606

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
- listUnmanagedInstances - to list unmanaged virtual machines for a cluster.

- importUnmanagedInstance - to import an unmanaged virtual machine into CloudStack.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwstppr add details on how to use the .py script etc?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtyd yes, will be adding that. This was just initial commit to create PR, working on rest of the documentation

@shwstpprshwstppr mentioned this pull request Nov 18, 2019
5 tasks
@shwstpprshwstppr changed the title [WIP DO NOT MERGE] VM Ingestion[WIP DO NOT MERGE] VM ingestionNov 18, 2019
@shwstppr

shwstppr commented Nov 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@andrijapanicsb@PaulAngus Can you please review changes
I'm not sure if it is the correct location in documentation to add vm ingestion notes so please advise changes needed.
Also, advise on the format. Since this is my first documentation PR I'm not sure if added notes, API details correctly.

@PaulAngus

Copy link
Copy Markdown
Member

requesting docbuild

@ACSGitBot

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84

Build Log Output:

No log errors found to report.

@shwstppr

Copy link
Copy Markdown
ContributorAuthor

requesting docbuild

@ACSGitBot

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84

Build Log Output:

No log errors found to report.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvryadvr added the feature New feature or request label Dec 29, 2019
@PaulAngus

Copy link
Copy Markdown
Member

requesting docbuild

@ACSGitBot

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84

Build Log Output:

No log errors found to report.

@PaulAngus

Copy link
Copy Markdown
Member

requesting docbuild

@ACSGitBot

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84

Build Log Output:

No log errors found to report.

@shwstpprshwstppr left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions @PaulAngus

Comment threadsource/adminguide/virtual_machines/VM_Ingestion.rst Outdated
Comment threadsource/adminguide/virtual_machines/VM_Ingestion.rst Outdated
###############


To import a VM which has data disks attached, a map of the disk ID and corresponding disk offering ID must be passed via the *datadiskofferinglist* parameter.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulAngus We also have diskofferingid parameter for specifying offering for root disk so do we need to mention that here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh boy, what happens in code? the diskoffering is a messy subject, a user doesn't choose a disk offering for the root, it's linked to the serviceoffering ID

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While importing it uses disk offeering passedc with param diskofferingid. It is a required parameter for importUnmanagedInstance API

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. if you consider creating a VM from a template, you don't pass a disk offering, it's implicit from the service offering...

Comment threadsource/adminguide/virtual_machines/VM_Ingestion.rst Outdated
Paul Angusand others added 3 commits January 15, 2020 14:10
Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>
@PaulAngusPaulAngus changed the title [WIP DO NOT MERGE] VM ingestionVM ingestion and B&RJan 30, 2020
@shwstppr

Copy link
Copy Markdown
ContributorAuthor

requesting docbuild

@ACSGitBot

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr84

Build Log Output:

No log errors found to report.

@andrijapanicsb

Copy link
Copy Markdown
Contributor

@shwstppr Can you please update this one:

  • there is conflict
  • it mentioned Backup and Recovery, but there is actually a separate B&R PR [WIP] Backup & Recovery Doc Guide #85
  • can you sync with Rohit and see what is what and to have this one (VM ingestion) merged.

@PaulAngus

Copy link
Copy Markdown
Member

if you merge B&R, the commits will match.
B&R was used as the basis for this to avoid conflicts

@andrijapanicsb

andrijapanicsb commented May 13, 2020

Copy link
Copy Markdown
Contributor

@PaulAngus are you saying that this one is reviewed and LGTM?

@PaulAngus

Copy link
Copy Markdown
Member

@shwstppr it doesn't look like you've updated this PR after review by Steve Roles ..?

@PaulAngusPaulAngus changed the title VM ingestion and B&RVM ingestionMay 13, 2020
@shwstppr

Copy link
Copy Markdown
ContributorAuthor

@PaulAngus I don't think Steve ever reviewed this one. There was no draft word doc for it. After initial updates it was mostly updated by you.

@shwstppr

Copy link
Copy Markdown
ContributorAuthor

@andrijapanic will resolve the conflict tomorrow morning

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

Copy link
Copy Markdown
ContributorAuthor

@andrijapanicsb I've fixed conflicts. cc @PaulAngus

@andrijapanicsb

Copy link
Copy Markdown
Contributor

requesting docbuild

@ACSGitBot

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr84

Build Log Output:

No log errors found to report.

@andrijapanicsb

Copy link
Copy Markdown
Contributor

@shwstppr@PaulAngus - can you advise if this is good to go or not, we need it asap for 4.14.
thx

Comment threadsource/adminguide/virtual_machines/VM_Ingestion.rst Outdated
@andrijapanicsb

Copy link
Copy Markdown
Contributor

pinging again for LGTM if possible.

@andrijapanicsb

Copy link
Copy Markdown
Contributor

Merging as it is, looks LGTM in general, but we can always improve it if needed.
Required for 4.14 to go out.

@andrijapanicsb
andrijapanicsb merged commit 95b7382 into apache:masterMay 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

featureNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr@PaulAngus@ACSGitBot@andrijapanicsb@yadvr