Skip to content

[WIP] Backup & Recovery Doc Guide - #85

Merged
DaanHoogland merged 8 commits into
apache:masterfrom
shapeblue:backup-recovery-doc
May 14, 2020
Merged

[WIP] Backup & Recovery Doc Guide#85
DaanHoogland merged 8 commits into
apache:masterfrom
shapeblue:backup-recovery-doc

Conversation

@yadvr

@yadvryadvr commented Dec 8, 2019

Copy link
Copy Markdown
Member

@yadvr
b&R doc wip
a7f80af
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvryadvr mentioned this pull request Dec 8, 2019
Merged
5 tasks
@yadvr

yadvr commented Dec 8, 2019

Copy link
Copy Markdown
MemberAuthor

requesting docbuild

@yadvr
changes
541fc1e
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Dec 29, 2019

Copy link
Copy Markdown
MemberAuthor

requesting docbuild

@yadvr
newline fixes
419bd10
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Dec 29, 2019

Copy link
Copy Markdown
MemberAuthor

requesting docbuild

@yadvr

yadvr commented Dec 29, 2019

Copy link
Copy Markdown
MemberAuthor

@PaulAngus@borisstoyanov I've submitted the feature write-up, please review/extend, edit/advise changes. Thanks.

@yadvryadvr added the feature New feature or request label Dec 29, 2019
@apacheapache deleted a comment from ACSGitBotJan 6, 2020
@apacheapache deleted a comment from ACSGitBotJan 6, 2020
@apacheapache deleted a comment from ACSGitBotJan 6, 2020
@apacheapache deleted a comment from ACSGitBotJan 6, 2020
@apacheapache deleted a comment from ACSGitBotJan 6, 2020
@apacheapache deleted a comment from ACSGitBotJan 6, 2020
@apacheapache deleted a comment from ACSGitBotJan 6, 2020
@apacheapache deleted a comment from ACSGitBotJan 6, 2020
@apacheapache deleted a comment from ACSGitBotJan 6, 2020
@PaulAngus

PaulAngus commented Jan 6, 2020

Copy link
Copy Markdown
Member

requesting docbuild

@ACSGitBot

ACSGitBot commented Jan 6, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

ACSGitBot commented Jan 6, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr85

Build Log Output:

No log errors found to report.

1 similar comment
@ACSGitBot

ACSGitBot commented Jan 6, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr85

Build Log Output:

No log errors found to report.

@yadvr

yadvr commented Jan 14, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks @PaulAngus for the screenshots and writeup.

@DaanHoogland

DaanHoogland commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

useful for learning testing. I would like to have a deployment diagram added to visualise which machines are involved (MS, VSphere, Veeam, Storage), I'll do a full review once i tested the feature.

@DaanHoogland

DaanHoogland commented Mar 2, 2020

Copy link
Copy Markdown
Contributor

tested extensively with advanced zone in isolated networks, basic feature has been tested in a shared network. Only smoke tests have been done in basic zone.

DaanHoogland
DaanHoogland reviewed Mar 2, 2020
View reviewed changes

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B&R looks generally fine. a lot of changes unrelated to it. should we separate these into another PR or rename this PR?

Comment threadsource/adminguide/backup_and_recovery.rst
Comment on lines +24 to +25
a plugin model to enable any solution which provides backup and recovery 'like'
features to be integrated.

@DaanHooglandDaanHooglandMar 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the 'like'?

@PaulAngusPaulAngusApr 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'like' because one could replicate the backup and recovery features, using a storage vendors' backend snapshot and restore capabilities,

Comment threadsource/adminguide/backup_and_recovery.rst
Comment threadsource/adminguide/templates.rst
Comment on lines +388 to +390
Working with ISOs
===================

@DaanHooglandDaanHooglandMar 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this addition relevant to this pr or did it creep in?

@PaulAngusPaulAngusApr 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't remember, i suspect that i found it in 'the wrong place' when structuring the additional documentation.

Comment threadsource/adminguide/veeam_plugin.rst Outdated
==================================== ========================
Configuration Description
==================================== ========================
backup.plugin.veeam.url Veeam B&R server URL. Default: http://<VEEAM_SERVER_IP>:9399/api/

@DaanHooglandDaanHooglandMar 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the default port has changed with the latest veeam: http://<VEEAM_SERVER_IP>:9398/api/

@PaulAngusPaulAngusApr 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Comment threadsource/adminguide/virtual_machines.rst

Changing the VM Name, OS, or Group
----------------------------------
-------------------------------------

@DaanHooglandDaanHooglandMar 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over-underlining

Comment threadsource/adminguide/virtual_machines.rst Outdated
Comment threadsource/adminguide/virtual_machines.rst Outdated
Comment threadsource/adminguide/virtual_machines.rst Outdated
Comment threadsource/adminguide/virtual_machines.rst Outdated
Comment threadsource/adminguide/virtual_machines.rst
@PaulAngus

PaulAngus commented Apr 20, 2020

Copy link
Copy Markdown
Member

request docbuild

@ACSGitBot

ACSGitBot commented Apr 20, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot

ACSGitBot commented Apr 20, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr85

Build Log Output:

No log errors found to report.

@yadvr

yadvr commented May 13, 2020

Copy link
Copy Markdown
MemberAuthor

@PaulAngus@andrijapanicsb should we merge this?

@yadvryadvr added this to the 4.14.0.0 milestone May 13, 2020
@andrijapanicsb

andrijapanicsb commented May 13, 2020

Copy link
Copy Markdown
Contributor

as long as it's LGTM by Paul or Daan - I guess yes - we need it for 4.14.

@andrijapanicsbandrijapanicsb mentioned this pull request May 13, 2020
Merged
@PaulAngus

PaulAngus commented May 13, 2020•
edited
Loading

Copy link
Copy Markdown
Member

I've updated based on Daan's review so AFAIC it's good to go. @andrijapanicsb

@DaanHoogland
DaanHoogland merged commit 78c39ea into apache:masterMay 14, 2020
@DaanHoogland
DaanHoogland deleted the backup-recovery-doc branch May 14, 2020 08:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHooglandDaanHooglandDaanHoogland approved these changes
@PaulAngusPaulAngusAwaiting requested review from PaulAngus
@borisstoyanovborisstoyanovAwaiting requested review from borisstoyanov

Assignees

No one assigned

Labels

featureNew feature or request

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@yadvr@PaulAngus@ACSGitBot@DaanHoogland@andrijapanicsb