Bootintobios by DaanHoogland · Pull Request #313 · apache/cloudstack-primate

DaanHoogland · 2020-04-24T15:28:00Z

UI implementation for apache/cloudstack#4021

DaanHoogland · 2020-04-24T15:29:33Z

@rhtyd @shwstppr can you review please?

DaanHoogland · 2020-04-27T12:35:29Z

thanks guys, I'll address your feedback, soon.

DaanHoogland · 2020-04-28T08:02:31Z

thanks @rhtyd and @shwstppr . I addressed your comments, please have a look. And please note that this code will at best do nothing until cloudstack 4021 is merged.

yadvr · 2020-05-15T12:19:40Z

@blueorangutan package

blueorangutan · 2020-05-15T12:25:40Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-05-15T12:49:57Z

Packaging result: ✔️centos ✔️debian ✔️archive. JID-1864

yadvr · 2020-05-15T16:07:54Z

@blueorangutan package

blueorangutan · 2020-05-15T16:09:17Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-05-15T16:19:55Z

Packaging result: ✔️centos ✔️debian ✔️archive. JID-1869

yadvr · 2020-06-03T08:28:12Z

@DaanHoogland please ping me when this is ready for review

DaanHoogland · 2020-06-03T08:29:14Z

@rhtyd it is ready for review, but the cloudstack code is not merged yet.

yadvr · 2020-06-04T02:25:33Z

@DaanHoogland can you fix the merge conflicts? I think we merge this in Primate as soon as we've any test confirmation. Thanks.

Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland · 2020-06-04T10:14:54Z

@shwstppr @davidjumani @rhtyd I rebased but my en.json file does not seem ok. to much diff. Can you check if I did the reverse of what was intended?

yadvr · 2020-06-05T05:15:02Z

@DaanHoogland not urgent - the next time you get chance to work on this - can you revert your changes to en.json; keep the version from upstream and then sort/diff what you need to specific keys for your feature.

DaanHoogland · 2020-06-05T13:48:40Z

@rhtyd fixed my booboo (hope the late mister Hawkins approves)

yadvr · 2020-06-05T13:59:49Z

@blueorangutan package

blueorangutan · 2020-06-05T14:00:39Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-05T14:08:26Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/313 (JID-1978)

yadvr · 2020-06-12T05:13:23Z

@borisstoyanov @vladimirpetrov have you also tested this Primate PR against the upstream PR (merged upstream now) apache/cloudstack#4021?

borisstoyanov · 2020-06-12T10:57:50Z

@rhtyd yes, primate changes has been covered also

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2020-06-16T09:51:36Z

+ fields = ['podid', 'clusterid', 'hostid']
+ }
+ if (record.hypervisor === 'VMware') {
+ if (store.apis.startVirtualMachine.params.filter(x => x.name === 'bootintosetup').length > 0) {


@DaanHoogland I've tested and fixed a case here - we want to make Primate work with all recent/pass/future version of CloudStack; so if there's a feature adding new params for autogenerated forms, we can check if the param is available by checking the API discovery /cc @shwstppr @davidjumani

UI implementation for apache/cloudstack#4021 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Daan Hoogland <dahn@onecht.net> Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added this to the 1.0-GA milestone Apr 25, 2020

yadvr reviewed Apr 25, 2020
View reviewed changes

Comment threadsrc/config/section/compute.js Outdated

yadvr reviewed Apr 25, 2020
View reviewed changes

Comment threadsrc/views/compute/DeployVM.vue Outdated

yadvr reviewed Apr 25, 2020
View reviewed changes

Comment threadsrc/views/compute/DeployVM.vue Outdated

yadvr reviewed Apr 25, 2020
View reviewed changes

Comment threadsrc/views/compute/DeployVM.vue Outdated

shwstppr reviewed Apr 27, 2020
View reviewed changes

Comment threadsrc/views/compute/DeployVM.vue Outdated

DaanHoogland commented Apr 28, 2020
View reviewed changes

Comment threadsrc/config/section/compute.js Outdated

DaanHoogland commented Apr 28, 2020
View reviewed changes

Comment threadsrc/config/section/compute.js Outdated

DaanHoogland mentioned this pull request Apr 28, 2020
Boot into hardware setup menu on Vmware apache/cloudstack#4021
Merged
5 tasks

DaanHoogland commented May 6, 2020
View reviewed changes

Comment threadsrc/config/section/compute.js Outdated

shwstppr reviewed May 6, 2020
View reviewed changes

Comment threadsrc/config/section/compute.js Outdated

DaanHoogland mentioned this pull request May 7, 2020
view: fix actionbutton args method resource #327
Merged

DaanHoogland force-pushed the bootintobios branch 2 times, most recently from c7e1005 to 4de5bb5Compare May 7, 2020 13:06

DaanHoogland force-pushed the bootintobios branch from 31f1733 to b061d96Compare May 15, 2020 12:05

apache deleted a comment from blueorangutan May 15, 2020

DaanHoogland force-pushed the bootintobios branch from b061d96 to d6c28abCompare May 22, 2020 08:09

yadvr marked this pull request as ready for review June 4, 2020 02:24

yadvr modified the milestone: 1.0-GA Jun 4, 2020

DaanHooglandand others added 8 commits June 4, 2020 09:57

simple start and reboot
4bc2da6

boot into bios on deploy
995423e

direct event handling instead of method delegation
42b363b
Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>

parameter rename and comments addressed
339c990

move enter setup to top step
464c910

conditional field
aa85d87

hypervisor specific fixes
8331c3d
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

amend faulty concat on array
e827d9b

DaanHoogland force-pushed the bootintobios branch from d6c28ab to e827d9bCompare June 4, 2020 10:10

label strategy update
10ddb1d

yadvr self-requested a review June 12, 2020 04:31

yadvr added 2 commits June 16, 2020 14:13

Merge remote-tracking branch 'origin/master' into bootintobios
c185aa0

fix bootintobios issue
f4f56f1
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr reviewed Jun 16, 2020
View reviewed changes

yadvr merged commit e606fe9 into apache:masterJun 16, 2020

yadvr approved these changes Jun 16, 2020
View reviewed changes

Uh oh!

Conversation

DaanHoogland commented Apr 24, 2020

Uh oh!

DaanHoogland commented Apr 24, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaanHoogland commented Apr 27, 2020

Uh oh!

Uh oh!

Uh oh!

DaanHoogland commented Apr 28, 2020

Uh oh!

Uh oh!

Uh oh!

yadvr commented May 15, 2020

Uh oh!

blueorangutan commented May 15, 2020

Uh oh!

blueorangutan commented May 15, 2020• edited by yadvr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yadvr commented May 15, 2020

Uh oh!

blueorangutan commented May 15, 2020

Uh oh!

blueorangutan commented May 15, 2020

Uh oh!

yadvr commented Jun 3, 2020

Uh oh!

DaanHoogland commented Jun 3, 2020

Uh oh!

yadvr commented Jun 4, 2020

Uh oh!

DaanHoogland commented Jun 4, 2020

Uh oh!

yadvr commented Jun 5, 2020

Uh oh!

DaanHoogland commented Jun 5, 2020

Uh oh!

yadvr commented Jun 5, 2020

Uh oh!

blueorangutan commented Jun 5, 2020

Uh oh!

blueorangutan commented Jun 5, 2020

Uh oh!

yadvr commented Jun 12, 2020

Uh oh!

borisstoyanov commented Jun 12, 2020

Uh oh!

yadvrJun 16, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

blueorangutan commented May 15, 2020•
edited by yadvr
Loading