Uh oh!
There was an error while loading. Please reload this page.
Boot into hardware setup menu on Vmware - #4021
Conversation
7b4f5c9 to
8f68612Compare447a96c to
7e333a2Comparesvenvogel
commented
Apr 23, 2020
@DaanHoogland do you think it could be used to extend it for KVM? |
bootintobios does not make sense for KVM as you can edit the xml for setup @svenvogel. I have not looked into that, yet. Same is claimed for xen btw. It might make sense for some of the smaller hypervisors. |
blueorangutan
commented
Jun 4, 2020
Packaging result: ✔centos7 ✔debian. JID-1294 |
yadvr
commented
Jun 4, 2020
@blueorangutan test centos7 vmware-67u3 |
blueorangutan
commented
Jun 4, 2020
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests |
blueorangutan
commented
Jun 5, 2020
Trillian test result (tid-1626)
|
UI implementation for apache/cloudstack#4021 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Daan Hoogland <dahn@onecht.net> Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
| UserVm userVm = rebootVirtualMachine(CallContext.current().getCallingUserId(), vmId); | ||
| Boolean enterSetup = cmd.getBootIntoSetup(); | ||
| if (enterSetup != null && !HypervisorType.VMware.equals(vmInstance.getHypervisorType())) { | ||
| throw new InvalidParameterValueException("booting into a hardware setup menu does not make sense on " + vmInstance.getHypervisorType()); |
There was a problem hiding this comment.
I don't like this message, missing capital "B" and in general I don't like it... can we reword it to "...not supported for ...." or similar?
There was a problem hiding this comment.
ah, yes we can but a new re-word PR is needed.
yadvr
commented
Jul 14, 2020
This or any of the VMware related PRs may have introduced some regression due to consistently failing test |
UI implementation for apache/cloudstack#4021 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Daan Hoogland <dahn@onecht.net> Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
UI implementation for #4021 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Daan Hoogland <dahn@onecht.net> Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Description
allow VMs to be started into BIOS on Vmware. This is implemented in the reboot, start and deploy APIs for user VMs.
Related Primate PR: apache/cloudstack-primate#313
Types of changes
Screenshots (if appropriate):
A primate PR has been created with number 313
How Has This Been Tested?
this has been manually verified by means of API/old-UI/primate and checking if the boot menu would then be visible or not depending on the flag passed.