Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

vApps frontend support - #550

Merged
yadvr merged 23 commits into
apache:masterfrom
shapeblue:vappsproperty-refactor
Aug 17, 2020
Merged

vApps frontend support#550
yadvr merged 23 commits into
apache:masterfrom
shapeblue:vappsproperty-refactor

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Changes in backend

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-2501)

shwstppr added 11 commits July 23, 2020 11:30
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@yadvryadvr added this to the 1.0-GA milestone Aug 4, 2020
@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-2892)

@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-2935)

@yadvr

Copy link
Copy Markdown
Member

@shwstppr@nvazquez is this ready for review/merging or are we expecting more changes?

@shwstppr

Copy link
Copy Markdown
ContributorAuthor

changes for licenses remaining @rhtyd

shwstpprand others added 2 commits August 12, 2020 17:57
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
shwstppr marked this pull request as ready for review August 13, 2020 06:26
@shwstppr
shwstppr marked this pull request as draft August 13, 2020 11:36
@yadvryadvr changed the title vapps backend refactorvApps frontend supportAug 14, 2020
@yadvr

Copy link
Copy Markdown
Member

@shwstppr@nvazquez is this ready for review/testing now?
@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-3134)

@shwstppr
shwstppr marked this pull request as ready for review August 14, 2020 09:13
@shwstppr

Copy link
Copy Markdown
ContributorAuthor

@rhtyd yes, please review

@yadvr
yadvr requested review from nvazquez and yadvrAugust 14, 2020 10:56

@nvazqueznvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on testing and fixing some issues. @rhtyd maybe good to keep it open until testing is finished, in case of any issues?

@yadvryadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested against a non-vapp feature backend (primate-qa server), was able to deploy VM.

@yadvr
yadvr merged commit b690814 into apache:masterAug 17, 2020
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
Support for vApp VM deployment for VMware
Backend PR - apache/cloudstack#4250
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: nvazquez <nicovazquez90@gmail.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr@blueorangutan@DaanHoogland@nvazquez@yadvr