Skip to content

[VMware] OVF Full properties support - #4250

Closed
nvazquez wants to merge 1 commit into
apache:masterfrom
shapeblue:ovfprops-full
Closed

[VMware] OVF Full properties support#4250
nvazquez wants to merge 1 commit into
apache:masterfrom
shapeblue:ovfprops-full

Conversation

@nvazquez

@nvazqueznvazquez commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

Description

Primate UI changes: apache/cloudstack-primate#550

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@nvazquez

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1669

@nvazquez

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@nvazquez

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr

yadvr commented Aug 7, 2020

Copy link
Copy Markdown
Member

@nvazquez still many failures in travis/simulator hinting at general regressions

@yadvryadvr added the Severity:Critical Critical bug label Aug 7, 2020
@yadvr

yadvr commented Aug 7, 2020

Copy link
Copy Markdown
Member

@nvazquez I triaged the issues for simulator/Travis, they are limited to test_vm_life_cycle and test_reset_vm_on_reboot failures now.

  1. For the test_vm_life_cycle the following tests fail:
=== TestName: test_01_unmanage_vm_cycle | Status : EXCEPTION ===

Error log: (we probably should skip test/setup if hypervisor is not vmware?)

ERROR: test suite for <class 'integration.smoke.test_vm_life_cycle.TestVAppsVM'> ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 209, in run self.setUp() File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 315, in setupContext
try_run(context, names) File "/usr/local/lib/python2.7/dist-packages/nose/util.py", line 471, in try_run return func() File "/home/rohit/lab/apache/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 1696, in setUpClass
assert False, "get_test_ovf_templates() failed to return templates" AssertionError: get_test_ovf_templates() failed to return templates 

...

2020-08-07 14:28:20,461 - DEBUG - ========Sending GET Cmd : createEgressFirewallRule=======
2020-08-07 14:28:20,484 - ERROR - Exception:['Traceback (most recent call last):\n', ' File "/usr/local/lib/python2.7/dist-packages/marvin/cloudstackConnection.py", line 308, in __parseAndGetResponse\n response_cls)\n', ' File "/usr/local/lib/python2.7/dist-packages/marvin/jsonHelper.py", line 156, in getResultObj\n raise cloudstackException.CloudstackAPIException(respname, errMsg)\n', 'CloudstackAPIException: Execute cmd: createegressfirewallrule failed, due to: errorCode: 537, errorText:There is already a firewall rule specified with protocol = all and no ports\n'] 
  1. For test_reset_vm_on_reboot failure, I checked against master looks like this is failing on master as well due to:
java.lang.NullPointerException
at com.cloud.vm.VirtualMachineManagerImpl.logBootModeParameters(VirtualMachineManagerImpl.java:1339)

I'll send a separate PR for this issue.

@yadvr

yadvr commented Aug 7, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1674

@yadvr

yadvr commented Aug 7, 2020

Copy link
Copy Markdown
Member

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@yadvr

yadvr commented Aug 7, 2020

Copy link
Copy Markdown
Member

@nvazquez I've fixed issue #27707d3f which was due to a fwd-merge I did yesterday

@yadvryadvr closed this Aug 7, 2020
@yadvryadvr reopened this Aug 7, 2020
@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2290)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44595 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2290-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_01_reset_vm_on_rebootError6.19test_reset_vm_on_reboot.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersError420.63test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsFailure148.04test_vpc_redundant.py

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2298)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49508 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2298-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 79 look OK, 4 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_3d_gpu_supportError302.48test_deploy_vgpu_enabled_vm.py
test_01_reset_vm_on_rebootError5.20test_reset_vm_on_reboot.py
test_11_migrate_vmError50.96test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLFailure487.90test_vpc_redundant.py

@nvazquez

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1678

@yadvr

yadvr commented Sep 1, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1862

@yadvr

yadvr commented Sep 1, 2020

Copy link
Copy Markdown
Member

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@nvazquez

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1880

@nvazquez

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

1 similar comment
@yadvr

yadvr commented Sep 3, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr

yadvr commented Sep 5, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1896

@yadvr

yadvr commented Sep 5, 2020

Copy link
Copy Markdown
Member

@blueorangutan test matrix

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2668)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53601 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2668-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 80 look OK, 1 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLFailure597.71test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsError3844.22test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsError3844.25test_vpc_redundant.py
test_05_rvpc_multi_tiersError0.02test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardownError0.03test_vpc_redundant.py

@nvazquez

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

1 similar comment
@yadvr

yadvr commented Sep 7, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@nvazqueznvazquez closed this Sep 7, 2020
@apacheapache deleted a comment from blueorangutanSep 15, 2020
@apacheapache deleted a comment from blueorangutanSep 15, 2020
weizhouapache pushed a commit to apache/cloudstack-primate that referenced this pull request Jan 19, 2021
Support for vApp VM deployment for VMware
Backend PR - apache/cloudstack#4250
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: nvazquez <nicovazquez90@gmail.com>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
Support for vApp VM deployment for VMware
Backend PR - #4250
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: nvazquez <nicovazquez90@gmail.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@sureshanapartisureshanaparti mentioned this pull request Jun 30, 2021
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nvazquez@blueorangutan@yadvr@shwstppr@andrijapanicsb