UI: Fixes in the Usage UI by bernardodemarco · Pull Request #10000 · apache/cloudstack

bernardodemarco · 2024-11-28T00:46:43Z

Description

This PR addresses the following issues related to the Usage UI:

Usage metrics section is displayed with null values to users without access to the listUsageServerMetrics API (FixesUsage server metrics section shown to users without access to the API #9992);
Purge usage records action is displayed to users without access to the removeRawUsageRecords API (FixesPurge usage records action shown to users without access to removeRawUsageRecords #9995);
Generate usage records action is displayed to users without access to the generateUsageRecords API (FixesGenerate usage records action shown to users without access to generateUsageRecords #9994);
Vertical scroll overflow in the usage records table (FixesPossible to scroll past the usage records table's footer #9996);
Usage types input field is displayed to users without access to the listUsageTypes API. Since the usageid parameter of the listUsageRecords API can only be used alongside the type parameter, both form fields are now hidden when the caller does not have access to the listUsageTypes API.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

Usage UI view when the user does not have access to the listUsageServerMetrics, removeRawUsageRecords, generateUsageRecords and listUsageTypes APIs

How Has This Been Tested?

Verified that users without access to the listUsageServerMetrics, removeRawUsageRecords, generateUsageRecords and listUsageTypes APIs were not able to interact with them through the UI.
Verified that the vertical overflow issue was resolved.

bernardodemarco · 2024-11-28T00:47:53Z

@blueorangutan ui

codecov · 2024-11-28T00:54:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.80%. Comparing base (c63c7ee) to head (fa9bfba).
Report is 37 commits behind head on 4.20.

Additional details and impacted files

@@ Coverage Diff @@## 4.20 #10000 +/- ##
============================================
- Coverage 15.80% 15.80% -0.01% + Complexity 12586 12585 -1 
============================================
Files 5627 5627 Lines 492343 492349 +6 Branches 59694 59696 +2 ============================================
- Hits 77828 77826 -2 - Misses 405992 405999 +7 - Partials 8523 8524 +1

Flag	Coverage Δ
uitests	`4.04% <ø> (-0.01%)`	⬇️
unittests	`16.62% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vishesh92 · 2024-11-28T07:30:51Z

@blueorangutan ui

blueorangutan · 2024-11-28T07:32:04Z

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-11-28T07:49:26Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10000 (QA-JID-488)

winterhazel

Looks good, verified in a local lab.

Just one thing: the last heartbeat may be undefined. We could show something like "never" instead of "null" for the last heartbeat for this case.

bernardodemarco · 2024-11-28T17:20:39Z

Just one thing: the last heartbeat may be undefined. We could show something like "never" instead of "null" for the last heartbeat for this case.

@winterhazel, done

winterhazel · 2024-11-28T17:54:39Z

Just one thing: the last heartbeat may be undefined. We could show something like "never" instead of "null" for the last heartbeat for this case.
@winterhazel, done

It would also be good to change the "a few seconds ago" in this case

bernardodemarco · 2024-11-28T18:10:54Z

It would also be good to change the "a few seconds ago" in this case

Done.

yadvr · 2024-11-29T07:32:39Z

@blueorangutan ui

blueorangutan · 2024-11-29T07:33:03Z

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-11-29T07:50:12Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10000 (QA-JID-490)

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

bernardodemarco · 2024-11-29T13:26:43Z

@blueorangutan ui

blueorangutan · 2024-11-29T13:28:03Z

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-11-29T13:45:52Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10000 (QA-JID-491)

* 4.20: VR: apply iptables rules when add/remove static routes (#10064) Certificate and VM hostname validation improvements (#10051) set ulimit for server according to redhat spec (#10040) kvm-storage: provide isVMMigrate information to storage plugins (#10093) Allow config drive deletion of migrated VM, on host maintenance (#10045) linstor: improve heartbeat check with also asking linstor (#10105) server: simplify role change validation (#9173) UI: create VPC network offering with conserve mode (#10082) server: fix typo removeaccessvpn in VirtualRouterElement (#10086) UI: remove duplicated Instance Name in Public IP details page (#10087) UI: Fixes in the Usage UI (#10000) SAML2: add cookie with HttpOnly too #10013 (#10047) ui: Allow font-awesome icon usage and optimise icon size inconsistency (#9744)

* fixes on usage ui * dont call API when caller does not have access to it * handle when lastheartbeat is undefined * hide last collection datetime when lastheartbeat is undefined * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> --------- Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

bernardodemarco added 2 commits November 27, 2024 21:09

fixes on usage ui
1c401e5

dont call API when caller does not have access to it
19f2835

boring-cyborgBot added the component:UI label Nov 28, 2024

bernardodemarco changed the base branch from main to 4.20November 28, 2024 00:47

bernardodemarco requested review from vishesh92 and winterhazel November 28, 2024 00:48

DaanHoogland added this to the 4.20.1 milestone Nov 28, 2024

winterhazel approved these changes Nov 28, 2024
View reviewed changes

handle when lastheartbeat is undefined
e216088

hide last collection datetime when lastheartbeat is undefined
ca68e52

yadvr approved these changes Nov 29, 2024
View reviewed changes

Pearl1594 reviewed Nov 29, 2024
View reviewed changes

Comment threadui/src/views/infra/UsageRecords.vue Outdated
Comment threadui/src/views/infra/UsageRecords.vue Outdated
Comment threadui/src/views/infra/UsageRecords.vue Outdated
Comment threadui/src/views/infra/UsageRecords.vue Outdated
Comment threadui/src/views/infra/UsageRecords.vue Outdated

bernardodemarcoand others added 5 commits November 29, 2024 10:25

apply Pearl's suggestions
56801b8
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

apply Pearl's suggestions
45788aa
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

apply Pearl's suggestions
2e35247
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

apply Pearl's suggestions
f235d34
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

apply Pearl's suggestions
fa9bfba
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

JoaoJandre merged commit e57a82a into apache:4.20Dec 9, 2024

Pearl1594 added this to ACS 4.20.1 Mar 17, 2025

Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025

Uh oh!

Conversation

bernardodemarco commented Nov 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

bernardodemarco commented Nov 28, 2024

Uh oh!

codecovBot commented Nov 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vishesh92 commented Nov 28, 2024

Uh oh!

blueorangutan commented Nov 28, 2024

Uh oh!

blueorangutan commented Nov 28, 2024

Uh oh!

winterhazel left a comment

Choose a reason for hiding this comment

Uh oh!

bernardodemarco commented Nov 28, 2024

Uh oh!

winterhazel commented Nov 28, 2024

Uh oh!

bernardodemarco commented Nov 28, 2024

Uh oh!

yadvr commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bernardodemarco commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bernardodemarco commented Nov 28, 2024•
edited
Loading

codecovBot commented Nov 28, 2024•
edited
Loading