Skip to content

server: fix typo removeaccessvpn in VirtualRouterElement - #10086

Merged
DaanHoogland merged 1 commit into
apache:4.19from
weizhouapache:4.19-fix-typo-removeaccessvpn
Dec 13, 2024
Merged

server: fix typo removeaccessvpn in VirtualRouterElement#10086
DaanHoogland merged 1 commit into
apache:4.19from
weizhouapache:4.19-fix-typo-removeaccessvpn

Conversation

@weizhouapache

@weizhouapacheweizhouapache commented Dec 11, 2024

Copy link
Copy Markdown
Member

Description

This PR fixes the typo removeaccessvpn which should be remoteaccessvpn

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapacheweizhouapache mentioned this pull request Dec 11, 2024
Closed
@weizhouapacheweizhouapache added this to the 4.19.2 milestone Dec 11, 2024
@DaanHoogland

DaanHoogland commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

VirtualRouterElement can actually do with some extra clean up in addition to this.

@codecov

codecovBot commented Dec 11, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.12%. Comparing base (f9b1767) to head (a204597).
Report is 2 commits behind head on 4.19.

Additional details and impacted files
@@ Coverage Diff @@## 4.19 #10086 +/- ##
============================================
- Coverage 15.12% 15.12% -0.01% + Complexity 11261 11257 -4 
============================================
Files 5408 5408 Lines 473843 473843 Branches 57771 57771 ============================================
- Hits 71688 71672 -16 - Misses 394156 394175 +19 + Partials 7999 7996 -3
FlagCoverage Δ
uitests4.30% <ø> (ø)
unittests15.84% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan

blueorangutan commented Dec 12, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11790

@DaanHoogland

DaanHoogland commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Dec 12, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Dec 13, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-11894)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45487 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10086-t11894-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File

@DaanHoogland

DaanHoogland commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

Can we do any other testing on this @weizhouapache , it seems to me this would be good enough.

@weizhouapache

weizhouapache commented Dec 13, 2024

Copy link
Copy Markdown
MemberAuthor

Can we do any other testing on this @weizhouapache , it seems to me this would be good enough.

@DaanHoogland
I think no more testing is needed. it is just a typo
I cannot find it is being used somewhere

@DaanHoogland
DaanHoogland merged commit a278849 into apache:4.19Dec 13, 2024
@DaanHoogland
DaanHoogland deleted the 4.19-fix-typo-removeaccessvpn branch December 13, 2024 08:10
DaanHoogland added a commit that referenced this pull request Dec 20, 2024
@DaanHoogland
Merge release branch 4.20 to main
9295a16
* 4.20:
VR: apply iptables rules when add/remove static routes (#10064)
Certificate and VM hostname validation improvements (#10051)
set ulimit for server according to redhat spec (#10040)
kvm-storage: provide isVMMigrate information to storage plugins (#10093)
Allow config drive deletion of migrated VM, on host maintenance (#10045)
linstor: improve heartbeat check with also asking linstor (#10105)
server: simplify role change validation (#9173)
UI: create VPC network offering with conserve mode (#10082)
server: fix typo removeaccessvpn in VirtualRouterElement (#10086)
UI: remove duplicated Instance Name in Public IP details page (#10087)
UI: Fixes in the Usage UI (#10000)
SAML2: add cookie with HttpOnly too #10013 (#10047)
ui: Allow font-awesome icon usage and optimise icon size inconsistency (#9744)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 26, 2024
@weizhouapache@dhslove
server: fix typo removeaccessvpn in VirtualRouterElement (apache#10086)
0c230ad
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHooglandDaanHooglandDaanHoogland approved these changes
@JoaoJandreJoaoJandreJoaoJandre approved these changes

Assignees

No one assigned

Labels

component:networking

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache@DaanHoogland@blueorangutan@JoaoJandre