Skip to content

Fix NPE on updating security groups for an instance - #10493

Merged
Pearl1594 merged 3 commits into
apache:4.20from
shapeblue:fixup-update-security
Apr 22, 2025
Merged

Fix NPE on updating security groups for an instance#10493
Pearl1594 merged 3 commits into
apache:4.20from
shapeblue:fixup-update-security

Conversation

@vishesh92

@vishesh92vishesh92 commented Mar 3, 2025

Copy link
Copy Markdown
Member

Description

This PR fixes#10347

Details

This pull request includes changes to the UserVmManagerImpl class and UI components to improve the handling of security groups for virtual machines. The most important changes include refactoring the security group update logic and adding UI support for security groups.

Backend changes:

UI changes:

  • ui/src/views/compute/EditVM.vue: Modified the security group enablement check to fall back on a Vuex store getter if the zone response does not provide the information. This ensures that the UI correctly reflects the security group support status.
  • ui/src/views/compute/InstanceTab.vue: Added a new state variable showUpdateSecurityGroupsModal to manage the visibility of the security group update modal in the instance tab. This prepares the UI for future enhancements to support security group updates directly from the instance tab.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • [ x] Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecovBot commented Mar 3, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 29.03226% with 22 lines in your changes missing coverage. Please review.

Project coverage is 16.02%. Comparing base (b92fd17) to head (3ca9b61).
Report is 77 commits behind head on 4.20.

Files with missing linesPatch %Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java29.03%16 Missing and 6 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## 4.20 #10493 +/- ##
============================================
+ Coverage 15.98% 16.02% +0.03% - Complexity 13086 13123 +37 
============================================
Files 5650 5652 +2 Lines 495756 495928 +172 Branches 60018 60051 +33 ============================================
+ Hits 79261 79454 +193 + Misses 407641 407609 -32 - Partials 8854 8865 +11
FlagCoverage Δ
uitests4.00% <ø> (-0.01%)⬇️
unittests16.86% <29.03%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishesh92
vishesh92force-pushed the fixup-update-security branch from 1a1eec2 to 351b012CompareMarch 3, 2025 19:18
@vishesh92

vishesh92 commented Mar 3, 2025

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@apacheapache deleted a comment from blueorangutanMar 3, 2025
@blueorangutan

blueorangutan commented Mar 3, 2025

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache
weizhouapache reviewed Mar 3, 2025
View reviewed changes
Comment threadserver/src/main/java/com/cloud/vm/UserVmManagerImpl.java
@blueorangutan

blueorangutan commented Mar 3, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12641

@vishesh92

vishesh92 commented Mar 4, 2025

Copy link
Copy Markdown
MemberAuthor

@blueorangutan test keepEnv

@blueorangutan

blueorangutan commented Mar 4, 2025

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Mar 4, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-12545)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 59242 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10493-t12545-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
test_06_purge_expunged_vm_background_taskFailure394.83test_purge_expunged_vms.py

@Pearl1594Pearl1594 linked an issue Mar 5, 2025 that may be closed by this pull request
Unable to update the security groups of a VM #10347
Closed
@vishesh92
vishesh92 marked this pull request as ready for review March 11, 2025 19:15
@DaanHooglandDaanHoogland added this to the 4.20.1 milestone Mar 29, 2025
JoaoJandre
JoaoJandre reviewed Apr 9, 2025
View reviewed changes
Comment threadserver/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated
Comment threadserver/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated
Comment threadserver/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated
@harikrishna-patnala

harikrishna-patnala commented Apr 16, 2025

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Apr 16, 2025

Copy link
Copy Markdown

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland
DaanHoogland reviewed Apr 16, 2025
View reviewed changes
Comment threadserver/src/main/java/com/cloud/vm/UserVmManagerImpl.java
@weizhouapacheweizhouapache mentioned this pull request Apr 16, 2025
Merged
14 tasks
@blueorangutan

blueorangutan commented Apr 16, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13068

DaanHoogland
DaanHoogland approved these changes Apr 16, 2025
View reviewed changes

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

harikrishna-patnala
harikrishna-patnala approved these changes Apr 17, 2025
View reviewed changes

@harikrishna-patnalaharikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced the issue and also verified the fix, did not observe the NPE after updating SG. LGTM.

@harikrishna-patnala

harikrishna-patnala commented Apr 17, 2025

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Apr 17, 2025

Copy link
Copy Markdown

@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Apr 17, 2025

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-13026)

@weizhouapache

weizhouapache commented Apr 17, 2025

Copy link
Copy Markdown
Member

@blueorangutan test securityGroups

@blueorangutan

blueorangutan commented Apr 17, 2025

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Apr 18, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-13031)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 87121 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10493-t13031-kvm-ol8.zip
Smoke tests completed. 51 look OK, 90 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
ContextSuite context=TestRemoteDiagnostics>:setupError0.00test_diagnostics.py
test_01_deploy_vm_from_direct_download_template_nfs_storageError5.55test_direct_download.py
ContextSuite context=TestDirectDownloadTemplates>:teardownError1.10test_direct_download.py
ContextSuite context=TestAddVmToSubDomain>:setupError18.72test_accounts.py
test_DeleteDomainError13.08test_accounts.py
test_forceDeleteDomainFailure12.95test_accounts.py
test_01_user_remove_VM_runningError0.81test_accounts.py
test_DeployVmAntiAffinityGroup_in_projectError0.06test_affinity_groups_projects.py
test_DeployVmAffinityGroupError0.04test_affinity_groups.py
test_DeployVmAntiAffinityGroupError0.06test_affinity_groups.py
test_01_events_resourceError7.43test_events_resource.py
ContextSuite context=TestAnnotations>:setupError0.00test_annotations.py
test_query_async_job_resultError6.34test_async_job.py
test_replace_acl_of_networkError1.57test_global_acls.py
ContextSuite context=TestMultipleVolumeAttach>:setupError0.00test_attach_multiple_volumes.py
test_dedicateGuestVlanRangeError0.00test_guest_vlan_range.py
ContextSuite context=TestDedicateGuestVlanRange>:teardownError0.01test_guest_vlan_range.py
test_01_condensed_drs_algorithmError2.32test_cluster_drs.py
test_02_balanced_drs_algorithmError0.09test_cluster_drs.py
ContextSuite context=TestClusterDRS>:teardownError1.29test_cluster_drs.py
ContextSuite context=TestConsoleEndpoint>:setupError0.00test_console_endpoint.py
test_deployvm_userdataError0.13test_deploy_vm_with_userdata.py
test_deployvm_userdata_postError0.11test_deploy_vm_with_userdata.py
ContextSuite context=TestDeployVirtioSCSIVM>:setupError0.00test_deploy_virtio_scsi_vm.py
test_01_deploy_vm_with_extraconfig_throws_exception_kvmError0.23test_deploy_vm_extra_config_data.py
test_02_deploy_vm_with_extraconfig_kvmError0.17test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvmError0.17test_deploy_vm_extra_config_data.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Failure4.99test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Failure2.96test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesFailure3.83test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesFailure2.92test_internal_lb.py
test_deploy_vm_from_isoError12.11test_deploy_vm_iso.py
test_01_deploy_vm_from_iso_uefi_secureError0.05test_deploy_vm_iso_uefi.py
test_02_deploy_vm_from_iso_uefi_legacyError0.05test_deploy_vm_iso_uefi.py
test_03_deploy_windows_vm_from_iso_uefi_legacyError0.05test_deploy_vm_iso_uefi.py
test_04_deploy_windows_vm_from_iso_uefi_secureError0.05test_deploy_vm_iso_uefi.py
test_02_create_network_routed_mode_with_specified_cidrError0.08test_ipv4_routing.py
test_04_create_isolated_network_routed_mode_with_cidrsizeError0.06test_ipv4_routing.py
test_06_isolated_network_with_routed_modeError0.07test_ipv4_routing.py
test_07_vpc_and_tier_with_routed_modeError2.40test_ipv4_routing.py
test_11_isolated_network_with_dynamic_routed_modeError2.28test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_modeError8.01test_ipv4_routing.py
test_00_deploy_vm_root_resizeError0.09test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeFailure0.04test_deploy_vm_root_resize.py
test_02_deploy_vm_root_resizeFailure0.04test_deploy_vm_root_resize.py
test_deploy_more_vms_than_limit_allowsError6.45test_deploy_vms_in_parallel.py
test_01_create_ipv6_public_ip_rangeError0.04test_ipv6_infra.py
test_deployvm_firstfitError0.10test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedError0.10test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersingError0.10test_deploy_vms_with_varied_deploymentplanners.py
test_03_create_network_domain_network_offeringError14.26test_domain_network_offerings.py
test_03_deploy_vm_domain_service_offeringError16.05test_domain_service_offerings.py
test_03_create_vpc_domain_vpc_offeringError16.26test_domain_vpc_offerings.py
ContextSuite context=TestHostControlState>:setupError53.26test_host_control_state.py
ContextSuite context=TestImportAndUnmanageVolumes>:setupError0.00test_import_unmanage_volumes.py
test_10_vpc_tier_kubernetes_clusterError3.79test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycleError2.42test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setupError0.00test_list_ids_parameter.py
ContextSuite context=TestListVolumes>:setupError0.00test_list_volumes.py
ContextSuite context=TestLoadBalance>:setupError0.00test_loadbalance.py
test_list_vms_metrics_adminError0.28test_metrics_api.py
test_list_vms_metrics_historyError0.22test_metrics_api.py
test_list_vms_metrics_userError0.30test_metrics_api.py
test_list_volumes_metrics_historyError0.24test_metrics_api.py
test_01_native_to_native_network_migrationError6.90test_migration.py
test_02_native_to_native_vpc_migrationError9.85test_migration.py
test_nic_secondaryip_add_removeError20.83test_multipleips_per_nic.py
test_network_aclError2.43test_network_acl.py
ContextSuite context=TestIpv6Network>:setupError0.00test_network_ipv6.py
test_01_add_primary_storage_disabled_hostError37.46test_primary_storage.py
test_01_primary_storage_nfsError0.25test_primary_storage.py
ContextSuite context=TestStorageTags>:setupError0.39test_primary_storage.py
ContextSuite context=TestNetworkPermissions>:setupError0.00test_network_permissions.py
test_delete_accountError21.29test_network.py
test_delete_network_while_vm_on_itError8.80test_network.py
test_delete_network_while_vm_on_itError8.81test_network.py
test_deploy_vm_l2networkError6.65test_network.py
test_deploy_vm_l2networkError6.65test_network.py
test_l2network_restartError7.97test_network.py
test_l2network_restartError7.98test_network.py
ContextSuite context=TestL2Networks>:teardownError9.10test_network.py
ContextSuite context=TestPortForwarding>:setupError15.06test_network.py
ContextSuite context=TestPublicIP>:setupError11.34test_network.py
test_reboot_routerError6.58test_network.py
test_releaseIPError6.03test_network.py
test_releaseIP_using_IPError5.58test_network.py
ContextSuite context=TestRouterRules>:setupError11.87test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setupError50.81test_network.py
test_01_nicError47.25test_nic.py
test_extendPhysicalNetworkVlanError0.05test_non_contigiousvlan.py
test_01_create_delete_portforwarding_fornonvpcError6.12test_portforwardingrules.py
ContextSuite context=TestNonStrictAffinityGroups>:setupError0.00test_nonstrict_affinity_group.py
test_01_vpc_privategw_aclFailure8.36test_privategw_acl.py
test_02_vpc_privategw_static_routesFailure8.16test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure8.27test_privategw_acl.py
test_04_rvpc_privategw_static_routesFailure8.59test_privategw_acl.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setupError0.00test_password_server.py
test_01_isolated_persistent_networkError0.08test_persistent_network.py
ContextSuite context=TestPortablePublicIPAcquire>:setupError0.00test_portable_publicip.py
test_01_primary_storage_scope_changeError0.15test_primary_storage_scope.py
test_09_project_suspendError1.17test_projects.py
test_10_project_activationError1.15test_projects.py
test_dedicatePublicIpRangeError0.03test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vmsError0.04test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_01_ssvmError0.12test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_02_cpvmError0.14test_public_ip_range.py
ContextSuite context=TestPurgeExpungedVms>:setupError0.00test_purge_expunged_vms.py
test_create_pvlan_networkError0.12test_pvlan.py
test_another_user_can_allocate_ip_after_quarantined_has_ended_networkError9.15test_quarantined_ips.py
test_another_user_can_allocate_ip_after_quarantined_has_ended_vpcError0.43test_quarantined_ips.py
test_only_owner_can_allocate_ip_in_quarantine_networkError0.37test_quarantined_ips.py
test_only_owner_can_allocate_ip_in_quarantine_vpcError0.44test_quarantined_ips.py
test_CRUD_operations_userdataError1523.79test_register_userdata.py
test_deploy_vm_with_registered_userdataError5.46test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allowError5.64test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_appendError5.31test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_denyError4.99test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_paramsError5.36test_register_userdata.py
test_link_and_unlink_userdata_to_templateError4.82test_register_userdata.py
test_user_userdata_crudError4.69test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setupError0.00test_reset_vm_on_reboot.py
ContextSuite context=TestVMSchedule>:setupError0.00test_vm_schedule.py
ContextSuite context=TestRAMCPUResourceAccounting>:setupError0.00test_resource_accounting.py
ContextSuite context=TestResourceNames>:setupError0.00test_resource_names.py
ContextSuite context=TestRestoreVM>:setupError0.00test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setupError0.00test_router_dns.py
ContextSuite context=TestVmSnapshot>:setupError5.38test_vm_snapshots.py
ContextSuite context=TestRouterDnsService>:setupError0.00test_router_dnsservice.py
test_01_deploy_vm_on_specific_hostError0.10test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_clusterError0.08test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_podError0.11test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_clusterError0.13test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_podError0.10test_vm_deployment_planner.py
ContextSuite context=TestRouterIpTablesPolicies>:setupError0.00test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setupError0.00test_routers_iptables_default_policy.py
ContextSuite context=TestDeployVM>:setupError0.00test_vm_life_cycle.py
test_01_migrate_VM_and_root_volumeError0.08test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disksError0.08test_vm_life_cycle.py
test_01_secure_vm_migrationError77.30test_vm_life_cycle.py
test_02_unsecure_vm_migrationError220.71test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migrationError149.00test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migrationError146.91test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setupError5.07test_vm_life_cycle.py
ContextSuite context=TestIsolatedNetworks>:setupError0.00test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setupError0.00test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setupError0.00test_routers.py
test_01_sys_vm_startFailure0.23test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setupError0.00test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setupError0.26test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setupError0.00test_set_sourcenat.py
ContextSuite context=TestSharedFSLifecycle>:setupError0.00test_sharedfs_lifecycle.py
ContextSuite context=TestIpv6Vpc>:setupError0.00test_vpc_ipv6.py
ContextSuite context=TestSnapshotRootDisk>:setupError0.00test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setupError0.00test_snapshots.py
test_01_list_sec_storage_vmFailure0.05test_ssvm.py
test_02_list_cpvm_vmFailure0.04test_ssvm.py
test_03_ssvm_internalsFailure0.04test_ssvm.py
test_04_cpvm_internalsFailure0.04test_ssvm.py
test_05_stop_ssvmFailure0.04test_ssvm.py
test_06_stop_cpvmFailure0.05test_ssvm.py
test_07_reboot_ssvmFailure0.05test_ssvm.py
test_08_reboot_cpvmFailure0.05test_ssvm.py
test_09_reboot_ssvm_forcedFailure0.04test_ssvm.py
test_10_reboot_cpvm_forcedFailure0.04test_ssvm.py
test_11_destroy_ssvmFailure0.05test_ssvm.py
test_12_destroy_cpvmFailure0.05test_ssvm.py
test_01_register_vnf_templateError0.07test_vnf_templates.py
test_02_list_vnf_templateError0.06test_vnf_templates.py
test_03_edit_vnf_templateError0.06test_vnf_templates.py
test_04_deploy_vnf_applianceError0.06test_vnf_templates.py
test_05_delete_vnf_templateError0.07test_vnf_templates.py
ContextSuite context=TestVMWareStoragePolicies>:setupError0.00test_storage_policy.py
test_02_create_template_with_checksum_sha1Error65.68test_templates.py
test_03_create_template_with_checksum_sha256Error65.67test_templates.py
test_04_create_template_with_checksum_md5Error65.71test_templates.py
test_05_create_template_with_no_checksumError65.69test_templates.py
test_02_deploy_vm_from_direct_download_templateError0.05test_templates.py
ContextSuite context=TestTemplates>:setupError14.88test_templates.py
test_01_positive_tests_usageFailure5.94test_usage_events.py
ContextSuite context=TestCreateVolume>:setupError0.00test_volumes.py
test_01_root_volume_encryptionError0.07test_volumes.py
test_02_data_volume_encryptionError0.06test_volumes.py
test_03_root_and_data_volume_encryptionError0.08test_volumes.py
ContextSuite context=TestVolumes>:setupError7.22test_volumes.py
ContextSuite context=TestISOUsage>:setupError0.00test_usage.py
ContextSuite context=TestLBRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestNatRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestPublicIPUsage>:setupError0.00test_usage.py
ContextSuite context=TestSnapshotUsage>:setupError0.00test_usage.py
ContextSuite context=TestVmUsage>:setupError0.00test_usage.py
ContextSuite context=TestVolumeUsage>:setupError0.00test_usage.py
ContextSuite context=TestVpnUsage>:setupError0.00test_usage.py
ContextSuite context=TestVmAutoScaling>:setupError0.00test_vm_autoscaling.py
ContextSuite context=TestMigrateVMStrictTags>:setupError0.00test_vm_strict_host_tags.py
ContextSuite context=TestRestoreVMStrictTags>:setupError0.00test_vm_strict_host_tags.py
ContextSuite context=TestScaleVMStrictTags>:setupError0.00test_vm_strict_host_tags.py
ContextSuite context=TestVMDeploymentPlannerStrictTags>:setupError0.00test_vm_strict_host_tags.py
ContextSuite context=TestVPCRedundancy>:setupError0.00test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setupError0.00test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setupError0.00test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobsError1.67test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failureError1.74test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connectedFailure12.61test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connectedFailure21.70test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnectedFailure29.30test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:teardownError30.45test_host_maintenance.py
test_disable_oobm_ha_state_ineligibleError1517.99test_hostha_kvm.py

@DaanHoogland

DaanHoogland commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

51 ok 90 errors, I forgot what the baseline was for running with security groups . maybe we should add it to the matrix somehow (and stablise it)

@weizhouapache

weizhouapache commented Apr 18, 2025

Copy link
Copy Markdown
Member

@DaanHoogland
agree we need to stablize the tests on SG zone

let's re-run the tests to see if the results are consistent

@blueorangutan test securityGroups

@blueorangutan

blueorangutan commented Apr 18, 2025

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Apr 19, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-13052)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 86748 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10493-t13052-kvm-ol8.zip
Smoke tests completed. 51 look OK, 90 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
ContextSuite context=TestRemoteDiagnostics>:setupError0.00test_diagnostics.py
test_01_deploy_vm_from_direct_download_template_nfs_storageError7.56test_direct_download.py
ContextSuite context=TestDirectDownloadTemplates>:teardownError1.09test_direct_download.py
ContextSuite context=TestAddVmToSubDomain>:setupError20.77test_accounts.py
test_DeleteDomainError15.86test_accounts.py
test_forceDeleteDomainFailure14.65test_accounts.py
test_01_user_remove_VM_runningError0.82test_accounts.py
test_DeployVmAntiAffinityGroup_in_projectError0.04test_affinity_groups_projects.py
test_DeployVmAffinityGroupError0.04test_affinity_groups.py
test_DeployVmAntiAffinityGroupError0.05test_affinity_groups.py
test_01_events_resourceError8.03test_events_resource.py
ContextSuite context=TestAnnotations>:setupError0.00test_annotations.py
test_query_async_job_resultError6.61test_async_job.py
test_replace_acl_of_networkError1.56test_global_acls.py
ContextSuite context=TestMultipleVolumeAttach>:setupError0.00test_attach_multiple_volumes.py
test_dedicateGuestVlanRangeError0.00test_guest_vlan_range.py
ContextSuite context=TestDedicateGuestVlanRange>:teardownError0.00test_guest_vlan_range.py
test_01_condensed_drs_algorithmError4.36test_cluster_drs.py
test_02_balanced_drs_algorithmError0.09test_cluster_drs.py
ContextSuite context=TestClusterDRS>:teardownError1.20test_cluster_drs.py
ContextSuite context=TestConsoleEndpoint>:setupError0.00test_console_endpoint.py
test_deployvm_userdataError0.08test_deploy_vm_with_userdata.py
test_deployvm_userdata_postError0.07test_deploy_vm_with_userdata.py
ContextSuite context=TestDeployVirtioSCSIVM>:setupError0.00test_deploy_virtio_scsi_vm.py
test_01_deploy_vm_with_extraconfig_throws_exception_kvmError0.16test_deploy_vm_extra_config_data.py
test_02_deploy_vm_with_extraconfig_kvmError0.12test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvmError0.12test_deploy_vm_extra_config_data.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Failure4.89test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Failure4.79test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesFailure2.71test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesFailure3.77test_internal_lb.py
test_deploy_vm_from_isoError11.38test_deploy_vm_iso.py
test_01_deploy_vm_from_iso_uefi_secureError0.05test_deploy_vm_iso_uefi.py
test_02_deploy_vm_from_iso_uefi_legacyError0.05test_deploy_vm_iso_uefi.py
test_03_deploy_windows_vm_from_iso_uefi_legacyError0.04test_deploy_vm_iso_uefi.py
test_04_deploy_windows_vm_from_iso_uefi_secureError0.04test_deploy_vm_iso_uefi.py
test_02_create_network_routed_mode_with_specified_cidrError0.07test_ipv4_routing.py
test_04_create_isolated_network_routed_mode_with_cidrsizeError0.07test_ipv4_routing.py
test_06_isolated_network_with_routed_modeError0.06test_ipv4_routing.py
test_07_vpc_and_tier_with_routed_modeError2.37test_ipv4_routing.py
test_11_isolated_network_with_dynamic_routed_modeError1.25test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_modeError7.94test_ipv4_routing.py
test_00_deploy_vm_root_resizeError0.08test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeFailure0.04test_deploy_vm_root_resize.py
test_02_deploy_vm_root_resizeFailure0.04test_deploy_vm_root_resize.py
test_deploy_more_vms_than_limit_allowsError5.38test_deploy_vms_in_parallel.py
test_01_create_ipv6_public_ip_rangeError0.04test_ipv6_infra.py
test_deployvm_firstfitError0.09test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedError0.07test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersingError0.07test_deploy_vms_with_varied_deploymentplanners.py
test_03_create_network_domain_network_offeringError12.95test_domain_network_offerings.py
test_03_deploy_vm_domain_service_offeringError12.05test_domain_service_offerings.py
test_03_create_vpc_domain_vpc_offeringError13.20test_domain_vpc_offerings.py
ContextSuite context=TestHostControlState>:setupError52.66test_host_control_state.py
ContextSuite context=TestImportAndUnmanageVolumes>:setupError0.00test_import_unmanage_volumes.py
test_10_vpc_tier_kubernetes_clusterError3.59test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycleError3.39test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setupError0.00test_list_ids_parameter.py
ContextSuite context=TestListVolumes>:setupError0.00test_list_volumes.py
ContextSuite context=TestLoadBalance>:setupError0.00test_loadbalance.py
test_list_vms_metrics_adminError0.27test_metrics_api.py
test_list_vms_metrics_historyError0.24test_metrics_api.py
test_list_vms_metrics_userError0.27test_metrics_api.py
test_list_volumes_metrics_historyError0.23test_metrics_api.py
test_01_native_to_native_network_migrationError6.57test_migration.py
test_02_native_to_native_vpc_migrationError9.68test_migration.py
test_nic_secondaryip_add_removeError20.91test_multipleips_per_nic.py
test_network_aclError2.78test_network_acl.py
ContextSuite context=TestIpv6Network>:setupError0.00test_network_ipv6.py
test_01_add_primary_storage_disabled_hostError37.81test_primary_storage.py
test_01_primary_storage_nfsError0.20test_primary_storage.py
ContextSuite context=TestStorageTags>:setupError0.35test_primary_storage.py
ContextSuite context=TestNetworkPermissions>:setupError0.00test_network_permissions.py
test_delete_accountError21.33test_network.py
test_delete_network_while_vm_on_itError9.63test_network.py
test_delete_network_while_vm_on_itError9.64test_network.py
test_deploy_vm_l2networkError6.64test_network.py
test_deploy_vm_l2networkError6.64test_network.py
test_l2network_restartError9.82test_network.py
test_l2network_restartError9.82test_network.py
ContextSuite context=TestL2Networks>:teardownError10.96test_network.py
ContextSuite context=TestPortForwarding>:setupError17.56test_network.py
ContextSuite context=TestPublicIP>:setupError10.14test_network.py
test_reboot_routerError5.32test_network.py
test_releaseIPError5.21test_network.py
test_releaseIP_using_IPError5.47test_network.py
ContextSuite context=TestRouterRules>:setupError11.00test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setupError60.76test_network.py
test_01_nicError46.94test_nic.py
test_extendPhysicalNetworkVlanError0.06test_non_contigiousvlan.py
test_01_create_delete_portforwarding_fornonvpcError5.23test_portforwardingrules.py
ContextSuite context=TestNonStrictAffinityGroups>:setupError0.00test_nonstrict_affinity_group.py
test_01_vpc_privategw_aclFailure8.04test_privategw_acl.py
test_02_vpc_privategw_static_routesFailure8.00test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure8.11test_privategw_acl.py
test_04_rvpc_privategw_static_routesFailure8.17test_privategw_acl.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setupError0.00test_password_server.py
test_01_isolated_persistent_networkError0.05test_persistent_network.py
ContextSuite context=TestPortablePublicIPAcquire>:setupError0.00test_portable_publicip.py
test_01_primary_storage_scope_changeError0.14test_primary_storage_scope.py
test_09_project_suspendError1.16test_projects.py
test_10_project_activationError1.15test_projects.py
test_dedicatePublicIpRangeError0.03test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vmsError0.03test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_01_ssvmError0.11test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_02_cpvmError0.10test_public_ip_range.py
ContextSuite context=TestPurgeExpungedVms>:setupError0.00test_purge_expunged_vms.py
test_create_pvlan_networkError0.08test_pvlan.py
test_another_user_can_allocate_ip_after_quarantined_has_ended_networkError8.39test_quarantined_ips.py
test_another_user_can_allocate_ip_after_quarantined_has_ended_vpcError0.39test_quarantined_ips.py
test_only_owner_can_allocate_ip_in_quarantine_networkError0.36test_quarantined_ips.py
test_only_owner_can_allocate_ip_in_quarantine_vpcError0.42test_quarantined_ips.py
test_CRUD_operations_userdataError1522.78test_register_userdata.py
test_deploy_vm_with_registered_userdataError5.39test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allowError5.37test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_appendError5.70test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_denyError6.08test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_paramsError5.43test_register_userdata.py
test_link_and_unlink_userdata_to_templateError5.46test_register_userdata.py
test_user_userdata_crudError5.09test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setupError0.00test_reset_vm_on_reboot.py
ContextSuite context=TestVMSchedule>:setupError0.00test_vm_schedule.py
ContextSuite context=TestRAMCPUResourceAccounting>:setupError0.00test_resource_accounting.py
ContextSuite context=TestResourceNames>:setupError0.00test_resource_names.py
ContextSuite context=TestRestoreVM>:setupError0.00test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setupError0.00test_router_dns.py
ContextSuite context=TestVmSnapshot>:setupError4.53test_vm_snapshots.py
ContextSuite context=TestRouterDnsService>:setupError0.00test_router_dnsservice.py
test_01_deploy_vm_on_specific_hostError0.10test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_clusterError0.07test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_podError0.11test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_clusterError0.13test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_podError0.09test_vm_deployment_planner.py
ContextSuite context=TestRouterIpTablesPolicies>:setupError0.00test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setupError0.00test_routers_iptables_default_policy.py
ContextSuite context=TestDeployVM>:setupError0.00test_vm_life_cycle.py
test_01_migrate_VM_and_root_volumeError0.07test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disksError0.06test_vm_life_cycle.py
test_01_secure_vm_migrationError75.08test_vm_life_cycle.py
test_02_unsecure_vm_migrationError218.58test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migrationError147.84test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migrationError146.81test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setupError4.93test_vm_life_cycle.py
ContextSuite context=TestIsolatedNetworks>:setupError0.00test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setupError0.00test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setupError0.00test_routers.py
test_01_sys_vm_startFailure0.19test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setupError0.00test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setupError0.30test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setupError0.00test_set_sourcenat.py
ContextSuite context=TestSharedFSLifecycle>:setupError0.00test_sharedfs_lifecycle.py
ContextSuite context=TestIpv6Vpc>:setupError0.00test_vpc_ipv6.py
ContextSuite context=TestSnapshotRootDisk>:setupError0.00test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setupError0.00test_snapshots.py
test_01_list_sec_storage_vmFailure0.05test_ssvm.py
test_02_list_cpvm_vmFailure0.04test_ssvm.py
test_03_ssvm_internalsFailure0.05test_ssvm.py
test_04_cpvm_internalsFailure0.04test_ssvm.py
test_05_stop_ssvmFailure0.04test_ssvm.py
test_06_stop_cpvmFailure0.04test_ssvm.py
test_07_reboot_ssvmFailure0.05test_ssvm.py
test_08_reboot_cpvmFailure0.04test_ssvm.py
test_09_reboot_ssvm_forcedFailure0.04test_ssvm.py
test_10_reboot_cpvm_forcedFailure0.05test_ssvm.py
test_11_destroy_ssvmFailure0.04test_ssvm.py
test_12_destroy_cpvmFailure0.04test_ssvm.py
test_01_register_vnf_templateError0.06test_vnf_templates.py
test_02_list_vnf_templateError0.07test_vnf_templates.py
test_03_edit_vnf_templateError0.05test_vnf_templates.py
test_04_deploy_vnf_applianceError0.05test_vnf_templates.py
test_05_delete_vnf_templateError0.05test_vnf_templates.py
ContextSuite context=TestVMWareStoragePolicies>:setupError0.00test_storage_policy.py
test_02_create_template_with_checksum_sha1Error65.61test_templates.py
test_03_create_template_with_checksum_sha256Error65.59test_templates.py
test_04_create_template_with_checksum_md5Error65.63test_templates.py
test_05_create_template_with_no_checksumError65.63test_templates.py
test_02_deploy_vm_from_direct_download_templateError0.04test_templates.py
ContextSuite context=TestTemplates>:setupError14.71test_templates.py
test_01_positive_tests_usageFailure6.24test_usage_events.py
ContextSuite context=TestCreateVolume>:setupError0.00test_volumes.py
test_01_root_volume_encryptionError0.06test_volumes.py
test_02_data_volume_encryptionError0.06test_volumes.py
test_03_root_and_data_volume_encryptionError0.06test_volumes.py
ContextSuite context=TestVolumes>:setupError5.72test_volumes.py
ContextSuite context=TestISOUsage>:setupError0.00test_usage.py
ContextSuite context=TestLBRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestNatRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestPublicIPUsage>:setupError0.00test_usage.py
ContextSuite context=TestSnapshotUsage>:setupError0.00test_usage.py
ContextSuite context=TestVmUsage>:setupError0.00test_usage.py
ContextSuite context=TestVolumeUsage>:setupError0.00test_usage.py
ContextSuite context=TestVpnUsage>:setupError0.00test_usage.py
ContextSuite context=TestVmAutoScaling>:setupError0.00test_vm_autoscaling.py
ContextSuite context=TestMigrateVMStrictTags>:setupError0.00test_vm_strict_host_tags.py
ContextSuite context=TestRestoreVMStrictTags>:setupError0.00test_vm_strict_host_tags.py
ContextSuite context=TestScaleVMStrictTags>:setupError0.00test_vm_strict_host_tags.py
ContextSuite context=TestVMDeploymentPlannerStrictTags>:setupError0.00test_vm_strict_host_tags.py
ContextSuite context=TestVPCRedundancy>:setupError0.00test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setupError0.00test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setupError0.00test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobsError1.61test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failureError1.65test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connectedFailure15.62test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connectedFailure12.62test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnectedFailure29.31test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:teardownError30.45test_host_maintenance.py
test_disable_oobm_ha_state_ineligibleError1515.69test_hostha_kvm.py

@DaanHoogland

DaanHoogland commented Apr 20, 2025

Copy link
Copy Markdown
Contributor

@weizhouapache@vishesh92 51 vs 90 again, seems consistent.

@harikrishna-patnala

harikrishna-patnala commented Apr 21, 2025

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Apr 21, 2025

Copy link
Copy Markdown

@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Apr 21, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-13071)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52014 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10493-t13071-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File

@Pearl1594Pearl1594 moved this to In Progress in ACS 4.20.1Apr 22, 2025
@Pearl1594
Pearl1594 merged commit 45bac89 into apache:4.20Apr 22, 2025
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in ACS 4.20.1Apr 22, 2025
@Pearl1594
Pearl1594 deleted the fixup-update-security branch April 22, 2025 07:12
@Pearl1594Pearl1594 mentioned this pull request Apr 22, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@vishesh92@harikrishna-patnala@dhslove
Fix NPE on updating security groups for an instance (apache#10493)
4668ebe
* Fix NPE on updating security groups for an instance
* addressed review comments
* Method refactoring
---------
Co-authored-by: Harikrishna Patnala <harikrishna.patnala@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoaoJandreJoaoJandreJoaoJandre left review comments
@weizhouapacheweizhouapacheweizhouapache left review comments
@DaanHooglandDaanHooglandDaanHoogland approved these changes
@harikrishna-patnalaharikrishna-patnalaharikrishna-patnala approved these changes
@Pearl1594Pearl1594Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

component:security-groupcomponent:UISeverity:CriticalCritical bugstatus:ready-for-merge

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

Unable to update the security groups of a VM

7 participants

@vishesh92@blueorangutan@harikrishna-patnala@weizhouapache@DaanHoogland@JoaoJandre@Pearl1594