UI: Allow editing a Running VM in an Advanced zone with security groups except for security group details by Pearl1594 · Pull Request #10714 · apache/cloudstack

Pearl1594 · 2025-04-15T00:19:08Z

Description

This PR allows users to update VM name, etc of a VM in running state deployed in an advanced zone with security groups.
The form isn't pre-populated with the existing SG of the VM as doing so causes the API to send the securitygroupids of what is already set on the VM to the backend and that leads to the editVM operation failing as it believes that the SG is being attempted to be modified.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…curity groups

codecov · 2025-04-15T00:24:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (f13cf59) to head (b23aa20).
Report is 17 commits behind head on 4.19.

Additional details and impacted files

@@ Coverage Diff @@## 4.19 #10714 +/- ##
=========================================
Coverage 15.17% 15.17% - Complexity 11332 11335 +3 
=========================================
Files 5415 5415 Lines 474893 474892 -1 Branches 57920 57920 =========================================
+ Hits 72046 72055 +9 + Misses 394792 394782 -10 
Partials 8055 8055

Flag	Coverage Δ
uitests	`4.28% <ø> (+<0.01%)`	⬆️
unittests	`15.89% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2025-04-15T01:15:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kiranchavala · 2025-04-15T05:31:58Z

@blueorangutan ui

blueorangutan · 2025-04-15T05:33:04Z

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-04-15T05:49:01Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10714 (QA-JID-597)

weizhouapache · 2025-04-15T05:57:52Z

With this change, in advanced zone with Security groups, user cannot update the SGs either ?

DaanHoogland · 2025-04-15T08:58:19Z

@Pearl1594 , can you explain how the check for isRunning is done? It seems now all editing of security groups ever is disabled.

weizhouapache · 2025-04-15T09:06:49Z

I think the SG field is shown only if

security group is enabled in the zone, and
vm is Stopped

weizhouapache · 2025-04-16T06:54:40Z

fyi

#10493 has a related change

weizhouapache · 2025-04-16T13:17:18Z

@blueorangutan package

blueorangutan · 2025-04-16T13:18:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-16T14:34:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13078

blueorangutan · 2025-04-16T15:35:38Z

[SF] Trillian Build Failed (tid-13021)

Pearl1594 · 2025-04-25T08:50:53Z

fyi
#10493 has a related change

@weizhouapache I do not think that it resolves the issue. But will check.

Pearl1594 · 2025-04-29T11:02:40Z

@blueorangutan package

blueorangutan · 2025-04-29T11:42:08Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-29T13:00:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13213

DaanHoogland

clgtm

vladimirpetrov · 2025-04-30T14:17:57Z

@blueorangutan test

blueorangutan · 2025-04-30T14:20:03Z

@vladimirpetrov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

vladimirpetrov

LGTM based on manual testing.

blueorangutan · 2025-05-01T05:18:44Z

[SF] Trillian test result (tid-13187)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50744 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10714-t13187-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_redundant_VPC_default_routes	`Failure`	424.16	test_vpc_redundant.py

yadvr

LGTM didn't test it

…curity groups (apache#10714)

UI: Allow editing VM name of a Running VM in an Advanced zone with se…
b23aa20
…curity groups

Pearl1594 added this to the 4.19.3 milestone Apr 15, 2025

Pearl1594 requested review from DaanHoogland and vladimirpetrov April 15, 2025 00:19

Pearl1594 added this to ACS 4.20.1 Apr 15, 2025

boring-cyborgBot added the component:UI label Apr 15, 2025

Pearl1594 linked an issue Apr 15, 2025 that may be closed by this pull request
Unable to edit a running instance in Advanced zone with security groups #10719
Closed

Pearl1594 requested a review from harikrishna-patnala April 22, 2025 08:40

DaanHoogland requested review from kiranchavala and removed request for vladimirpetrov April 25, 2025 08:52

harikrishna-patnala approved these changes Apr 25, 2025
View reviewed changes

Pearl1594 moved this to In Progress in ACS 4.20.1 Apr 29, 2025

DaanHoogland approved these changes Apr 29, 2025
View reviewed changes

DaanHoogland added the status:needs-testing label Apr 29, 2025

vladimirpetrov approved these changes Apr 30, 2025
View reviewed changes

yadvr approved these changes May 1, 2025
View reviewed changes

DaanHoogland removed the status:needs-testing label May 1, 2025

DaanHoogland merged commit 0c4ed1e into 4.19May 1, 2025

DaanHoogland deleted the ui-updateVM-withsecgroup branch May 1, 2025 07:02

github-project-automationBot moved this from In Progress to Done in ACS 4.20.1 May 1, 2025

shwstppr mentioned this pull request May 6, 2025
Unable to edit a running instance in Advanced zone with security groups #10719
Closed

weizhouapache mentioned this pull request May 9, 2025
Fix issue where security group selection is shown regardless of zone settings in EditVM #10224
Closed
14 tasks

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
UI: Allow editing VM name of a Running VM in an Advanced zone with se…
ef4a175
…curity groups (apache#10714)

Uh oh!

Conversation

Pearl1594 commented Apr 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecovBot commented Apr 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloudBot commented Apr 15, 2025

Quality Gate passed

Uh oh!

kiranchavala commented Apr 15, 2025

Uh oh!

blueorangutan commented Apr 15, 2025

Uh oh!

blueorangutan commented Apr 15, 2025

Uh oh!

weizhouapache commented Apr 15, 2025

Uh oh!

DaanHoogland commented Apr 15, 2025

Uh oh!

weizhouapache commented Apr 15, 2025

Uh oh!

weizhouapache commented Apr 16, 2025

Uh oh!

weizhouapache commented Apr 16, 2025

Uh oh!

blueorangutan commented Apr 16, 2025

Uh oh!

blueorangutan commented Apr 16, 2025

Uh oh!

blueorangutan commented Apr 16, 2025

Uh oh!

Pearl1594 commented Apr 25, 2025

Uh oh!

Pearl1594 commented Apr 29, 2025

Uh oh!

blueorangutan commented Apr 29, 2025

Uh oh!

blueorangutan commented Apr 29, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

vladimirpetrov commented Apr 30, 2025

Uh oh!

blueorangutan commented Apr 30, 2025

Uh oh!

vladimirpetrov left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented May 1, 2025

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Pearl1594 commented Apr 15, 2025•
edited
Loading

codecovBot commented Apr 15, 2025•
edited
Loading