Skip to content

Fix issue with security group selection box display - #10849

Merged
DaanHoogland merged 1 commit into
4.19from
sec-group-selection
May 16, 2025
Merged

Fix issue with security group selection box display#10849
DaanHoogland merged 1 commit into
4.19from
sec-group-selection

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

This PR is based off: #10224 required to be address in 4.19.
The main fix here is the listZones API which incorrectly uses zoneid as opposed to id in the api params.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecovBot commented May 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (bcd23eb) to head (83b4a71).
Report is 13 commits behind head on 4.19.

Additional details and impacted files
@@ Coverage Diff @@## 4.19 #10849 +/- ##
============================================
+ Coverage 4.28% 15.17% +10.88% - Complexity 0 11342 +11342 
============================================
Files 371 5415 +5044 Lines 29700 475325 +445625 Branches 5211 58003 +52792 ============================================
+ Hits 1274 72128 +70854 - Misses 28281 395133 +366852 - Partials 145 8064 +7919 
FlagCoverage Δ
uitests4.28% <ø> (+<0.01%)⬆️
unittests15.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10849 (QA-JID-618)

@DaanHoogland

DaanHoogland commented May 12, 2025

Copy link
Copy Markdown
Contributor

tested in qa as whitebox test.

params.securitygroupids = values.securitygroupids
}
if (this.securityGroupsEnabled && Array.isArray(values.securitygroupids) && values.securitygroupids.length > 0) {
params.securitygroupids = values.securitygroupids

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work? I saw a similar code block yesterday where we were using it like the following,
params.securitygroupids = values.securitygroupids.join(',')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in QA, @shwstppr. The only thing not working is clearing the list of security groups completely. Which, I think, is a separate issue.
What do you think might happen when not calling join(‘,’)?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland, that was just a question from my side. I've not tested it and do not know if it makes any difference at the moment. If it is already tested then 👍

@DaanHoogland
DaanHoogland merged commit 39a0ba9 into 4.19May 16, 2025
@DaanHoogland
DaanHoogland deleted the sec-group-selection branch May 16, 2025 10:35
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Co-authored-by: toolmanwyj <wyjtoolmancc@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Pearl1594@DaanHoogland@blueorangutan@yadvr@shwstppr@toolmanwyj