Skip to content

Fix issue with security group selection box display#10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 1 commit into from
May 16, 2025
Merged

Fix issue with security group selection box display #10849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ui/src/views/compute/EditVM.vue
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -194,7 +194,7 @@ export default {
},
fetchZoneDetails () {
api('listZones', {
zoneid: this.resource.zoneid
id: this.resource.zoneid
}).then(response => {
const zone = response?.listzonesresponse?.zone || []
this.securityGroupsEnabled = zone?.[0]?.securitygroupsenabled
Expand DownExpand Up@@ -328,10 +328,8 @@ export default {
params.name = values.name
params.displayname = values.displayname
params.ostypeid = values.ostypeid
if (this.securityGroupsEnabled) {
if (values.securitygroupids) {
params.securitygroupids = values.securitygroupids
}
if (this.securityGroupsEnabled && Array.isArray(values.securitygroupids) && values.securitygroupids.length > 0) {
params.securitygroupids = values.securitygroupids

@shwstpprshwstpprMay 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work? I saw a similar code block yesterday where we were using it like the following,
params.securitygroupids = values.securitygroupids.join(',')

@DaanHooglandDaanHooglandMay 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in QA, @shwstppr. The only thing not working is clearing the list of security groups completely. Which, I think, is a separate issue.
What do you think might happen when not calling join(‘,’)?

@shwstpprshwstpprMay 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland, that was just a question from my side. I've not tested it and do not know if it makes any difference at the moment. If it is already tested then 👍

}
if (values.isdynamicallyscalable !== undefined) {
params.isdynamicallyscalable = values.isdynamicallyscalable
Expand Down