Fix for create template from snapshot (for snapshots on primary storage and storage doesn't support create snapshot to template directly) by sureshanaparti · Pull Request #11452 · apache/cloudstack

sureshanaparti · 2025-08-14T21:48:14Z

Description

This PR fixes create template from snapshot, for snapshots on primary storage and storage doesn't support create snapshot to template directly.

seems to be regression from #9478

Fixes#11451

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested create volume snapshot (for volumes of running instance) with NFS & PowerFlex primary pools and NFS secondary, and created template & volume from snapshot on NFS primary, created template from snapshot on PowerFlex primary.

How did you try to break this feature and the system with this change?

sureshanaparti · 2025-08-14T21:50:22Z

@blueorangutan package

blueorangutan · 2025-08-14T21:52:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-08-14T21:56:43Z

Codecov Report

❌ Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.36%. Comparing base (9fd2b90) to head (1aef01f).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/template/TemplateManagerImpl.java	0.00%	12 Missing ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java	0.00%	9 Missing ⚠️
...org/apache/cloudstack/snapshot/SnapshotHelper.java	16.66%	5 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #11452 +/- ##
=========================================
Coverage 17.36% 17.36% + Complexity 15236 15235 -1 
=========================================
Files 5886 5886 Lines 525645 525663 +18 Branches 64156 64158 +2 =========================================
+ Hits 91257 91261 +4 - Misses 424093 424107 +14 
Partials 10295 10295

Flag	Coverage Δ
uitests	`3.63% <ø> (ø)`
unittests	`18.40% <3.70%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-08-14T23:05:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14626

rp- · 2025-08-15T07:26:34Z

Sorry no, still the same error.

sureshanaparti · 2025-08-15T07:33:46Z

Sorry no, still the same error.

ok

rp- · 2025-08-15T07:37:01Z

I'm trying a commit before #9478 to see if it really is the cause of it.

sureshanaparti · 2025-08-15T07:40:15Z

I'm trying a commit before #9478 to see if it really is the cause of it.

The if cond. added there matches for only StorPool. I'm assuming Linstor should take the else path, as snapshots will be in primary storage, not Image and earlier condition kvmSnapshotOnlyInPrimaryStorage is missing.

rp- · 2025-08-15T07:46:35Z

I'm trying a commit before #9478 to see if it really is the cause of it.
The if cond. added there matches for only StorPool. I'm assuming Linstor should take the else path, as snapshots will be in primary storage, not Image and earlier condition kvmSnapshotOnlyInPrimaryStorage is missing.

Volume snapshots per default go to secondary storage, we have an option to keep all snapshots on primary storage.
So it depends...

rp- · 2025-08-15T08:18:18Z

I can confirm that it worked before: #9478

slavkap · 2025-08-15T08:49:28Z

@rp-, Linstor is keeping only on primary or only on secondary storage? Does it have an option to keep the snapshot on both?

rp- · 2025-08-15T09:14:31Z

@rp-, Linstor is keeping only on primary or only on secondary storage? Does it have an option to keep the snapshot on both?

Yes, only on either primary or secondary. There is NO option for both.

sureshanaparti · 2025-08-15T09:39:09Z

@blueorangutan package

blueorangutan · 2025-08-15T09:40:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-15T10:54:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14634

DaanHoogland

clgtm, I think storage providers must test this in addition to smoke tests

sureshanaparti · 2025-08-15T11:58:08Z

@blueorangutan package

blueorangutan · 2025-08-15T12:00:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti · 2025-08-15T12:04:10Z

Hi @slavkap @rp- Please verify template & volume creation from snapshot with this PR and confirm. Thanks.

blueorangutan · 2025-08-15T13:24:44Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14635

slavkap

code LGTM
created volume from a snapshot with NFS, Ceph and StorPool as primary storage
created template from a snapshot with NFS/Ceph and StorPool
with enabled/disabled snapshot.backup.to.secondary option

DaanHoogland · 2025-08-15T13:48:36Z

@rp- ,can you test as well (and maybe others?)

rp-

tested create template and create volume from snapshot and works now

sureshanaparti · 2025-08-15T15:26:21Z

thanks @slavkap @rp- for testing this.

weizhouapache

code lgtm

nvazquez · 2025-08-15T16:39:03Z

@blueorangutan test

…ge and storage doesn't support create snapshot to template directly) (apache#11452) * Fix for create template from snapshot * code improvements, for create volume from snapshot

Fix for create template from snapshot
691d261

sureshanaparti requested review from rp- and slavkap August 14, 2025 21:49

sureshanaparti added this to the 4.21.0 milestone Aug 14, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Aug 14, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Aug 14, 2025

sureshanaparti marked this pull request as ready for review August 14, 2025 21:51

sureshanaparti mentioned this pull request Aug 14, 2025
LINSTOR create template from snapshot not working #11451
Closed

sureshanaparti added the 3rd-party:linstor label Aug 14, 2025

sureshanaparti requested a review from DaanHoogland August 15, 2025 07:22

sureshanaparti marked this pull request as draft August 15, 2025 07:32

code improvements
6a781cc

DaanHoogland approved these changes Aug 15, 2025
View reviewed changes

code improvements, for create volume from snapshot
1aef01f

boring-cyborgBot added the component:orchestration label Aug 15, 2025

apache deleted a comment from blueorangutan Aug 15, 2025

apache deleted a comment from DaanHoogland Aug 15, 2025

sureshanaparti added the status:needs-testing label Aug 15, 2025

slavkap approved these changes Aug 15, 2025
View reviewed changes

rp- approved these changes Aug 15, 2025
View reviewed changes

sureshanaparti removed the status:needs-testing label Aug 15, 2025

sureshanaparti marked this pull request as ready for review August 15, 2025 14:04

weizhouapache approved these changes Aug 15, 2025
View reviewed changes

nvazquez approved these changes Aug 15, 2025
View reviewed changes

sureshanaparti merged commit f671461 into apache:mainAug 15, 2025
25 of 26 checks passed

github-project-automationBot moved this from In Progress to Done in Apache CloudStack 4.21.0 Aug 15, 2025

sureshanaparti deleted the 4.21-linstor-template-from-snapshot-issue branch August 15, 2025 16:47

slavkap mentioned this pull request Aug 20, 2025
Fix of create a template from a StorPool snapshot on another zone #11490
Merged
12 tasks

Uh oh!

Conversation

sureshanaparti commented Aug 14, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Aug 14, 2025

Uh oh!

blueorangutan commented Aug 14, 2025

Uh oh!

codecovBot commented Aug 14, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Aug 14, 2025

Uh oh!

rp- commented Aug 15, 2025

Uh oh!

sureshanaparti commented Aug 15, 2025

Uh oh!

rp- commented Aug 15, 2025

Uh oh!

sureshanaparti commented Aug 15, 2025

Uh oh!

rp- commented Aug 15, 2025

Uh oh!

rp- commented Aug 15, 2025

Uh oh!

slavkap commented Aug 15, 2025

Uh oh!

rp- commented Aug 15, 2025

Uh oh!

sureshanaparti commented Aug 15, 2025

Uh oh!

blueorangutan commented Aug 15, 2025

Uh oh!

blueorangutan commented Aug 15, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Aug 15, 2025

Uh oh!

blueorangutan commented Aug 15, 2025

Uh oh!

sureshanaparti commented Aug 15, 2025

Uh oh!

blueorangutan commented Aug 15, 2025

Uh oh!

slavkap left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Aug 15, 2025

Uh oh!

rp- left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Aug 15, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Aug 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sureshanaparti commented Aug 14, 2025•
edited
Loading

codecovBot commented Aug 14, 2025•
edited
Loading