Uh oh!
There was an error while loading. Please reload this page.
Fix of create a template from a StorPool snapshot on another zone - #11490
Conversation
When a snapshot has a copy on StorPool primary storage in another zone, but the original snapshot resides on secondary storage, creating a template from the copied snapshot results in the template being created in the first zone. If the snapshot.backup.to.secondary setting is disabled, and a user creates a volume or template from a snapshot, the snapshot is temporarily backed up to secondary storage during the operation. After the operation, this backup should be deleted. However, the snapshot currently remains on both primary and secondary storage.
nvazquez
commented
Aug 20, 2025
@blueorangutan package |
blueorangutan
commented
Aug 20, 2025
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## main #11490 +/- ##
=========================================
Coverage 17.35% 17.36% - Complexity 15230 15234 +4
=========================================
Files 5886 5886 Lines 525685 525680 -5 Branches 64159 64159 =========================================
+ Hits 91247 91261 +14 + Misses 424138 424120 -18 + Partials 10300 10299 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blueorangutan
commented
Aug 20, 2025
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14681 |
sureshanaparti
commented
Aug 20, 2025
Hi @rp- Can you test this PR with linstor and share your results. Thanks. |
sureshanaparti
commented
Aug 20, 2025
@blueorangutan test |
blueorangutan
commented
Aug 20, 2025
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
blueorangutan
commented
Aug 21, 2025
[SF] Trillian test result (tid-14089)
|
rp-
left a comment
There was a problem hiding this comment.
create template from snapshot worked, BUT
create volume from snapshot did NOT.
with Linstor
rp-
commented
Aug 21, 2025
|
slavkap
commented
Aug 21, 2025
thanks @rp-, I'm working on it |
slavkap
commented
Aug 21, 2025
@rp-, can you please test this again if you have time? |
sureshanaparti
commented
Aug 21, 2025
@blueorangutan package |
blueorangutan
commented
Aug 21, 2025
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
blueorangutan
commented
Aug 21, 2025
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14690 |
rp-
commented
Aug 21, 2025
works now! |
sureshanaparti
commented
Aug 21, 2025
@blueorangutan package |
blueorangutan
commented
Aug 21, 2025
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sureshanaparti
commented
Aug 21, 2025
@blueorangutan package |
blueorangutan
commented
Aug 21, 2025
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
nvazquez
left a comment
There was a problem hiding this comment.
LGTM - have tried on env with 2 zones having cluster wide NFS storages:
Deploy VM on Zone A:
Setting snapshot.backup.to.secondary = false:
- Take snapshot of VM’s ROOT volume on Zone A
- Create template from snapshot on Zone A
- Deploy VM from template on Zone A
Setting snapshot.backup.to.secondary = true:
- Take snapshot of VM’s ROOT volume on Zone A and Zone B (by adding the additional zone on the Take snapshot wizard)
- Create template from snapshot on Zone A
- Create template from snapshot on Zone B
- Deploy VM from template on Zone A
- Deploy VM from template on Zone B
slavkap
commented
Aug 21, 2025
Tested with Ceph
|
blueorangutan
commented
Aug 21, 2025
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14701 |
sureshanaparti
commented
Aug 21, 2025
@blueorangutan test |
blueorangutan
commented
Aug 21, 2025
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
sureshanaparti
commented
Aug 21, 2025
LGTM. Verified volume snapshot creation with volumes on NFS primary (backed to NFS image store) & PowerFlex pools, and able to create template & volume from snapshots on NFS image store, create template from snapshot on PowerFlex storage pool. |
Uh oh!
There was an error while loading. Please reload this page.
blueorangutan
commented
Aug 22, 2025
[SF] Trillian test result (tid-14096)
|
…ache#11490) * Fix of create template from snapshot on another zone When a snapshot has a copy on StorPool primary storage in another zone, but the original snapshot resides on secondary storage, creating a template from the copied snapshot results in the template being created in the first zone. If the snapshot.backup.to.secondary setting is disabled, and a user creates a volume or template from a snapshot, the snapshot is temporarily backed up to secondary storage during the operation. After the operation, this backup should be deleted. However, the snapshot currently remains on both primary and secondary storage. * update snapshot info depending on the data store role
Description
This PR fixes:
regression from #11452
snapshot.backup.to.secondarysetting is disabled, and a user creates a volume or template from a snapshot, the snapshot is temporarily backed up to secondary storage during the operation. After the operation, this backup should be deleted. However, the snapshot currently remains on both primary and secondary storage.Types of changes
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
manually tested and still testing it