Show time correctly in the backup schedule UI by abh1sar · Pull Request #12012 · apache/cloudstack

abh1sar · 2025-11-07T04:36:37Z

Description

This PR fixes#11928

Display time in human readable format
Disable the interval for which a schedule is already created as one interval can only have one schedule.

The behaviour is similar to the Create Recurring Snapshots UI.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Screen.Recording.2025-11-07.at.9.49.10.AM.mov

How did you try to break this feature and the system with this change?

codecov · 2025-11-07T04:45:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (ac8c200) to head (982298e).
⚠️ Report is 42 commits behind head on 4.22.

Additional details and impacted files

@@ Coverage Diff @@## 4.22 #12012 +/- ##
============================================
- Coverage 17.56% 17.56% -0.01% - Complexity 15544 15545 +1 
============================================
Files 5909 5910 +1 Lines 529059 529208 +149 Branches 64617 64661 +44 ============================================
- Hits 92941 92940 -1 - Misses 425664 425810 +146 - Partials 10454 10458 +4

Flag	Coverage Δ
uitests	`3.58% <ø> (-0.01%)`	⬇️
unittests	`18.63% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland · 2025-11-07T08:18:26Z

@blueorangutan ui

blueorangutan · 2025-11-07T08:19:05Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-11-07T08:38:26Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12012 (QA-JID-792)

abh1sar · 2025-11-07T09:49:55Z

@blueorangutan ui

blueorangutan · 2025-11-07T09:51:04Z

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-11-07T10:10:18Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12012 (QA-JID-793)

DaanHoogland

clgtm

RosiKyu · 2025-12-10T16:32:57Z

@blueorangutan ui

blueorangutan · 2025-12-10T16:34:05Z

@rosi-shapeblue a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-12-10T16:54:02Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12012 (QA-JID-828)

RosiKyu · 2025-12-10T17:56:24Z

@blueorangutan package

blueorangutan · 2025-12-10T17:58:04Z

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

RosiKyu · 2025-12-10T18:00:27Z

@blueorangutan package

blueorangutan · 2025-12-10T18:02:04Z

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-10T19:49:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15985

blueorangutan · 2025-12-10T19:49:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15984

RosiKyu

@abh1sar overall the main issue has been addressed. However, I tested a flow in which the form breaks:

Steps to Reproduce

Create scheduled backups for all schedule types.
Delete the Daily scheduled backup.
Navigate to Schedule -> the displayed tab is Daily, but the Time selection shown is for Hourly backups.
Fill in the form and attempt to create a new Daily scheduled backup.
Open the Scheduled Backups tab -> observe that the existing Hourly backup settings are overwritten.
Delete the Hourly scheduled backup
Recreate it
Try adding a new Daily scheduled backup -> the displayed tab is Daily, but the Time selection shown is for Hourly backups.

Screencast.from.2025-12-11.13-49-34.webm

abh1sar · 2025-12-16T10:16:29Z

@blueorangutan ui

blueorangutan · 2025-12-16T10:17:05Z

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-12-16T10:38:09Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12012 (QA-JID-830)

abh1sar · 2025-12-16T11:20:26Z

Thanks for testing @RosiKyu
I have fixed the issue. Same issue was present in Scheduled volume snapshot as well. I have fixed it there as well.
It would be great if you could take a look at that also.

RosiKyu · 2025-12-16T22:15:02Z

@blueorangutan package

blueorangutan · 2025-12-16T22:16:04Z

@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-16T23:31:28Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16063

RosiKyu

LGTM

Thank you for addressing this, @abh1sar ! Works flawlessly now

Screencast.from.2025-12-17.15-39-23.webm

* 4.22: Update templateConfig.sh to not break with directorys with space on t… (#10898) Fix VM and volume metrics listing regressions (#12284) packaging: use latest cmk release link directly (#11429) api:rename RegisterCmd.java => RegisterUserKeyCmd.java (#12259) Prioritize copying templates from other secondary storages instead of downloading them (#10363) Show time correctly in the backup schedule UI (#12012) kvm: use preallocation option for fat disk resize (#11986) Python exception processing static routes fixed (#11967) KVM memballooning requires free page reporting and autodeflate (#11932) api: create/register/upload template with empty template tag (#12234)

fix backup schedule UI merge
906eb52

boring-cyborgBot added the component:UI label Nov 7, 2025

DaanHoogland linked an issue Nov 7, 2025 that may be closed by this pull request
Configured backup time not reflected accurately in UI #11928
Closed

fix backup schedule selection in instance deployment wizard
3bc4fa9

DaanHoogland approved these changes Nov 7, 2025
View reviewed changes

DaanHoogland assigned RosiKyu Nov 11, 2025

abh1sar added status:needs-testing component:backup labels Nov 12, 2025

RosiKyu added status:testing and removed status:needs-testing labels Dec 10, 2025

RosiKyu requested changes Dec 11, 2025
View reviewed changes

RosiKyu added status:needs-work and removed status:testing labels Dec 11, 2025

RosiKyu removed their assignment Dec 11, 2025

switch selected interval after creation of schedule on one interval
982298e

abh1sar assigned RosiKyu Dec 16, 2025

RosiKyu approved these changes Dec 17, 2025
View reviewed changes

RosiKyu added status:ready-for-merge and removed status:needs-work labels Dec 17, 2025

DaanHoogland merged commit e9900ab into apache:4.22Dec 17, 2025
25 of 26 checks passed

DaanHoogland deleted the backup-schedule-ui branch December 17, 2025 13:47

DaanHoogland mentioned this pull request Dec 17, 2025
Configured backup time not reflected accurately in UI #11928
Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 21, 2026
Show time correctly in the backup schedule UI (apache#12012)
cb9891b

sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Feb 6, 2026
Show time correctly in the backup schedule UI (apache#12012)
0e1989b

Uh oh!

Conversation

abh1sar commented Nov 7, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecovBot commented Nov 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland commented Nov 7, 2025

Uh oh!

blueorangutan commented Nov 7, 2025

Uh oh!

blueorangutan commented Nov 7, 2025

Uh oh!

abh1sar commented Nov 7, 2025

Uh oh!

blueorangutan commented Nov 7, 2025

Uh oh!

blueorangutan commented Nov 7, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

RosiKyu commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 10, 2025

Uh oh!

RosiKyu commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 10, 2025

Uh oh!

RosiKyu commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 10, 2025

Uh oh!

RosiKyu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abh1sar commented Dec 16, 2025

Uh oh!

blueorangutan commented Dec 16, 2025

Uh oh!

blueorangutan commented Dec 16, 2025

Uh oh!

abh1sar commented Dec 16, 2025

Uh oh!

RosiKyu commented Dec 16, 2025

Uh oh!

blueorangutan commented Dec 16, 2025

Uh oh!

blueorangutan commented Dec 16, 2025

Uh oh!

RosiKyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecovBot commented Nov 7, 2025•
edited
Loading

RosiKyu left a comment •
edited
Loading