Skip to content

api:rename RegisterCmd.java => RegisterUserKeyCmd.java - #12259

Merged
DaanHoogland merged 1 commit into
apache:4.22from
weizhouapache:4.22-rename-register-user-key
Dec 18, 2025
Merged

api:rename RegisterCmd.java => RegisterUserKeyCmd.java#12259
DaanHoogland merged 1 commit into
apache:4.22from
weizhouapache:4.22-rename-register-user-key

Conversation

@weizhouapache

@weizhouapacheweizhouapache commented Dec 15, 2025

Copy link
Copy Markdown
Member

Description

This PR renames

  • RegisterCmd.java => RegisterUserKeyCmd.java
  • RegisterResponse.java => RegisterUserKeyResponse.java

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecovBot commented Dec 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (0a13fb2) to head (6d3cc61).
⚠️ Report is 13 commits behind head on 4.22.

Files with missing linesPatch %Lines
...ack/api/command/admin/user/RegisterUserKeyCmd.java0.00%2 Missing ⚠️
...udstack/api/command/admin/user/GetUserKeysCmd.java0.00%1 Missing ⚠️
...oudstack/api/response/RegisterUserKeyResponse.java0.00%1 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java0.00%1 Missing ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## 4.22 #12259 +/- ##
=========================================
Coverage 17.55% 17.56% - Complexity 15544 15548 +4 
=========================================
Files 5910 5910 Lines 529162 529162 Branches 64641 64641 =========================================
+ Hits 92918 92940 +22 + Misses 425786 425764 -22 
Partials 10458 10458 
FlagCoverage Δ
uitests3.58% <ø> (ø)
unittests18.63% <0.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapacheweizhouapache added this to the 4.22.1 milestone Dec 16, 2025
@weizhouapache

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16055

@shwstpprshwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-15009)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52377 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12259-t15009-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
test_03_deploy_and_scale_kubernetes_clusterFailure38.17test_kubernetes_clusters.py

@DaanHoogland

Copy link
Copy Markdown
Contributor

Do you think this needs testing beyond regression tests, @weizhouapache ?

@weizhouapache

Copy link
Copy Markdown
MemberAuthor

Do you think this needs testing beyond regression tests, @weizhouapache ?

I think no.. it just renames java classes

@DaanHoogland
DaanHoogland marked this pull request as ready for review December 18, 2025 10:52
@DaanHoogland
DaanHoogland merged commit 8936e4c into apache:4.22Dec 18, 2025
24 of 25 checks passed
@DaanHoogland
DaanHoogland deleted the 4.22-rename-register-user-key branch December 18, 2025 10:53
DaanHoogland pushed a commit that referenced this pull request Dec 22, 2025
* 4.22:
Update templateConfig.sh to not break with directorys with space on t… (#10898)
Fix VM and volume metrics listing regressions (#12284)
packaging: use latest cmk release link directly (#11429)
api:rename RegisterCmd.java => RegisterUserKeyCmd.java (#12259)
Prioritize copying templates from other secondary storages instead of downloading them (#10363)
Show time correctly in the backup schedule UI (#12012)
kvm: use preallocation option for fat disk resize (#11986)
Python exception processing static routes fixed (#11967)
KVM memballooning requires free page reporting and autodeflate (#11932)
api: create/register/upload template with empty template tag (#12234)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 21, 2026
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Feb 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@weizhouapache@blueorangutan@DaanHoogland@shwstppr@rajujith@sureshanaparti