[4.11] CLOUDSTACK-9813: Extending Config Drive support by fmaximus · Pull Request #2097 · apache/cloudstack

fmaximus · 2017-05-11T10:17:17Z

Added support for VMware
Build configdrive.iso on ssvm
Added support for VPC and Isolated Networks
Moved implementation to new Service Provider
UI fix: add support for urlencoded userdata
Add support for building systemvm behind a proxy

Co-Authored-By: Raf Smeets raf.smeets@nuagenetworks.net
Co-Authored-By: Frank Maximus frank.maximus@nuagenetworks.net
Co-Authored-By: Sigert Goeminne sigert.goeminne@nuagenetworks.net

krissterckx · 2017-05-12T11:45:28Z

@kiwiflyer the commit has been fixed, can the Work-in-progress be removed now?

kiwiflyer · 2017-05-12T12:34:33Z

@krissterckx done.

Co-Authored-By: Frank Maximus <frank.maximus@nuagenetworks.net> Upstream PR: apache/cloudstack#2097 Design document: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+ConfigDrive+for+Metadata%2C+Userdata+and+Password

cloudmonger · 2017-07-17T23:18:44Z

ACS CI BVT Run

Sumarry:
Build Number 978
Hypervisor xenserver
NetworkType Advanced
Passed=106
Failed=7
Skipped=12

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

test_deploy_vm_iso.py
test_deploy_vm_from_iso Failing since 36 runs
test_volumes.py
test_06_download_detached_volume Failed
test_vm_life_cycle.py
test_10_attachAndDetach_iso Failing since 36 runs
test_routers_network_ops.py
test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 69 runs
test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 69 runs
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 68 runs
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 68 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

wido · 2017-08-10T15:37:42Z

There are merge conflicts with this PR. Would be great to get it in, could you take a look at them?

Co-Authored-By: Frank Maximus <frank.maximus@nuagenetworks.net> Upstream PR: apache/cloudstack#2097 Design document: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+ConfigDrive+for+Metadata%2C+Userdata+and+Password

yadvr · 2018-01-10T16:51:27Z

@fmaximus please fix the conflicts

…_drive

yadvr · 2018-01-10T17:28:00Z

@blueorangutan package

blueorangutan · 2018-01-10T17:28:36Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-01-10T18:13:52Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1641

yadvr · 2018-01-10T18:25:37Z

@blueorangutan test centos7 vmware-55u3

blueorangutan · 2018-01-10T18:26:38Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

krissterckx · 2018-01-10T22:50:52Z

@rhtyd can the 'requested changes' ask be removed ? This PR should be ready for merge.

blueorangutan · 2018-01-11T03:12:47Z

Trillian test result (tid-2110)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31238 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2110-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_volume	`Failure`	176.91	test_volumes.py

krissterckx · 2018-01-11T13:00:07Z

@DaanHoogland @wido can you pls (re)approve this PR if you are OK with it ? Thanks

wido · 2018-01-11T13:26:48Z

I will take a last look at this later today and LGTM if OK!

yadvr · 2018-01-11T15:51:34Z

@blueorangutan package

blueorangutan · 2018-01-11T15:51:40Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-01-11T16:29:51Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1645

yadvr · 2018-01-11T16:41:08Z

@blueorangutan test matrix

blueorangutan · 2018-01-11T16:41:40Z

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

DaanHoogland · 2018-01-11T16:41:43Z

@blueorangutan test

blueorangutan · 2018-01-11T16:42:39Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-01-12T01:36:10Z

Trillian test result (tid-2113)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 32067 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2113-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_edit_template	`Failure`	90.10	test_templates.py
test_07_resize_fail	`Failure`	32.26	test_volumes.py

blueorangutan · 2018-01-12T02:11:24Z

Trillian test result (tid-2114)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33858 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2114-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_vm_wrong_checksum	`Error`	25.26	test_templates.py
ContextSuite context=TestCreateTemplateWithDirectDownload>:teardown	`Error`	39.86	test_templates.py
test_07_resize_fail	`Failure`	5.40	test_volumes.py
test_hostha_kvm_host_recovering	`Error`	6.45	test_hostha_kvm.py

blueorangutan · 2018-01-12T03:15:29Z

Trillian test result (tid-2115)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37398 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2115-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_volume	`Failure`	210.03	test_volumes.py

yadvr · 2018-01-12T09:26:48Z

Tests LGTM, same failures as seen in baseline master branch #2376. I've my objections on adding test data to the test_data.py (polluting marvin library) instead of keeping test data and test together, however that is not a blocker to PR acceptance. @fmaximus @krissterckx please send a separate PR (maybe in future) to fix them.

DaanHoogland · 2018-01-12T09:43:25Z

LGTM

yadvr · 2018-01-12T09:44:22Z

I'll honour reviews from @wido and @DaanHoogland , and based on no new regressions from test results merge the PR. I hope to get your support in further stabilizing master - @fmaximus @krissterckx @wido @DaanHoogland and others. Thanks.

This was referenced May 11, 2017
providers: added CloudStack as metadata provider coreos/afterburn#40
Merged
*: add support for cloudstack config-drive coreos/ignition#361
Closed

fmaximus force-pushed the feature/config_drive branch from d343576 to 8ead399Compare May 11, 2017 11:52

kiwiflyer added type:enhancement status:work-in-progress labels May 11, 2017

kiwiflyer removed the status:work-in-progress label May 12, 2017

kiwiflyer added this to the 4.11 milestone May 12, 2017

fmaximus changed the title ~~[4.11/Future] CLOUDSTACK-9813: Extending Config Drive support~~[4.11] CLOUDSTACK-9813: Extending Config Drive supportMay 12, 2017

sgoeminn mentioned this pull request May 16, 2017
providers: add support for cloudstack config-drive coreos/ignition#367
Merged

kiwiflyer mentioned this pull request May 18, 2017
CLOUDSTACK-8959: Option to attach the config drive #2116
Closed

DaanHoogland mentioned this pull request May 22, 2017
CLOUDSTACK-8959: Option to attach the config drive. #938
Closed

sgoeminn force-pushed the feature/config_drive branch from 8ead399 to 4575540Compare July 7, 2017 23:16

fmaximus force-pushed the feature/config_drive branch from 4575540 to 9f51464Compare July 17, 2017 13:10

wido added the status:waiting-for-author label Aug 10, 2017

fmaximus force-pushed the feature/config_drive branch from 9f51464 to 4c420c2Compare August 16, 2017 14:51

fmaximus force-pushed the feature/config_drive branch from 4c420c2 to 2bd51b7Compare September 29, 2017 10:11

fmaximus force-pushed the feature/config_drive branch from 2bd51b7 to c9631b4Compare October 26, 2017 13:08

fmaximus force-pushed the feature/config_drive branch 2 times, most recently from caa5b66 to 586fd15Compare November 3, 2017 11:28

fmaximus force-pushed the feature/config_drive branch from 586fd15 to 470fb4cCompare November 23, 2017 16:00

sgoeminn force-pushed the feature/config_drive branch from 470fb4c to 99a04daCompare December 7, 2017 11:25

yadvr removed this from the 4.11 milestone Dec 19, 2017

fmaximus force-pushed the feature/config_drive branch from 99a04da to 7685015Compare December 19, 2017 12:13

fmaximus added 2 commits January 10, 2018 17:42

CLOUDSTACK-9813: Fix DetachIso on VMware
dab03cd

CLOUDSTACK-9813: Review Comments: Remove configure_proxy
83aea16

Merge branch 'master' of github:apache/cloudstack into feature/config…
1fe575b
…_drive

wido approved these changes Jan 11, 2018
View reviewed changes

DaanHoogland approved these changes Jan 11, 2018
View reviewed changes

yadvr approved these changes Jan 12, 2018
View reviewed changes

yadvr merged commit b176648 into apache:masterJan 12, 2018

Uh oh!

Conversation

fmaximus commented May 11, 2017

Uh oh!

krissterckx commented May 12, 2017

Uh oh!

kiwiflyer commented May 12, 2017

Uh oh!

cloudmonger commented Jul 17, 2017

ACS CI BVT Run

Uh oh!

wido commented Aug 10, 2017

Uh oh!

yadvr commented Jan 10, 2018

Uh oh!

yadvr commented Jan 10, 2018

Uh oh!

blueorangutan commented Jan 10, 2018

Uh oh!

blueorangutan commented Jan 10, 2018

Uh oh!

yadvr commented Jan 10, 2018

Uh oh!

blueorangutan commented Jan 10, 2018

Uh oh!

krissterckx commented Jan 10, 2018

Uh oh!

blueorangutan commented Jan 11, 2018

Uh oh!

krissterckx commented Jan 11, 2018

Uh oh!

wido commented Jan 11, 2018

Uh oh!

yadvr commented Jan 11, 2018

Uh oh!

blueorangutan commented Jan 11, 2018

Uh oh!

blueorangutan commented Jan 11, 2018

Uh oh!

yadvr commented Jan 11, 2018

Uh oh!

blueorangutan commented Jan 11, 2018

Uh oh!

DaanHoogland commented Jan 11, 2018

Uh oh!

blueorangutan commented Jan 11, 2018

Uh oh!

blueorangutan commented Jan 12, 2018

Uh oh!

blueorangutan commented Jan 12, 2018

Uh oh!

blueorangutan commented Jan 12, 2018

Uh oh!

yadvr commented Jan 12, 2018

Uh oh!

DaanHoogland commented Jan 12, 2018

Uh oh!

yadvr commented Jan 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants