Skip to content

CLOUDSTACK-8959: Option to attach the config drive - #2116

Closed
jayapalu wants to merge 1 commit into
4.11from
unknown repository
Closed

CLOUDSTACK-8959: Option to attach the config drive#2116
jayapalu wants to merge 1 commit into
4.11from
unknown repository

Conversation

@jayapalu

@jayapalujayapalu commented May 18, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Added config option for config drive.
This closes PR #938

@kiwiflyer

kiwiflyer commented May 18, 2017

Copy link
Copy Markdown
Contributor

@jayapalu There is another PR out there for config drive enhancements you may want to check out and review - #2097

@kiwiflyer

kiwiflyer commented May 18, 2017

Copy link
Copy Markdown
Contributor

@jayapalu - So this seems to be a resubmit of #938.
Can you please refer to the comments in the previous PR for review?

Thanks.

@kiwiflyerkiwiflyer mentioned this pull request May 19, 2017
Closed
@jayapalu

jayapalu commented May 19, 2017

Copy link
Copy Markdown
ContributorAuthor

@pedro-martins@kiwiflyer
moved the code into method. vmdata is checked for not null in the resource for attaching the config drive iso to vm.
@kiwiflyer I am following #2097, thanks for the info.

@cloudmonger

cloudmonger commented May 22, 2017

Copy link
Copy Markdown

ACS CI BVT Run

Sumarry:
Build Number 733
Hypervisor xenserver
NetworkType Advanced
Passed=57
Failed=5
Skipped=5

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

  • test_non_contigiousvlan.py

  • test_extendPhysicalNetworkVlan Failing since 2 runs

  • test_routers_network_ops.py

  • test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed

  • test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed

  • test_03_RVR_Network_check_router_state Failed

  • ContextSuite context=TestRedundantIsolateNetworks>:teardown Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_over_provisioning.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py

@DaanHoogland

DaanHoogland commented May 22, 2017

Copy link
Copy Markdown
Contributor

reviewer please see #938 as well when reviewing this

@jayapalu

jayapalu commented May 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Failed tests are not related to this PR.
Can some one please review this PR.
@borisstoyanov Can you also trigger the Trillian.

@borisstoyanov

borisstoyanov commented May 24, 2017

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented May 24, 2017

Copy link
Copy Markdown

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 24, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-745

@borisstoyanov

borisstoyanov commented May 25, 2017

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented May 25, 2017

Copy link
Copy Markdown

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented May 25, 2017

Copy link
Copy Markdown

Trillian test result (tid-1131)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33583 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2116-t1131-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Test completed. 49 look ok, 2 have error(s)

TestResultTime (s)Test File
test_04_rvpc_privategw_static_routesFailure300.33test_privategw_acl.py
ContextSuite context=TestDeployVirtioSCSIVM>:setupError0.00test_deploy_virtio_scsi_vm.py
test_01_vpc_site2site_vpnSuccess159.98test_vpc_vpn.py
test_01_vpc_remote_access_vpnSuccess56.16test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpnSuccess235.87test_vpc_vpn.py
test_02_VPC_default_routesSuccess253.97test_vpc_router_nics.py
test_01_VPC_nics_after_destroySuccess487.74test_vpc_router_nics.py
test_05_rvpc_multi_tiersSuccess526.88test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsSuccess1315.36test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersSuccess543.05test_vpc_redundant.py
test_02_redundant_VPC_default_routesSuccess729.79test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLSuccess1263.98test_vpc_redundant.py
test_09_delete_detached_volumeSuccess156.54test_volumes.py
test_08_resize_volumeSuccess156.48test_volumes.py
test_07_resize_failSuccess161.55test_volumes.py
test_06_download_detached_volumeSuccess151.33test_volumes.py
test_05_detach_volumeSuccess150.80test_volumes.py
test_04_delete_attached_volumeSuccess146.19test_volumes.py
test_03_download_attached_volumeSuccess151.45test_volumes.py
test_02_attach_volumeSuccess89.35test_volumes.py
test_01_create_volumeSuccess617.73test_volumes.py
test_03_delete_vm_snapshotsSuccess275.24test_vm_snapshots.py
test_02_revert_vm_snapshotsSuccess95.63test_vm_snapshots.py
test_01_create_vm_snapshotsSuccess128.69test_vm_snapshots.py
test_deploy_vm_multipleSuccess227.54test_vm_life_cycle.py
test_deploy_vmSuccess0.03test_vm_life_cycle.py
test_advZoneVirtualRouterSuccess0.02test_vm_life_cycle.py
test_10_attachAndDetach_isoSuccess26.73test_vm_life_cycle.py
test_09_expunge_vmSuccess125.25test_vm_life_cycle.py
test_08_migrate_vmSuccess71.14test_vm_life_cycle.py
test_07_restore_vmSuccess0.13test_vm_life_cycle.py
test_06_destroy_vmSuccess125.82test_vm_life_cycle.py
test_03_reboot_vmSuccess125.83test_vm_life_cycle.py
test_02_start_vmSuccess10.18test_vm_life_cycle.py
test_01_stop_vmSuccess30.30test_vm_life_cycle.py
test_CreateTemplateWithDuplicateNameSuccess141.08test_templates.py
test_08_list_system_templatesSuccess0.04test_templates.py
test_07_list_public_templatesSuccess0.06test_templates.py
test_05_template_permissionsSuccess0.06test_templates.py
test_04_extract_templateSuccess5.20test_templates.py
test_03_delete_templateSuccess5.12test_templates.py
test_02_edit_templateSuccess90.18test_templates.py
test_01_create_templateSuccess20.32test_templates.py
test_10_destroy_cpvmSuccess161.40test_ssvm.py
test_09_destroy_ssvmSuccess163.88test_ssvm.py
test_08_reboot_cpvmSuccess101.31test_ssvm.py
test_07_reboot_ssvmSuccess133.77test_ssvm.py
test_06_stop_cpvmSuccess131.50test_ssvm.py
test_05_stop_ssvmSuccess163.88test_ssvm.py
test_04_cpvm_internalsSuccess0.97test_ssvm.py
test_03_ssvm_internalsSuccess3.62test_ssvm.py
test_02_list_cpvm_vmSuccess0.13test_ssvm.py
test_01_list_sec_storage_vmSuccess0.14test_ssvm.py
test_02_list_snapshots_with_removed_data_storeSuccess86.97test_snapshots.py
test_01_snapshot_root_diskSuccess16.31test_snapshots.py
test_04_change_offering_smallSuccess209.50test_service_offerings.py
test_03_delete_service_offeringSuccess0.06test_service_offerings.py
test_02_edit_service_offeringSuccess0.08test_service_offerings.py
test_01_create_service_offeringSuccess0.12test_service_offerings.py
test_02_sys_template_readySuccess0.15test_secondary_storage.py
test_01_sys_vm_startSuccess0.21test_secondary_storage.py
test_09_reboot_routerSuccess35.33test_routers.py
test_08_start_routerSuccess25.27test_routers.py
test_07_stop_routerSuccess10.18test_routers.py
test_06_router_advancedSuccess0.08test_routers.py
test_05_router_basicSuccess0.04test_routers.py
test_04_restart_network_wo_cleanupSuccess5.60test_routers.py
test_03_restart_network_cleanupSuccess50.50test_routers.py
test_02_router_internal_advSuccess1.17test_routers.py
test_01_router_internal_basicSuccess0.62test_routers.py
test_router_dns_guestipquerySuccess74.65test_router_dns.py
test_router_dns_externalipquerySuccess0.08test_router_dns.py
test_router_dhcphostsSuccess241.41test_router_dhcphosts.py
test_router_dhcp_optsSuccess21.89test_router_dhcphosts.py
test_01_updatevolumedetailSuccess5.16test_resource_detail.py
test_01_reset_vm_on_rebootSuccess130.90test_reset_vm_on_reboot.py
test_createRegionSuccess0.04test_regions.py
test_create_pvlan_networkSuccess5.20test_pvlan.py
test_dedicatePublicIpRangeSuccess0.44test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanupSuccess434.71test_privategw_acl.py
test_02_vpc_privategw_static_routesSuccess330.24test_privategw_acl.py
test_01_vpc_privategw_aclSuccess77.19test_privategw_acl.py
test_03_migration_options_storage_tagsSuccess161.73test_primary_storage.py
test_02_edit_primary_storage_tagsSuccess0.11test_primary_storage.py
test_01_primary_storage_nfsSuccess35.79test_primary_storage.py
test_01_deploy_vms_storage_tagsSuccess31.16test_primary_storage.py
test_createPortablePublicIPRangeSuccess15.22test_portable_publicip.py
test_createPortablePublicIPAcquireSuccess15.45test_portable_publicip.py
test_isolate_network_password_serverSuccess56.26test_password_server.py
test_UpdateStorageOverProvisioningFactorSuccess0.13test_over_provisioning.py
test_oobm_zchange_passwordSuccess30.66test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownershipSuccess16.34test_outofbandmanagement.py
test_oobm_issue_power_statusSuccess10.26test_outofbandmanagement.py
test_oobm_issue_power_softSuccess15.33test_outofbandmanagement.py
test_oobm_issue_power_resetSuccess15.36test_outofbandmanagement.py
test_oobm_issue_power_onSuccess15.37test_outofbandmanagement.py
test_oobm_issue_power_offSuccess15.37test_outofbandmanagement.py
test_oobm_issue_power_cycleSuccess15.32test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesSuccess82.76test_outofbandmanagement.py
test_oobm_enable_feature_validSuccess5.16test_outofbandmanagement.py
test_oobm_enable_feature_invalidSuccess0.10test_outofbandmanagement.py
test_oobm_disable_feature_validSuccess5.17test_outofbandmanagement.py
test_oobm_disable_feature_invalidSuccess0.11test_outofbandmanagement.py
test_oobm_configure_invalid_driverSuccess0.08test_outofbandmanagement.py
test_oobm_configure_default_driverSuccess0.07test_outofbandmanagement.py
test_oobm_background_powerstate_syncSuccess23.41test_outofbandmanagement.py
test_extendPhysicalNetworkVlanSuccess15.30test_non_contigiousvlan.py
test_01_nicSuccess439.40test_nic.py
test_releaseIPSuccess257.94test_network.py
test_reboot_routerSuccess373.52test_network.py
test_public_ip_user_accountSuccess10.25test_network.py
test_public_ip_admin_accountSuccess40.27test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleSuccess66.62test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleSuccess61.64test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleSuccess120.37test_network.py
test_delete_accountSuccess297.91test_network.py
test_02_port_fwd_on_non_src_natSuccess55.66test_network.py
test_01_port_fwd_on_src_natSuccess111.74test_network.py
test_nic_secondaryip_add_removeSuccess232.79test_multipleips_per_nic.py
test_list_zones_metricsSuccess0.26test_metrics_api.py
test_list_volumes_metricsSuccess5.46test_metrics_api.py
test_list_vms_metricsSuccess262.12test_metrics_api.py
test_list_pstorage_metricsSuccess0.36test_metrics_api.py
test_list_infrastructure_metricsSuccess0.44test_metrics_api.py
test_list_hosts_metricsSuccess0.30test_metrics_api.py
test_list_clusters_metricsSuccess0.34test_metrics_api.py
login_test_saml_userSuccess19.39test_login.py
test_assign_and_removal_lbSuccess132.90test_loadbalance.py
test_02_create_lb_rule_non_natSuccess187.08test_loadbalance.py
test_01_create_lb_rule_src_natSuccess207.46test_loadbalance.py
test_03_list_snapshotsSuccess0.07test_list_ids_parameter.py
test_02_list_templatesSuccess0.04test_list_ids_parameter.py
test_01_list_volumesSuccess0.03test_list_ids_parameter.py
test_07_list_default_isoSuccess0.06test_iso.py
test_05_iso_permissionsSuccess0.13test_iso.py
test_04_extract_IsoSuccess5.15test_iso.py
test_03_delete_isoSuccess95.14test_iso.py
test_02_edit_isoSuccess0.09test_iso.py
test_01_create_isoSuccess21.01test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesSuccess198.03test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesSuccess117.98test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Success541.22test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Success628.40test_internal_lb.py
test_dedicateGuestVlanRangeSuccess10.26test_guest_vlan_range.py
test_UpdateConfigParamWithScopeSuccess0.14test_global_settings.py
test_rolepermission_lifecycle_updateSuccess6.17test_dynamicroles.py
test_rolepermission_lifecycle_listSuccess5.98test_dynamicroles.py
test_rolepermission_lifecycle_deleteSuccess5.88test_dynamicroles.py
test_rolepermission_lifecycle_createSuccess5.99test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updatesSuccess6.00test_dynamicroles.py
test_role_lifecycle_update_role_inuseSuccess5.94test_dynamicroles.py
test_role_lifecycle_updateSuccess10.99test_dynamicroles.py
test_role_lifecycle_listSuccess5.90test_dynamicroles.py
test_role_lifecycle_deleteSuccess10.98test_dynamicroles.py
test_role_lifecycle_createSuccess5.90test_dynamicroles.py
test_role_inuse_deletionSuccess5.86test_dynamicroles.py
test_role_account_acls_multiple_mgmt_serversSuccess8.13test_dynamicroles.py
test_role_account_aclsSuccess8.44test_dynamicroles.py
test_default_role_deletionSuccess6.15test_dynamicroles.py
test_04_create_fat_type_disk_offeringSuccess0.07test_disk_offerings.py
test_03_delete_disk_offeringSuccess0.06test_disk_offerings.py
test_02_edit_disk_offeringSuccess0.05test_disk_offerings.py
test_02_create_sparse_type_disk_offeringSuccess0.08test_disk_offerings.py
test_01_create_disk_offeringSuccess0.12test_disk_offerings.py
test_deployvm_userdispersingSuccess20.60test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedSuccess20.76test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfitSuccess156.43test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_postSuccess105.97test_deploy_vm_with_userdata.py
test_deployvm_userdataSuccess106.02test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resizeSuccess0.07test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeSuccess0.07test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resizeSuccess256.93test_deploy_vm_root_resize.py
test_deploy_vm_from_isoSuccess423.80test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroupSuccess121.37test_affinity_groups.py
test_change_service_offering_for_vm_with_snapshotsSkipped0.00test_vm_snapshots.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.02test_ssvm.py
test_01_scale_vmSkipped0.00test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.04test_primary_storage.py
test_nested_virtualization_vmwareSkipped0.00test_nested_virtualization.py
test_06_copy_isoSkipped0.00test_iso.py
test_deploy_vgpu_enabled_vmSkipped0.03test_deploy_vgpu_enabled_vm.py
test_3d_gpu_supportSkipped0.03test_deploy_vgpu_enabled_vm.py

@yadvr

yadvr commented Dec 17, 2017

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 17, 2017

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Dec 17, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1398

@yadvryadvr mentioned this pull request Dec 21, 2017
Merged
@fmaximus

fmaximus commented Dec 22, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

@jayapalu In PR #2097 we created a new UserData provider to have the possibility to have UserData without VR. Is an advanced setting still needed in that case? It would then be based upon the NetworkOffering.

@yadvr

yadvr commented Dec 28, 2017

Copy link
Copy Markdown
Member

Ping @jayapalu

@yadvr
yadvr changed the base branch from master to 4.11February 25, 2018 14:06
@yadvryadvr added this to the 4.11.1.0 milestone Apr 24, 2018
@yadvr
yadvr requested a review from DaanHooglandApril 24, 2018 13:34
@DaanHoogland

DaanHoogland commented Apr 26, 2018

Copy link
Copy Markdown
Contributor

@fmaximus did you already incorporate the changes here, maybe except the setting part? In case you did we can close this one.

@yadvr

yadvr commented May 2, 2018

Copy link
Copy Markdown
Member

@DaanHoogland@fmaximus@jayapalu ping, can you comment if this PR was already included in any other PR, or we still need this PR towards the config drive feature?

@DaanHoogland

DaanHoogland commented May 3, 2018

Copy link
Copy Markdown
Contributor

@rhtyd I don't see anything in this PR that is needed given other ConfigDrive functionality submitted in different PRs, awaitning responses from @jayapalu and @fmaximus

@yadvryadvr removed this from the 4.11.1.0 milestone May 4, 2018
@yadvr

yadvr commented May 4, 2018

Copy link
Copy Markdown
Member

@DaanHoogland okay, removed this PR from 4.11.1.0 milestone based on your comment.

@DaanHoogland

DaanHoogland commented May 4, 2018

Copy link
Copy Markdown
Contributor

@rhtyd thanks. I still want comments from @jayapalu and @fmaximus and maybe @kiwiflyer

@DaanHoogland

DaanHoogland commented Mar 6, 2020

Copy link
Copy Markdown
Contributor

@jayapalu I'm closing this, please rebase and re-open if it is still relevant

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHooglandDaanHooglandAwaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

status:waiting-for-authortype:enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jayapalu@kiwiflyer@cloudmonger@DaanHoogland@borisstoyanov@blueorangutan@yadvr@fmaximus@wido