[CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca… by konstantintrushin · Pull Request #2203 · apache/cloudstack

konstantintrushin · 2017-07-26T12:34:08Z

…using constant Vif creation in Virtual Router VM

When adding static nat eth interfaces are being added constantly to Virtual Route VM till they reach PCI slot limit. This is caused by public, prrivate and guest interfaces being marked as untagged and in HashMap values are overwritten and cleanupNetworkElementCommand dosn't know nic number in VR VM and constantly adds eth interfaces.

2017-07-25 10:47:21,054 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) Exexutiong cleanupNetworkElementCommand
2017-07-25 10:47:21,054 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-2:null) (logid:57628c13) Looking for libvirtd connection at: qemu:///system
2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {vlan://untagged=0}
2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=0}
2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=2}
2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=3}
2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=4}
2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) NIC pos 5
2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=4}
2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) Lokking for BroadcastUri vlan://261
2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) Plugging in VIF with MAC 1e:00:07:00:02:c8

…using constant Vif creation in Virtual Router VM When adding static nat eth interfaces are being added constantly to Virtual Route VM till they reach PCI slot limit. This is caused by public, prrivate and guest interfaces being marked as untagged and in HashMap values are overwritten and cleanupNetworkElementCommand dosn't know nic number in VR VM and constantly adds eth interfaces. 2017-07-25 10:47:21,054 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) Exexutiong cleanupNetworkElementCommand 2017-07-25 10:47:21,054 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-2:null) (logid:57628c13) Looking for libvirtd connection at: qemu:///system 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {vlan://untagged=0} 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=0} 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=2} 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=3} 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=4} 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) NIC pos 5 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, vlan://untagged=4} 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) Lokking for BroadcastUri vlan://261 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) (logid:57628c13) Plugging in VIF with MAC 1e:00:07:00:02:c8

cloudmonger · 2017-07-30T17:21:38Z

ACS CI BVT Run

Sumarry:
Build Number 1029
Hypervisor xenserver
NetworkType Advanced
Passed=97
Failed=17
Skipped=12

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

test_routers.py
test_03_restart_network_cleanup Failing since 8 runs
test_04_restart_network_wo_cleanup Failing since 8 runs
test_05_router_basic Failing since 8 runs
test_06_router_advanced Failing since 8 runs
test_08_start_router Failing since 8 runs
test_09_reboot_router Failing since 8 runs
test_network.py
test_reboot_router Failing since 8 runs
test_router_dns.py
test_router_dns_guestipquery Failed
test_deploy_vm_iso.py
test_deploy_vm_from_iso Failing since 83 runs
test_volumes.py
test_06_download_detached_volume Failing since 5 runs
test_nic.py
test_01_nic Failing since 8 runs
test_vm_life_cycle.py
test_10_attachAndDetach_iso Failing since 83 runs
test_routers_network_ops.py
test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 116 runs
test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 116 runs
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 113 runs
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 113 runs
test_03_RVR_Network_check_router_state Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_router_dnsservice.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_non_contigiousvlan.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

borisstoyanov

HI @konstantintrushin, thanks for this PR, can you please add JIRA number in the title same as other PRs. Thanks.

konstantintrushin · 2017-08-01T13:41:12Z

Hi Boris Where can I get Jira number?

…

Sent from my iPhone

On 1 Aug 2017, at 16:22, Boris Stoyanov - a.k.a Bobby ***@***.***> wrote: @borisstoyanov commented on this pull request. HI @konstantintrushin, thanks for this PR, can you please add JIRA number in the title same as other PRs. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

borisstoyanov · 2017-08-02T07:28:28Z

Hi @konstantintrushin, you can create a ticket describing your improvement/bugfix in the community JIRA: https://issues.apache.org/jira/browse/cloudstack/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel

konstantintrushin · 2017-08-03T14:54:19Z

I have created JIRA issue CLOUDSTACK-10029. If you need more details please contact me.

borisstoyanov · 2017-08-05T20:05:12Z

Thanks @konstantintrushin

yadvr · 2017-08-19T19:07:08Z

@blueorangutan package

blueorangutan · 2017-08-19T19:08:09Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-08-19T20:46:42Z

Packaging result: ✔centos6 ✖centos7 ✔debian. JID-969

borisstoyanov · 2017-08-21T06:15:36Z

@blueorangutan test

blueorangutan · 2017-08-21T06:16:07Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2017-08-21T09:35:56Z

@borisstoyanov trillian env requires centos7 pkgs to have been successfully built in order to run, the last env failed
@blueorangutan package

blueorangutan · 2017-08-21T09:37:07Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-08-21T09:37:19Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-08-21T10:16:06Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-990

borisstoyanov · 2017-08-21T10:35:35Z

@blueorangutan test

blueorangutan · 2017-08-21T10:37:08Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2017-09-16T06:51:26Z

 } else {
- if (nic.getBrName().equalsIgnoreCase(_publicBridgeName) || nic.getBrName().equalsIgnoreCase(_privBridgeName) ||
- nic.getBrName().equalsIgnoreCase(_guestBridgeName)) {
+ if (nic.getBrName() == null) {


@konstantintrushin can you consider checking using Strings.isNullOrEmpty?

yadvr · 2017-09-16T06:51:29Z

 } else {
- if (nic.getBrName().equalsIgnoreCase(_publicBridgeName) || nic.getBrName().equalsIgnoreCase(_privBridgeName) ||
- nic.getBrName().equalsIgnoreCase(_guestBridgeName)) {
+ if (nic.getBrName() == null) {


@konstantintrushin can you consider checking using Strings.isNullOrEmpty?

yadvr · 2017-12-19T07:20:36Z

Additional review requested
@blueorangutan package

blueorangutan · 2017-12-19T07:21:32Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-12-19T09:18:04Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1422

yadvr · 2017-12-19T19:48:52Z

@blueorangutan test

blueorangutan · 2017-12-19T19:49:32Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-12-20T16:39:15Z

Trillian test result (tid-1837)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27967 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2203-t1837-kvm-centos7.zip
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_privategw_acl	`Failure`	61.22	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	252.63	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	116.80	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	328.10	test_privategw_acl.py
test_02_create_template_with_checksum_sha1	`Error`	5.15	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	5.14	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	5.15	test_templates.py
test_05_rvpc_multi_tiers	`Failure`	189.93	test_vpc_redundant.py
test_01_vpc_remote_access_vpn	`Error`	50.53	test_vpc_vpn.py

yadvr · 2017-12-26T07:11:55Z

@konstantintrushin can you check if this is necessary given #2304 got merged.

yadvr · 2018-01-04T05:55:19Z

Given #2304 is merged, nics are now read from hashmap referenced using the mac address. I'll close this PR given this, please re-open/engage if you disagree, thanks for your PR.

kiwiflyer added type:bug component:networking labels Jul 29, 2017

borisstoyanov reviewed Aug 1, 2017
View reviewed changes

konstantintrushin changed the title ~~All private, public, and guest interfaceses are marked as untagged ca…~~[CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca…Aug 3, 2017

yadvr reviewed Sep 16, 2017
View reviewed changes

yadvr added this to the 4.11 milestone Dec 10, 2017

yadvr removed this from the 4.11 milestone Jan 3, 2018

yadvr closed this Jan 4, 2018

Uh oh!

Conversation

konstantintrushin commented Jul 26, 2017

Uh oh!

cloudmonger commented Jul 30, 2017

ACS CI BVT Run

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

konstantintrushin commented Aug 1, 2017 via email

Uh oh!

borisstoyanov commented Aug 2, 2017

Uh oh!

konstantintrushin commented Aug 3, 2017

Uh oh!

borisstoyanov commented Aug 5, 2017

Uh oh!

yadvr commented Aug 19, 2017

Uh oh!

blueorangutan commented Aug 19, 2017

Uh oh!

blueorangutan commented Aug 19, 2017

Uh oh!

borisstoyanov commented Aug 21, 2017

Uh oh!

blueorangutan commented Aug 21, 2017

Uh oh!

yadvr commented Aug 21, 2017

Uh oh!

blueorangutan commented Aug 21, 2017

Uh oh!

blueorangutan commented Aug 21, 2017

Uh oh!

blueorangutan commented Aug 21, 2017

Uh oh!

borisstoyanov commented Aug 21, 2017

Uh oh!

blueorangutan commented Aug 21, 2017

Uh oh!

yadvrSep 16, 2017

Choose a reason for hiding this comment

Uh oh!

yadvrSep 16, 2017

Choose a reason for hiding this comment

Uh oh!

yadvr commented Dec 19, 2017

Uh oh!

blueorangutan commented Dec 19, 2017

Uh oh!

blueorangutan commented Dec 19, 2017

Uh oh!

yadvr commented Dec 19, 2017

Uh oh!

blueorangutan commented Dec 19, 2017

Uh oh!

blueorangutan commented Dec 20, 2017

Uh oh!

yadvr commented Dec 26, 2017

Uh oh!

yadvr commented Jan 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants