CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat by fmaximus · Pull Request #2304 · apache/cloudstack

fmaximus · 2017-11-01T18:42:08Z

No description provided.

yadvr · 2017-11-02T07:29:41Z

@blueorangutan package

blueorangutan · 2017-11-02T07:30:26Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-11-02T07:57:03Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1190

yadvr · 2017-11-02T08:22:08Z

@blueorangutan test

blueorangutan · 2017-11-02T08:22:26Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-11-02T19:23:34Z

Trillian test result (tid-1607)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39666 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2304-t1607-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 47 look OK, 7 have error(s)

Test	Result	Time (s)	Test File
test_02_VPC_default_routes	`Failure`	823.28	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	`Failure`	858.30	test_vpc_router_nics.py
test_05_rvpc_multi_tiers	`Failure`	181.41	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Failure`	843.35	test_vpc_redundant.py
test_04_rvpc_privategw_static_routes	`Failure`	1020.25	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	909.93	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	934.84	test_privategw_acl.py
test_05_iso_permissions	`Failure`	0.05	test_iso.py
test_02_edit_iso	`Failure`	0.05	test_iso.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	226.83	test_internal_lb.py
test_01_vpc_site2site_vpn	`Error`	357.55	test_vpc_vpn.py
test_01_single_VPC_iptables_policies	`Error`	822.61	test_routers_iptables_default_policy.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	241.95	test_internal_lb.py
test_03_delete_vm_snapshots	Skipped	0.00	test_vm_snapshots.py
test_02_revert_vm_snapshots	Skipped	0.00	test_vm_snapshots.py
test_01_create_vm_snapshots	Skipped	0.00	test_vm_snapshots.py
test_09_copy_delete_template	Skipped	0.01	test_templates.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.02	test_staticroles.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.03	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_deploy_vgpu_enabled_vm	Skipped	0.00	test_deploy_vgpu_enabled_vm.py

yadvr · 2017-11-05T16:16:02Z

Several failures seen, I'll rerun tests.
@blueorangutan package

blueorangutan · 2017-11-05T16:16:25Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-11-05T16:43:33Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1208

yadvr · 2017-11-05T16:45:54Z

@blueorangutan test

blueorangutan · 2017-11-05T16:46:24Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-11-06T02:34:03Z

Trillian test result (tid-1619)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35255 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2304-t1619-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 48 look OK, 6 have error(s)

Test	Result	Time (s)	Test File
test_02_VPC_default_routes	`Failure`	893.04	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	`Failure`	822.59	test_vpc_router_nics.py
test_04_rvpc_privategw_static_routes	`Failure`	1004.25	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	984.15	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	908.70	test_privategw_acl.py
test_05_iso_permissions	`Failure`	0.04	test_iso.py
test_02_edit_iso	`Failure`	0.04	test_iso.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	236.22	test_internal_lb.py
test_01_vpc_site2site_vpn	`Error`	362.93	test_vpc_vpn.py
test_01_single_VPC_iptables_policies	`Error`	867.35	test_routers_iptables_default_policy.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	251.53	test_internal_lb.py
test_03_delete_vm_snapshots	Skipped	0.00	test_vm_snapshots.py
test_02_revert_vm_snapshots	Skipped	0.00	test_vm_snapshots.py
test_01_create_vm_snapshots	Skipped	0.00	test_vm_snapshots.py
test_09_copy_delete_template	Skipped	0.01	test_templates.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.01	test_staticroles.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.03	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_deploy_vgpu_enabled_vm	Skipped	0.01	test_deploy_vgpu_enabled_vm.py

yadvr · 2017-11-06T04:32:29Z

@fmaximus can you check new/additional failures than the baseline failures seen in #2289

svenvogel · 2017-11-08T10:15:50Z

@fmaximus is it ready for test or do we need to fix the checks first?

fmaximus · 2017-11-09T15:57:08Z

@rhtyd This branch is against 4.9, is there a baseline of failures on 4.9?

yadvr · 2017-11-09T16:00:36Z

@fmaximus I think I closed that old PR, can kick one over the weekend.

svenvogel · 2017-11-09T16:41:19Z

@rhtyd Close the old PR? Which one is the old one?

yadvr · 2017-11-09T17:00:34Z

@svenvogel Frank asked if we've a 4.9 baseline to compare against, I closed the last 4.9 smoketests PR #2217

svenvogel · 2017-11-12T21:14:29Z

Hi @fmaximus, Hi @rhtyd

we checked it again, it was our mistake. work in 4.10 without any problem.

+1

svenvogel · 2017-11-18T16:55:02Z

@fmaximus

Now we tried it with redundant VPC offering. It seems the same problem like this Bug. Normal offer is fixed with this but not redundant Offering. Thats not fixed with this pull request.

@fmaximus can this fix also applied to redundant offering?

thanks

Sven

yadvr · 2017-11-23T06:15:45Z

@fmaximus I see several failures compared to baseline 4.9 tests results: #2318

yadvr · 2017-11-23T06:15:57Z

@blueorangutan package

blueorangutan · 2017-11-23T06:16:19Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-11-23T06:42:20Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1286

yadvr · 2017-11-23T08:11:58Z

@blueorangutan test

blueorangutan · 2017-11-23T08:12:19Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

fmaximus · 2017-12-20T17:17:44Z

Rewrite using Mac Address, should work now.
Checked the implementation for PrivateGateway on LinuxBridge.

yadvr · 2017-12-20T17:50:59Z

Thanks @fmaximus I'll kick another round of tests
@blueorangutan package

blueorangutan · 2017-12-20T17:51:33Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-12-20T18:25:38Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1446

yadvr · 2017-12-20T19:12:55Z

@blueorangutan test

blueorangutan · 2017-12-20T19:13:32Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-12-21T01:57:20Z

Trillian test result (tid-1852)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24225 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2304-t1852-kvm-centos7.zip
Smoke tests completed. 51 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_edit_iso	`Failure`	0.08	test_iso.py
test_05_iso_permissions	`Failure`	0.07	test_iso.py
test_04_rvpc_privategw_static_routes	`Failure`	447.95	test_privategw_acl.py
test_10_attachAndDetach_iso	`Error`	31.96	test_vm_life_cycle.py

yadvr · 2017-12-21T09:35:09Z

Test LGTM, I'll check if rest of the failures are related to PR or environment introduced. Additional review requested - @marcaurele @wido @ustcweizhou @rafaelweingartner and others.

yadvr · 2017-12-22T09:40:06Z

For testing purposes, I've changed the branch's base to master to kick tests. Once they are okay, we can merge this.
@blueorangutan package

blueorangutan · 2017-12-22T09:40:33Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr

Code LGTM, subject to testing.

borisstoyanov · 2017-12-22T10:02:21Z

let me test this blocker as well

yadvr · 2017-12-22T10:03:33Z

I'll close and re-open this PR to re-kick travis, it's not pick up changes and failing due to base branch changes not propagated.

blueorangutan · 2017-12-22T10:05:19Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1459

borisstoyanov · 2017-12-22T10:05:45Z

@blueorangutan test

blueorangutan · 2017-12-22T10:06:32Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-12-22T18:18:03Z

Trillian test result (tid-1868)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29486 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2304-t1868-kvm-centos7.zip
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_privategw_acl	`Failure`	61.83	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	178.18	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	147.95	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	243.58	test_privategw_acl.py
test_02_create_template_with_checksum_sha1	`Error`	5.22	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	5.23	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	5.22	test_templates.py
test_01_vpc_remote_access_vpn	`Failure`	76.10	test_vpc_vpn.py

borisstoyanov

LGTM based on test results and code review

yadvr · 2017-12-23T03:48:03Z

Merged based on two lgtms and test results.

fmaximus added type:bug component:kvm component:virtual-router component:vpc labels Nov 1, 2017

fmaximus removed the status:waiting-for-author label Dec 20, 2017

yadvr requested review from DaanHoogland and nvazquez December 21, 2017 12:44

yadvr added the Severity:BLOCKER label Dec 22, 2017

yadvr changed the base branch from 4.9 to masterDecember 22, 2017 09:39

yadvr approved these changes Dec 22, 2017
View reviewed changes

yadvr closed this Dec 22, 2017

yadvr reopened this Dec 22, 2017

borisstoyanov approved these changes Dec 22, 2017
View reviewed changes

yadvr changed the base branch from master to 4.9December 23, 2017 03:46

yadvr merged commit c12e138 into apache:4.9Dec 23, 2017

yadvr mentioned this pull request Dec 26, 2017
[CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca… #2203
Closed

svenvogel mentioned this pull request Feb 14, 2019
Redundant VRouter guest network on wrong interface #3179
Closed

Uh oh!

Conversation

fmaximus commented Nov 1, 2017

Uh oh!

yadvr commented Nov 2, 2017

Uh oh!

blueorangutan commented Nov 2, 2017

Uh oh!

blueorangutan commented Nov 2, 2017

Uh oh!

yadvr commented Nov 2, 2017

Uh oh!

blueorangutan commented Nov 2, 2017

Uh oh!

blueorangutan commented Nov 2, 2017

Uh oh!

yadvr commented Nov 5, 2017

Uh oh!

blueorangutan commented Nov 5, 2017

Uh oh!

blueorangutan commented Nov 5, 2017

Uh oh!

yadvr commented Nov 5, 2017

Uh oh!

blueorangutan commented Nov 5, 2017

Uh oh!

blueorangutan commented Nov 6, 2017

Uh oh!

yadvr commented Nov 6, 2017

Uh oh!

svenvogel commented Nov 8, 2017

Uh oh!

fmaximus commented Nov 9, 2017

Uh oh!

yadvr commented Nov 9, 2017

Uh oh!

svenvogel commented Nov 9, 2017

Uh oh!

yadvr commented Nov 9, 2017

Uh oh!

svenvogel commented Nov 12, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svenvogel commented Nov 18, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yadvr commented Nov 23, 2017

Uh oh!

yadvr commented Nov 23, 2017

Uh oh!

blueorangutan commented Nov 23, 2017

Uh oh!

blueorangutan commented Nov 23, 2017

Uh oh!

yadvr commented Nov 23, 2017

Uh oh!

blueorangutan commented Nov 23, 2017

Uh oh!

fmaximus commented Dec 20, 2017

Uh oh!

yadvr commented Dec 20, 2017

Uh oh!

blueorangutan commented Dec 20, 2017

Uh oh!

blueorangutan commented Dec 20, 2017

Uh oh!

yadvr commented Dec 20, 2017

Uh oh!

blueorangutan commented Dec 20, 2017

Uh oh!

blueorangutan commented Dec 21, 2017

Uh oh!

yadvr commented Dec 21, 2017

Uh oh!

yadvr commented Dec 22, 2017

Uh oh!

blueorangutan commented Dec 22, 2017

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

svenvogel commented Nov 12, 2017•
edited
Loading

svenvogel commented Nov 18, 2017•
edited
Loading