Add support for zulu-11 in cloudstack 4.14 by ustcweizhou · Pull Request #3988 · apache/cloudstack

ustcweizhou · 2020-03-24T15:42:28Z

Description

Openjdk11 is not supported in Ubunt 16.04, we can use zulu-11 instead.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Steps to install zulu-11 on Ubuntu 16.04:

sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 0xB1998361219BD9C9
sudo echo 'deb http://repos.azulsystems.com/ubuntu stable main' >/etc/apt/sources.list.d/azul.list
sudo apt update
sudo apt install zulu-11 -y

Steps to install zulu-11 on Ubuntu 16.04: sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 0xB1998361219BD9C9 sudo echo 'deb http://repos.azulsystems.com/ubuntu stable main' >/etc/apt/sources.list.d/azul.list sudo apt update sudo apt install zulu-11 -y

yadvr · 2020-03-24T18:41:37Z

@blueorangutan package

blueorangutan · 2020-03-24T18:42:12Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland · 2020-03-24T19:03:01Z

how are we going to test this? I suppose you already did @weizhouapache .

blueorangutan · 2020-03-24T19:05:34Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1083

weizhouapache · 2020-03-24T19:46:19Z

how are we going to test this? I suppose you already did @weizhouapache .

@DaanHoogland yes, I have built packages, and install them on ubuntu 16.04 mgt server and hosts. it works well. did not see any issue until now.

DaanHoogland · 2020-03-25T09:02:26Z

great @weizhouapache formaly we need another tester but in view of the code I am not bothered, @andrijapanicsb ?

andrijapanicsb · 2020-03-25T09:51:02Z

@ustcweizhou as you've added zulu-11 as the dependency/to be installed, do you think this should fail if previously the proper repo/key is not added (per your instructions in this PR) ?

yadvr · 2020-03-25T09:57:11Z

Packaging is okay, we can do a normal install/upgrade on Ubuntu for testing. If you see the change it's simply adding an optional package name if openjdk-11 is not available @DaanHoogland @andrijapanicsb

weizhouapache · 2020-03-25T10:17:13Z

@ustcweizhou as you've added zulu-11 as the dependency/to be installed, do you think this should fail if previously the proper repo/key is not added (per your instructions in this PR) ?

@andrijapanicsb if other java11 package can be( or has been) installed, cloudstack installation/upgrade will not fail.

andrijapanicsb · 2020-03-25T10:24:37Z

LGTM

DaanHoogland · 2020-03-25T10:47:23Z

just to be sure
@blueorangutan test matrix

blueorangutan · 2020-03-25T10:48:16Z

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

svenvogel

LGTM

blueorangutan · 2020-03-25T18:57:54Z

Trillian test result (tid-1300)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27892 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3988-t1300-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	`Error`	0.15	test_kubernetes_supported_versions.py

andrijapanicsb · 2020-03-25T19:04:29Z

@shwstppr can you please take a look into the failing test if related at all?

thanks

DaanHoogland · 2020-03-25T19:17:06Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-03-25T19:18:17Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-03-25T19:19:31Z

Trillian test result (tid-1299)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29376 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3988-t1299-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	`Error`	0.19	test_kubernetes_supported_versions.py
test_01_scale_vm	`Failure`	14.33	test_scale_vm.py

shwstppr · 2020-03-26T09:57:50Z

@andrijapanicsb failed CKS test is not related as it fails dues availability of ISO url.

andrijapanicsb · 2020-03-26T10:00:43Z

thx!.

VMware tests are restarted, will be merging after it's finished.

DaanHoogland · 2020-03-26T14:16:35Z

@andrijapanicsb the vmware failed because it was build two days ago, before the merge of #3985. I am rebuilding but don't think we should let anything depend on this.

blueorangutan · 2020-03-26T14:26:20Z

Packaging result: ✔centos7 ✔debian. JID-1095

andrijapanicsb · 2020-03-26T18:35:44Z

@DaanHoogland afaik it failed due to name resolution issue, but anyway has been restarted. let's wait for results before merging.

DaanHoogland · 2020-03-26T19:42:56Z

@DaanHoogland afaik it failed due to name resolution issue, but anyway has been restarted. let's wait for results before merging.

No, i checked the last failed build. but it should be done, about midnight ;)

blueorangutan · 2020-03-27T07:25:48Z

Trillian test result (tid-1324)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59892 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3988-t1324-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 53 look OK, 24 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_UpdateConfigParamWithScope	`Error`	0.06	test_global_settings.py
test_02_vpc_privategw_static_routes	`Failure`	210.16	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	211.52	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	318.57	test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
ContextSuite context=TestScaleVm>:setup	`Error`	0.00	test_scale_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
test_01_sys_vm_start	`Failure`	0.06	test_secondary_storage.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	1511.65	test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
test_01_list_sec_storage_vm	`Failure`	0.02	test_ssvm.py
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_03_ssvm_internals	`Failure`	0.05	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.05	test_ssvm.py
test_05_stop_ssvm	`Failure`	0.02	test_ssvm.py
test_06_stop_cpvm	`Failure`	0.02	test_ssvm.py
test_07_reboot_ssvm	`Failure`	0.02	test_ssvm.py
test_08_reboot_cpvm	`Failure`	0.02	test_ssvm.py
test_09_destroy_ssvm	`Failure`	0.02	test_ssvm.py
test_10_destroy_cpvm	`Failure`	0.02	test_ssvm.py
test_02_create_template_with_checksum_sha1	`Error`	65.34	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.34	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.32	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.34	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	1.91	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=Test01DeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
test_change_service_offering_for_vm_with_snapshots	`Error`	1.17	test_vm_snapshots.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	7.86	test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs	`Failure`	240.59	test_host_maintenance.py

DaanHoogland · 2020-03-27T08:23:36Z

both trillian and travis have completely barfed. I am sure it has nothing to do with this change :(

andrijapanicsb · 2020-03-27T10:40:08Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-03-27T10:41:24Z

@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-03-27T20:08:58Z

Trillian test result (tid-1329)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32668 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3988-t1329-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 74 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_UpdateConfigParamWithScope	`Error`	0.08	test_global_settings.py
test_02_vpc_privategw_static_routes	`Failure`	194.33	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	204.10	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	374.16	test_privategw_acl.py
test_02_cancel_host_maintenace_with_migration_jobs	`Failure`	222.72	test_host_maintenance.py

andrijapanicsb · 2020-03-30T12:38:10Z

@weizhouapache any chance to see those failing test what is going on (test_UpdateConfigParamWithScope and test_02_cancel_host_maintenace_with_migration_jobs) ?

We seem to have identical failures on another PR (PR #3984 )

weizhouapache · 2020-03-30T15:08:01Z

@andrijapanicsb can you please ask the authors of related commits to have a look ?

andrijapanicsb · 2020-03-30T15:14:10Z

I'll try - these are tests that are failing in your and @nvazquez PR - which implies a test issue in master or so, if not mistaken?

andrijapanicsb · 2020-03-30T15:19:04Z

@rhtyd @nvazquez @shwstppr @davidjumani can anyone pick up please the failing tests - the same tests are failing in another PR (#3984 ) - which I believe implies those are present in master as well.

DaanHoogland · 2020-03-30T20:24:50Z

@rhtyd @nvazquez @shwstppr @davidjumani @andrijapanicsb @weizhouapache , small hint of which i don't know to what extend it is useful: several merges have been done over the last few weeks. I did notice these failures in 4.13 so it would be resolution of merge conflicts or the actual master commits.

weizhouapache · 2020-03-30T21:36:29Z

the failures with test_privategw_acl.py have been resolved in 4.14, you can ignore them, or backport the commit to 4.13

yadvr

LGTM, this is only adding optional package dependency names when the primary pkg is not available like openjdk-11-.... Per the changes, I think this will add no regression cc @DaanHoogland @andrijapanicsb

andrijapanicsb · 2020-04-01T16:39:11Z

As we have identical test failures on this one as on another PR #3984 - and this one just adds the dependency, I will merge it based on LGTMs/Approvals and the regression tests results.

Will hunt/fix those tests in that other PR and confirm it's all good.

yadvr added this to the 4.14.0.0 milestone Mar 24, 2020

yadvr approved these changes Mar 24, 2020
View reviewed changes

yadvr requested review from DaanHoogland, GabrielBrascher, andrijapanicsb and wido March 24, 2020 18:41

DaanHoogland approved these changes Mar 24, 2020
View reviewed changes

svenvogel added the type:enhancement label Mar 25, 2020

svenvogel approved these changes Mar 25, 2020
View reviewed changes

svenvogel added the component:packaging label Mar 25, 2020

DaanHoogland closed this Mar 26, 2020

DaanHoogland reopened this Mar 26, 2020

yadvr approved these changes Apr 1, 2020
View reviewed changes

andrijapanicsb merged commit 941cc4e into apache:masterApr 1, 2020

Uh oh!

Conversation

ustcweizhou commented Mar 24, 2020

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

yadvr commented Mar 24, 2020

Uh oh!

blueorangutan commented Mar 24, 2020

Uh oh!

DaanHoogland commented Mar 24, 2020

Uh oh!

blueorangutan commented Mar 24, 2020

Uh oh!

weizhouapache commented Mar 24, 2020

Uh oh!

DaanHoogland commented Mar 25, 2020

Uh oh!

andrijapanicsb commented Mar 25, 2020

Uh oh!

yadvr commented Mar 25, 2020

Uh oh!

weizhouapache commented Mar 25, 2020

Uh oh!

andrijapanicsb commented Mar 25, 2020

Uh oh!

DaanHoogland commented Mar 25, 2020

Uh oh!

blueorangutan commented Mar 25, 2020

Uh oh!

svenvogel left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Mar 25, 2020

Uh oh!

andrijapanicsb commented Mar 25, 2020

Uh oh!

DaanHoogland commented Mar 25, 2020

Uh oh!

blueorangutan commented Mar 25, 2020

Uh oh!

blueorangutan commented Mar 25, 2020

Uh oh!

shwstppr commented Mar 26, 2020

Uh oh!

andrijapanicsb commented Mar 26, 2020

Uh oh!

DaanHoogland commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

andrijapanicsb commented Mar 26, 2020

Uh oh!

DaanHoogland commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 27, 2020

Uh oh!

DaanHoogland commented Mar 27, 2020

Uh oh!

andrijapanicsb commented Mar 27, 2020

Uh oh!

blueorangutan commented Mar 27, 2020

Uh oh!

blueorangutan commented Mar 27, 2020

Uh oh!

andrijapanicsb commented Mar 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weizhouapache commented Mar 30, 2020

Uh oh!

andrijapanicsb commented Mar 30, 2020

Uh oh!

andrijapanicsb commented Mar 30, 2020

Uh oh!

DaanHoogland commented Mar 30, 2020

Uh oh!

weizhouapache commented Mar 30, 2020

Uh oh!

andrijapanicsb commented Mar 30, 2020•
edited
Loading