NPE fix for System VM's start Command

[pavanaravapalli]

Description

System VM's are failed to deploy on VM ware setup, due to NPE.

Solution : Added Null check for the same and took care of respective code flow changes.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Yet to test and update.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1080

[davidjumani]

Tested on VMware, Systemvms are coming up normally. LGTM

[DaanHoogland]

code lgtm, in spite of the twice used constant.
could have been
private static final VMWARE_BOOT_MODE = ApiConstants.BootType.BIOS.toString();

[DaanHoogland]

@blueorangutan test matrix

[blueorangutan]

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1292)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27373 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3985-t1292-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	Error	0.31	test_kubernetes_supported_versions.py

[blueorangutan]

Trillian test result (tid-1291)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3985-t1291-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	Error	0.34	test_kubernetes_supported_versions.py
test_01_scale_vm	Failure	17.67	test_scale_vm.py

[blueorangutan]

Trillian test result (tid-1293)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32115 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3985-t1293-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	Error	0.51	test_kubernetes_supported_versions.py

[borisstoyanov]

LGMT

[DaanHoogland]

@pavanaravapalli please review #4088/#4089